Skip to content

Check cancellation token in function/arrow/class expresisons, Cleanup after open file only if new file is opened in the request #32847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2019
Merged

Check cancellation token in function/arrow/class expresisons, Cleanup after open file only if new file is opened in the request #32847

merged 2 commits into from
Aug 13, 2019

Conversation

sheetalkamat
Copy link
Member

This includes fixes to improve the performance with completions in large js files.

  1. Cleanup after script info open needs to be done only if file is opened in updateOpen command
  2. Check cancellation token in Class expression, function expression and arrow expression as their counter part declarations so that we can exit sooner if the request is cancelled. (Which happens to be case in TS Completion is slow when opening another large file #31452 where suggestion diagnostics takes 30s for typescript.js and takes about 6-7 sec to cancel without this fix resulting in delays with completions)

Fixes #31452, #28389

@sheetalkamat
Do cleanup after opening files only if opening a file.
a35f799
@sheetalkamat
Add cancellation token check for function expression, arrow expressio…
c52b129 
…n and class expression just like their counter part declarations

This helps in early exit if request is cancelled and intellisense in js files is super quick with edits
@sheetalkamat sheetalkamat merged commit 370a596 into master Aug 13, 2019
@sheetalkamat sheetalkamat deleted the jsEditPerf branch August 13, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@orta orta Awaiting requested review from orta

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@sandersn sandersn Awaiting requested review from sandersn

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS Completion is slow when opening another large file
2 participants
@sheetalkamat @andrewbranch