Fix the semantic diagnostics caching in builder to handle conversion from relative to buildInfo to absolute path #33168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from relative to buildInfo to absolute path Fixes #33161
sheetalkamat
requested review from
sandersn,
andrewbranch,
orta,
rbuckton,
RyanCavanaugh and
weswigham
sandersn
approved these changes
Aug 30, 2019
|
@typescript-bot cherry-pick this to release-3.6 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 30, 2019
Component commits: 078ef7f Fix the semantic diagnostics caching in builder to handle conversion from relative to buildInfo to absolute path Fixes microsoft#33161
|
Hey @sheetalkamat, I've opened #33169 for you. |
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
…from relative to buildInfo to absolute path (microsoft#33168) Fixes microsoft#33161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantic diagnostics cache key was not converted to absolute path from the read builder program resulting in not caching diagnostics at all.
Did not come as part of unittests because the errors are reported correctly which is what we were verifying. Added test to verify the state now.
Fixes #33161