Fix incorrect string match on node_modules

[danyq]

ignoredPaths is used in a string match, so the dot is unnecessary and causes it to never match.

Fixes #33338
Related to #22826
Related to #31248
Related to #33335

[danyq]

I think tsc.js and tsserver.js are generated from this file and may need to be regenerated.

[danyq]

It looks like the tests are expecting node_modules to be in watchedDirectories, etc, and I suspect that's incorrect. Can anyone confirm?

[AviVahl]

I'm guessing the code aimed to ignore node_modules/.cache and such. Not the entire node_modules, which contains .d.ts files which are part of the compilation (and it can be argued whether they should be watched or not).

[danyq]

You're right, it looks like older code had the function isPathInNodeModulesStartingWithDot.

Watching node_modules is definitely questionable: ours has >136k files of which .cache is 2.6k. The number of watches for a normal project easily exceeds the default limit on some systems, and we suspect that it's related to other performance issues, like those mentioned above.

I'll close this though, and hope someone who knows better can address the issue.