-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Include *.json in the root files if they are specified as root #34676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a1c5daf
to
97a6622
Compare
Do we know why they used to be excluded? |
@RyanCavanaugh added it with project references but I didn't know that we excluded them. There is no reason to exclude them as far as I can see... |
@sheetalkamat Do we still want to exclude config files? (Or does that somehow happen upstream?) |
configs are never part of root file names.. (even through external projects as in that case we end up opening configured projects for those configs instead) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, but it would be nice to hear from @RyanCavanaugh.
Is this fix live on npm yet? |
@pcowgill |
To extend on @Bessonov’s fix, for me it was also necessary to force VSCode to use the workspace TypeScript version (duh). Add this to your {
"typescript.tsdk": "node_modules/typescript/lib"
} Then, after a |
Fixes #33827