Skip to content

This handles when packages are symbol links in mono repo like scenarios to use source files instead of output d.ts from project reference #34743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2019
Merged

This handles when packages are symbol links in mono repo like scenarios to use source files instead of output d.ts from project reference #34743

merged 3 commits into from
Oct 29, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #34723

@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 25, 2019 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 66f1a79. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/50915/artifacts?artifactName=tgz&fileId=9C80921BDBB4BCF9B39B6DBEE763FCA9EE99C39AB5580C17449A33A83925107A02&fileName=/typescript-3.8.0-insiders.20191025.tgz"
    }
}

and then running npm install.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, something went wrong when looking for the build artifact. (You can check the log here).

@kenotron
Copy link
Member

kenotron commented Oct 25, 2019 •
edited
Loading

This works! I've updated my branch to contain the tgz from this fix. Feel free to test that out as well!

@sheetalkamat
Copy link
Member Author

@RyanCavanaugh @DanielRosenwasser do we want this for 3.7 and is there going to be another 3.7 patch? I chatted with @kenotron offline and it seems to work for his scenario.

@kenotron
Copy link
Member

@RyanCavanaugh @DanielRosenwasser do we want this for 3.7 and is there going to be another 3.7 patch? I chatted with @kenotron offline and it seems to work for his scenario.

This is almost immediately going to provide lots of value for the 3.7 proj refs to source feature in monorepo scenarios. Lots of happy monorepo TS users there!

@kiprasmel
Copy link

kiprasmel commented Oct 26, 2019 •
edited
Loading

Just tried this out myself and can confirm that it works (typescript + yarn workspaces).

After updating typescript's version, I just needed to restart vscode and that's it!

Good job @sheetalkamat & @kenotron - I'd love this included in 3.7 c:

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.7

@typescript-bot typescript-bot mentioned this pull request Oct 28, 2019
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #34781 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 28, 2019
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#34743 into release-3.7
d0f4e7e 
Component commits:
06fda26 Fix incorrect outDir usage instead of out

66f1a79 Handle symlinks of packages in mono repo like packages Fixes microsoft#34723
DanielRosenwasser pushed a commit that referenced this pull request Oct 28, 2019
@DanielRosenwasser
🤖 Cherry-pick PR #34743 into release-3.7 (#34781)
1f3016f 
Component commits:
06fda26 Fix incorrect outDir usage instead of out

66f1a79 Handle symlinks of packages in mono repo like packages Fixes #34723
@sheetalkamat sheetalkamat merged commit dbef230 into master Oct 29, 2019
@sheetalkamat sheetalkamat deleted the symLinkedReferences branch October 29, 2019 17:49
@kiprasmel kiprasmel mentioned this pull request Oct 30, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@amcasey amcasey Awaiting requested review from amcasey

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

@orta orta Awaiting requested review from orta

@rbuckton rbuckton Awaiting requested review from rbuckton

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When monorepo like packages are linked through symlink and are not built editor cant resolve modules
6 participants
@sheetalkamat @typescript-bot @kenotron @kiprasmel @DanielRosenwasser @RyanCavanaugh