capture thisArg of optionalChaining in parens #35494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Dec 6, 2019
| //// [parentheses.js] | ||
| var _a; | ||
| (o1)(o1 !== null && o1 !== void 0 ? o1 : 1); | ||
| (o2 === null || o2 === void 0 ? void 0 : o2.b).call(o2, o1 !== null && o1 !== void 0 ? o1 : 1); |
There was a problem hiding this comment.
Nit: this doesn’t need a .call:
o2 === null || o2 === void 0 ? void 0 : o2.b(o1 ?? 1);There was a problem hiding this comment.
But that wouldn't throw an error if o2 is nullish.
There was a problem hiding this comment.
Ohh, it's wrapped in parens. Never mind, forgot that made the call non-optional.
|
@ajafff can you update this PR? Optional chaining has moved from esnext.ts to es2020.ts and the factory function calls need to be updated to use |
rbuckton
force-pushed
the
call-paren-optionalchain
branch
from
e12664a to
82f0538
Compare
|
I've gone ahead and made the necessary updates. Once CI passes I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35476
@rbuckton for review