Make classification cancellable. #3556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/services/services.ts
|
👍 |
1 similar comment
|
👍 |
| // constructs that we would expect to see commonly, but just at a far less frequent | ||
| // interval. | ||
| // | ||
| // For example, in checker.ts (around 750k) we only have around 600 of these constructs. |
There was a problem hiding this comment.
We could set an interval instead and query if the interval has not elapsed since last query.
CyrusNajmabadi
added a commit
that referenced
this pull request
Jul 6, 2015
Make classification cancellable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.