No error on indirect calls #35878
Closed
No error on indirect calls #35878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
added
Experiment
andrewbranch
added
For Backlog Bug
|
The TypeScript team hasn't accepted the linked issue #35866. If you can get it accepted, this PR will have a better chance of being reviewed. |
1 similar comment
|
The TypeScript team hasn't accepted the linked issue #35866. If you can get it accepted, this PR will have a better chance of being reviewed. |
|
Yes we have |
andrewbranch
requested changes
Oct 5, 2021
| return node.kind === SyntaxKind.Identifier && (node as Identifier).escapedText === "eval"; | ||
| function isInIndirectCall(node: BinaryExpression) { | ||
| return node.parent.kind === SyntaxKind.ParenthesizedExpression && (isCallExpression(node.parent.parent) && node.parent.parent.expression === node.parent || node.parent.parent.kind === SyntaxKind.TaggedTemplateExpression) && | ||
| (isAccessExpression(node.right) || isIdentifier(node.right) && node.right.escapedText === "eval"); |
There was a problem hiding this comment.
Why do we still have to check for eval? I think we want to silence the error for any indirect calls.
|
@ajafff Do you still want to work on this? Otherwise I'd like to close it to reduce the number of open PRs. |
|
Closing since this has gotten stale. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35866 (in case you want to accept that issue)
@RyanCavanaugh for review