Fix completion in func exp and class exp #3638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 24, 2015 14:10
| // fo$ <- completion list should contain local name "foo" | ||
| // } | ||
| // foo$ <- completion list should not contain "foo" | ||
| if (displayName === "__function" || displayName === "__class") { |
There was a problem hiding this comment.
We have a getDeclaredName which I think could be used in lieu of most of the logic in this if's block
There was a problem hiding this comment.
getDeclaredName doesn't do the right thing for functionExpression. Talk with @mhegazy, he says there will be some rewrite on that. So I don't want to have all the change in this PR
|
@yuit why was this closed? |
|
@DanielRosenwasser my PR is snapped using master from like 2 weeks ago :(. |
|
You can still merge in from |
|
It is huge . Anyhow, I cherry-picked some commit and incorporate your comments. Sorry for confusion here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3231 and add support for class expression