Skip to content

Handle this.# completions and add # to completion trigger character, #36462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

sheetalkamat
Copy link
Member

Handle private identifiers little better by creating token for private identifier when its just #
Report same error as invalid character but from language service we can now provide completions for this.#

Fixes #36367, #36250

Handle private identifiers little better by creating token for private identifier when its just #
Report same error as invalid character but from language service we can now provide completions for this.#

Fixes #36367, #36250
@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 I was wondering if we could do this without breaking stuff

@amcasey
Copy link
Member

amcasey commented Jan 27, 2020

The change LGTM, but I think VS might have to do work to pick it up. /cc @minestarks

@sheetalkamat sheetalkamat merged commit a87512d into master Jan 27, 2020
@sheetalkamat sheetalkamat deleted the privateIdentifierCompletion branch January 27, 2020 22:25
@minestarks
Copy link
Member

FYI @uniqueiniquity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add # as a completion trigger character
6 participants