-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Add test for #35011 #37312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for #35011 #37312
Conversation
When searching for a default configured project, stop at `node_modules`.
@@ -0,0 +1,43 @@ | |||
namespace ts { | |||
describe("unittests:: services:: projectService", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to go into unittests/tsserver/projects.ts
instead..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to move it, but I don't understand why - this doesn't seem to be a server test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I see that the corresponding product code is in the server folder, but I still don't understand why the language service is in "services" but the project service is in "server".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectService handles projects, hence is in server and not in language service folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are projects specific to the server?
@amcasey I think this is ready to go, right? |
@sandersn I think I just missed the sign-off notification. |
When searching for a default configured project, stop at
node_modules
.