Skip to content

Add test for #35011 #37312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Mar 10, 2020

When searching for a default configured project, stop at node_modules.

When searching for a default configured project, stop at
`node_modules`.
@amcasey amcasey requested a review from sheetalkamat March 10, 2020 01:02
@@ -0,0 +1,43 @@
namespace ts {
describe("unittests:: services:: projectService", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go into unittests/tsserver/projects.ts instead..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to move it, but I don't understand why - this doesn't seem to be a server test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I see that the corresponding product code is in the server folder, but I still don't understand why the language service is in "services" but the project service is in "server".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projectService handles projects, hence is in server and not in language service folder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are projects specific to the server?

@amcasey amcasey requested a review from sheetalkamat March 10, 2020 18:23
@sandersn sandersn added the Housekeeping Housekeeping PRs label Mar 25, 2020
@sandersn
Copy link
Member

@amcasey I think this is ready to go, right?

@amcasey
Copy link
Member Author

amcasey commented Mar 25, 2020

@sandersn I think I just missed the sign-off notification.

@amcasey amcasey merged commit e1772fa into microsoft:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Housekeeping PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants