Skip to content

Issue35876: Give better error message when Classic Module Resolution with incorrect path #38105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orta merged 8 commits into from
Jul 30, 2020
Merged

Issue35876: Give better error message when Classic Module Resolution with incorrect path #38105

orta merged 8 commits into from
Jul 30, 2020

Conversation

@mshivaku99
Copy link
Contributor

@mshivaku99 mshivaku99 commented Apr 22, 2020

Fixes #35876

@msftclas
Copy link

msftclas commented Apr 22, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@orta orta self-assigned this Apr 22, 2020
@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label May 5, 2020
@sandersn
Copy link
Member

sandersn commented May 21, 2020

@mshivaku99 Do you want to keep working on this? I think the next steps from @orta are pretty clear. Let us know if we can help another way.

@mshivaku99
Copy link
Contributor Author

mshivaku99 commented May 22, 2020

@mshivaku99 Do you want to keep working on this? I think the next steps from @orta are pretty clear. Let us know if we can help another way.

I can work on it this weekend! Sorry for the delay!

@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 13, 2020
Closed
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jul 13, 2020

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address that you're using for your commits, or rebase and amend your commits to fix the author name and email.

@orta
Copy link
Contributor

orta commented Jul 14, 2020

Alright, I've addressed my feedback and given this a rebase - @DanielRosenwasser can you review?

DanielRosenwasser
DanielRosenwasser reviewed Jul 14, 2020
View reviewed changes
@orta
Copy link
Contributor

orta commented Jul 30, 2020

This PR has had a fresh 2nd look, just verifying that every part of the diff is needed now

@orta
Copy link
Contributor

orta commented Jul 30, 2020 •
edited
Loading

They are 👍 - good for review again | Making green | We should be good now

@orta orta merged commit bffe354 into microsoft:master Jul 30, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

+1 more reviewer

@orta orta orta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@orta orta

@DanielRosenwasser DanielRosenwasser

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Give better error messages for bare imports with badly configured projects

5 participants

@mshivaku99 @msftclas @sandersn @DanielRosenwasser @orta