Repository navigation
fix(38299): Bug in the __rest helper function for numeric properties - #38600
Merged
Merged
Conversation
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/38299
branch
from
May 16, 2020 05:28
5edd35c to
3f6ccba
Compare
Nathan Shively-Sanders (sandersn)
added
the
For Milestone Bug
Ron Buckton (rbuckton)
suggested changes
May 20, 2020
Ron Buckton (rbuckton)
left a comment
Ron Buckton (rbuckton)
left a comment
Contributor
There was a problem hiding this comment.
One more minor change.
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/38299
branch
from
May 20, 2020 19:48
3f6ccba to
fe5a726
Compare
Ron Buckton (rbuckton)
approved these changes
May 20, 2020
Contributor
|
Looks good, thanks! |
AllenLee (cangSDARM)
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
May 21, 2020
* upstream/master: Make new error an error, not message fix(38299): use string literals as keys to creating rest result (microsoft#38600) Intersection check for empty object type shouldn't cause circularities (microsoft#38673) fix(38682): use stable typescript version (microsoft#38683) Add d.ts for Intl.RelativeTimeFormat (microsoft#36084) fix(38295): handle duplicate object literal keys which contain '+' and '-' tokens make last para of Actomics.notify optional. Fix some JSDoc factory function return types. fix order and tests move to invocationErrorDetails replace the original not-callable error Add _0_is_declared_here pointing to accessor declaration Better error message for accidental calls to get-accessors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38299