Skip to content

Fix relation between generic mapped types and types with index signatures #38761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2020
Merged

Fix relation between generic mapped types and types with index signatures #38761

merged 2 commits into from
May 25, 2020

Conversation

ahejlsberg
Copy link
Member

Fixes #38235.

@ahejlsberg
Copy link
Member Author

This is a very safe fix, so I've marked the issue for the 3.9 May Servicing. If that's too aggressive we can move it to 4.0.

@ahejlsberg ahejlsberg merged commit c5b8f4f into master May 25, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 26, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
470bcf6 
* upstream/master:
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Fix relation between generic mapped types and types with index signatures (microsoft#38761)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Revert "Wrap classes with decorators or static properties in an IIFE, even for ES2015+ (microsoft#32011)"
  Preserve module marker in es2015+ module emit for tool compatability (microsoft#38712)
  Fix recently added test so it is cross-plat
  fix(33286): add outlining for arrow function with one parameter (microsoft#38631)
  fix(38463): show completions for index access properties
@InExtremaRes
Copy link

I think this is not included for 3.9 (yet?). Can be? I tried installing directly from github #release-3.9 but the bug persists. Thank you in advance :)

@jakebailey jakebailey deleted the fix38235 branch November 7, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No-op mapped type not assignable; but original type is assignable
3 participants
@ahejlsberg @InExtremaRes @weswigham