Skip to content

Rename callbackfn params to predicate where possible #39056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Rename callbackfn params to predicate where possible #39056

wants to merge 1 commit into from

Conversation

shvaikalesh
Copy link
Contributor

@shvaikalesh shvaikalesh commented Jun 12, 2020

This change aligns parameter naming of ES5 predicate methods (every, filter, some) with ES6+ counterparts (find, findIndex).

tc39/ecma262#1782 is a PR against the ECMA-262 to do the same. Aligning TypeScript naming would help move it forward.

@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Jun 12, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

CLA assistant check
All CLA requirements met.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 17, 2020

Please reopen with the changes in src/lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib update PR modifies files in the `lib` folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants