-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Improve inference for Promise.all of 'never[]' #39336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makes sense to me, but should we run user tests? @typescript-bot user test this |
Heya @andrewbranch, I've started to run the parallelized community code test suite on this PR at eb27d3e. You can monitor the build here. |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
There’s one relevant change: https://github.com/typescript-bot/TypeScript/pull/54/files#diff-ce8b151b649148d02935b814380073d7 |
Yeah, looking at this a little bit more, there really isn't a way to craft the overload list to get the correct result here. |
Actually, I may have found a solution. I'll try that first before giving up on this line of thought... |
@typescript-bot test this |
Even this doesn't work because it collides with For reference: |
I'm switching this to a draft PR for the time being while I consider other alternatives. |
This adds overloads to
Promise.all
to improve treat aPromise.all
for an array of typenever[]
as aPromise<never>
rather than aPromise<never[]>
.Fixes #37856