Skip to content

switch typeof any could be checked for unreachable #39389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2020
Merged

switch typeof any could be checked for unreachable #39389

merged 5 commits into from
Jul 21, 2020

Conversation

ShuiRuTian
Copy link
Contributor

Fixes #39343

@RyanCavanaugh RyanCavanaugh requested a review from ahejlsberg July 8, 2020 20:38
ahejlsberg
ahejlsberg approved these changes Jul 8, 2020
View reviewed changes
@ShuiRuTian ShuiRuTian requested a review from ahejlsberg July 10, 2020 10:12
orta
orta approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a one over with wes and it looks good - thanks!

@orta orta merged commit 5484687 into microsoft:master Jul 21, 2020
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 21, 2020
@ShuiRuTian ShuiRuTian deleted the switch-typeof-any-unreachable branch November 25, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch exhaustiveness not working for typeof any and typeof unknown
4 participants
@ShuiRuTian @orta @ahejlsberg @typescript-bot