🤖 User test baselines have changed for refs/heads/master #39881
Conversation
typescript-bot
added
the
For Uncommitted Bug
typescript-bot
force-pushed
the
user-baseline-updates
branch
28 times, most recently
from
0de1d4f to
200aeae
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
19 times, most recently
from
3947db0 to
18c3875
Compare
| @fluentui/react-icons: error Command failed with exit code 1. | ||
| lerna ERR! yarn run build exited 1 in '@fluentui/react-icons' | ||
| @fluentui/ability-attributes: /office-ui-fabric-react/node_modules/electron/index.js:14 | ||
| @fluentui/ability-attributes: throw new Error('Electron failed to install correctly, please delete node_modules/electron and try installing again') |
There was a problem hiding this comment.
Not sure whether this is blocking the rest of office-ui-fabric results. @weswigham can you investigate?
|
|
||
|
|
||
|
|
||
| Standard error: | ||
|
|
||
| ../../../src/compiler/checker.ts:2397 | ||
| const name = (node.initializer.expression as CallExpression).arguments[0] as StringLiteral; |
There was a problem hiding this comment.
caused by chained property accesses: const x = require('y').z.ka
typescript-bot
force-pushed
the
user-baseline-updates
branch
5 times, most recently
from
66823cd to
2aa432e
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
2aa432e to
d091781
Compare
| @@ -83,7 +83,6 @@ node_modules/npm/lib/cache.js(16,34): error TS2339: Property 'commands' does not | |||
| node_modules/npm/lib/cache.js(49,30): error TS2339: Property 'prefix' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/lib/cache.js(69,35): error TS2339: Property 'cache' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/lib/cache.js(70,12): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/lib/cache.js(82,3): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation. | |||
There was a problem hiding this comment.
bogus assertion error from node's assert is now gone
| @@ -1481,6 +1456,10 @@ node_modules/npm/test/tap/no-scan-full-global-dir.js(5,29): error TS2307: Cannot | |||
| node_modules/npm/test/tap/no-scan-full-global-dir.js(28,6): error TS2339: Property 'code' does not exist on type 'Error'. | |||
| node_modules/npm/test/tap/no-scan-full-global-dir.js(34,6): error TS2339: Property 'code' does not exist on type 'Error'. | |||
| node_modules/npm/test/tap/no-scan-full-global-dir.js(43,7): error TS2339: Property 'load' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/test/tap/no-scan-full-global-dir.js(71,8): error TS2339: Property 'loadCurrentTree' does not exist on type 'TestInstaller'. | |||
There was a problem hiding this comment.
repros on 3.3 and 3.9 as well -- seems like this must come from a diff in npm, but the file hasn't changed for a year.
| @@ -0,0 +1,73 @@ | |||
| Exit Code: 2 | |||
| Standard output: | |||
| scripts/install-prettier.js(16,22): error TS2339: Property 'exec' does not exist on type 'typeof shell'. | |||
There was a problem hiding this comment.
typescript doesn't give an error when you use properties on an any-typed import, and neither should javascript
| @@ -6,6 +6,8 @@ node_modules/soap/lib/http.d.ts(2,22): error TS7016: Could not find a declaratio | |||
| Try `npm install @types/request` if it exists or add a new declaration (.d.ts) file containing `declare module 'request';` | |||
| node_modules/soap/lib/types.d.ts(1,22): error TS7016: Could not find a declaration file for module 'request'. '../../../tests/cases/user/soap/node_modules/request/index.js' implicitly has an 'any' type. | |||
| Try `npm install @types/request` if it exists or add a new declaration (.d.ts) file containing `declare module 'request';` | |||
| node_modules/soap/lib/wsdl/index.d.ts(1,22): error TS7016: Could not find a declaration file for module 'sax'. '../../../tests/cases/user/soap/node_modules/sax/lib/sax.js' implicitly has an 'any' type. | |||
| Try `npm install @types/sax` if it exists or add a new declaration (.d.ts) file containing `declare module 'sax';` | |||
There was a problem hiding this comment.
from new version of soap, 0.33.0
| @@ -14,7 +14,12 @@ node_modules/uglify-js/lib/ast.js(1246,29): error TS2339: Property 'parent' does | |||
| node_modules/uglify-js/lib/compress.js(188,42): error TS2554: Expected 0 arguments, but got 1. | |||
| node_modules/uglify-js/lib/compress.js(557,41): error TS2554: Expected 0 arguments, but got 1. | |||
| node_modules/uglify-js/lib/compress.js(698,27): error TS2339: Property 'name' does not exist on type '(Anonymous function)'. | |||
| node_modules/uglify-js/lib/compress.js(757,21): error TS2339: Property 'name' does not exist on type '(Anonymous function)'. | |||
There was a problem hiding this comment.
these look leftover from the var self = this aliasing feature. I'm not sure why they weren't accepted earlier.
| @@ -36,6 +36,8 @@ node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(235,4): error TS2322: | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(246,4): error TS2322: Type 'null' is not assignable to type '(path: any) => any'. | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(252,24): error TS2322: Type 'null' is not assignable to type '(path: any, callback: any) => void'. | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(257,28): error TS2322: Type 'null' is not assignable to type '(path: any) => any'. | |||
| node_modules/enhanced-resolve/lib/Resolver.js(56,8): error TS2339: Property '_pluginCompat' does not exist on type 'Resolver'. | |||
| node_modules/enhanced-resolve/lib/Resolver.js(65,8): error TS2339: Property '_pluginCompat' does not exist on type 'Resolver'. | |||
There was a problem hiding this comment.
looks like stricter rules for accessing properties on class that extend an imported identifier of type any, from an untyped module
Added this to the other bug I filed, although this behaviour is the same as TS.
| bin/webpack.js(63,8): error TS2300: Duplicate identifier 'path'. | ||
| bin/webpack.js(127,8): error TS2300: Duplicate identifier 'path'. | ||
| lib/ChunkGraph.js(500,3): error TS2741: Property 'prototype' is missing in type 'RuntimeSpecSet' but required in type 'typeof RuntimeSpecSet'. | ||
| lib/ChunkGraph.js(1160,41): error TS2339: Property 'values' does not exist on type 'typeof RuntimeSpecMap'. |
There was a problem hiding this comment.
Looks like we're resolving this class type reference incorrectly
There was a problem hiding this comment.
This is because module.exports.K = K doesn't create an alias like export { K } does. Filed #40155 to track this, where the real fix is probably to make at least the previous construction create an export alias.
|
Filed 3 bugs to track new failures from commonjs import aliases. I'm going to merge this now, but @weswigham can you look to see if office-ui-fabric is able to report results properly? |
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript