Skip to content

Add an 'Update LKG' action #39897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

Add an 'Update LKG' action #39897

merged 1 commit into from
Aug 4, 2020

Conversation

DanielRosenwasser
Copy link
Member

No description provided.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 4, 2020
@DanielRosenwasser DanielRosenwasser merged commit 817dc52 into master Aug 4, 2020
@DanielRosenwasser DanielRosenwasser deleted the updateLKGAction branch August 4, 2020 07:05
DanielRosenwasser added a commit that referenced this pull request Aug 4, 2020
@DanielRosenwasser
Add an 'Update LKG' action (#39897)
4f02a04
weswigham
weswigham reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should runtests (at a minimum, IMO) after the LKG and before pushing - accepting an LKG that breaks the build shouldn't be a thing that's allowed.

@DanielRosenwasser
Copy link
Member Author

As far as I can tell, I think it does that: https://github.com/microsoft/TypeScript/runs/943760878?check_suite_focus=true#step:4:139

@DanielRosenwasser
Copy link
Member Author

Yeah, the npm test command is in the yml file

@weswigham
Copy link
Member

Oh, duh, I missed it because I was looking for the gulp command directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham left review comments

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielRosenwasser @weswigham @typescript-bot