No parent pointers in emitter #4010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function getEnclosingBlockScopeContainer(node: Node): Node; | ||
| export function getEnclosingBlockScopeContainer(node: Node, getAncestorOrSelf: (offset: number) => Node, offset: number): Node; | ||
| export function getEnclosingBlockScopeContainer(node: Node, getAncestorOrSelf?: (offset: number) => Node, offset?: number): Node { | ||
| let current = getAncestorOrSelf ? getAncestorOrSelf(++offset) : node.parent; |
There was a problem hiding this comment.
Just looking at it, I'm not sure what the implied behavior of getAncestorOfSelf is doing with offset and why you need to increment it when feeding the value. A (potentially JSDoc) comment would be helpful.
There was a problem hiding this comment.
I've added some detailed remarks about its purpose and usage
| * This is done so that nodes like variable declarations and binding elements can return | ||
| * a view of their flags that includes the modifiers from their container. i.e. flags like | ||
| * export/declare aren't stored on the variable declaration directly, but on the containing | ||
| * variable statement (if it has one). Similarly, flags for let/const are store on the |
| @@ -788,6 +791,249 @@ namespace ts { | |||
| getSignatureConstructor: () => <any>Signature | |||
| }; | |||
|
|
|||
| /** | |||
| * Creates an object used to navigate the ancestor's of a node by following parent pointers. | |||
|
@rbuckton I think this is almost ready to go in, can you resolve the merge conflicts? |
|
This will need another sync-up |
|
We should close this one. |
|
Closing this as it is out of date and will be superseded by a different approach. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes most of the emitter's dependency on parent pointers, to facilitate tree transformations that will generate synthesized nodes.
As we descend into the tree, we keep track of the current node stack. Generally this happens automatically as we call
emit, however in cases where we have special transformations in the output (such as for ES5 emit of ES6 classes), we must manually push interceding nodes onto the stack to maintain the hierarchy.To verify node stack consistency, at the top of most functions in the emitter is a call to
verifyStackBehavior, which can be used to catch developer errors when adding new functions to the emitter.