-
Notifications
You must be signed in to change notification settings - Fork 12.8k
🤖 User test baselines have changed for refs/heads/master #40156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 User test baselines have changed for refs/heads/master #40156
Conversation
d091781
to
d4ec988
Compare
e4644e5
to
e891608
Compare
@uifabric/build: create-package/plop-templates-react/src/version.ts:3:28 - error TS2307: Cannot find module '@uifabric/set-version' or its corresponding type declarations. | ||
@uifabric/build: 3 import { setVersion } from '@uifabric/set-version'; | ||
@uifabric/build: ~~~~~~~~~~~~~~~~~~~~~~~ | ||
@uifabric/build: exec-sync.js:4:7 - error TS6133: 'chalk' is declared but its value is never read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #40185 to track this
3df14bc
to
288649d
Compare
3f6e7ee
to
fe40bdc
Compare
fe40bdc
to
e597b0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diffs are basically OK except for office-ui-fabric, but that needs an overhaul of the build entirely. I'm going to accept the changes for now, but we should fix the build so the test is actually useful.
/vue-next/packages/compiler-ssr/src/index.ts → packages/compiler-ssr/dist/compiler-ssr.cjs.js... | ||
created packages/compiler-ssr/dist/compiler-ssr.cjs.js in ?s | ||
/vue-next/packages/reactivity/src/index.ts → packages/reactivity/dist/reactivity.esm-bundler.js... | ||
[!] (plugin rpt2) Error: /vue-next/packages/reactivity/src/collectionHandlers.ts(24,3): semantic error TS2322: Type 'T | DeepReadonly<UnwrapNestedRefs<T & Record<any, any>>>' is not assignable to type 'T'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from #39258 -- it's probably by-design, but it's hard to tell whether it should get an exemption.
@@ -105,7 +105,7 @@ node_modules/adonis-framework/src/Helpers/index.js(240,45): error TS2345: Argume | |||
Type 'undefined' is not assignable to type 'string'. | |||
node_modules/adonis-framework/src/Helpers/index.js(256,45): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'. | |||
Type 'undefined' is not assignable to type 'string'. | |||
node_modules/adonis-framework/src/Helpers/index.js(330,31): error TS2339: Property 'mainModule' does not exist on type 'Process'. | |||
node_modules/adonis-framework/src/Helpers/index.js(330,23): error TS2532: Object is possibly 'undefined'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@types/node update
@@ -136,12 +136,15 @@ node_modules/adonis-framework/src/Response/index.js(56,7): error TS1056: Accesso | |||
node_modules/adonis-framework/src/Response/index.js(68,7): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher. | |||
node_modules/adonis-framework/src/Response/index.js(76,15): error TS2304: Cannot find name 'Mixed'. | |||
node_modules/adonis-framework/src/Response/index.js(95,16): error TS2304: Cannot find name 'Html'. | |||
node_modules/adonis-framework/src/Response/index.js(144,12): error TS1003: Identifier expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error from @see
(and in the rest of adonis)
@@ -3,17 +3,21 @@ Standard output: | |||
node_modules/async/all.js(32,12): error TS2304: Cannot find name 'AsyncFunction'. | |||
node_modules/async/all.js(49,20): error TS2695: Left side of comma operator is unused and has no side effects. | |||
node_modules/async/all.js(49,46): error TS2695: Left side of comma operator is unused and has no side effects. | |||
node_modules/async/allLimit.js(28,9): error TS1003: Identifier expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected @see
format: @see [title]{@link reference}
@@ -26,7 +25,6 @@ node_modules/chrome-devtools-frontend/front_end/Runtime.js(746,5): error TS2322: | |||
Type '{}' is missing the following properties from type 'Window': applicationCache, clientInformation, closed, customElements, and 224 more. | |||
node_modules/chrome-devtools-frontend/front_end/Runtime.js(1083,15): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value. | |||
node_modules/chrome-devtools-frontend/front_end/Runtime.js(1088,15): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value. | |||
node_modules/chrome-devtools-frontend/front_end/Tests.js(107,5): error TS2322: Type 'Timeout' is not assignable to type 'number'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure whether this is an improvement in control flow or in @types/node types.
lib/FlagDependencyExportsPlugin.js(295,16): error TS2339: Property 'log' does not exist on type 'typeof WebpackLogger'. | ||
lib/FlagDependencyExportsPlugin.js(309,16): error TS2339: Property 'time' does not exist on type 'typeof WebpackLogger'. | ||
lib/FlagDependencyExportsPlugin.js(330,18): error TS2339: Property 'timeEnd' does not exist on type 'typeof WebpackLogger'. | ||
lib/ExportsInfo.js(1063,28): error TS1016: A required parameter cannot follow an optional parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from new code; repros in 4.0 too
Property 'prototype' does not exist on type 'Math'. | ||
node_modules/uglify-js/lib/propmangle.js(70,45): error TS2339: Property 'prototype' does not exist on type 'ObjectConstructor | FunctionConstructor | StringConstructor | BooleanConstructor | NumberConstructor | ... 4 more ... | ArrayConstructor'. | ||
node_modules/uglify-js/lib/propmangle.js(71,44): error TS2351: This expression is not constructable. | ||
Not all constituents of type 'ObjectConstructor | FunctionConstructor | StringConstructor | BooleanConstructor | NumberConstructor | ... 4 more ... | ArrayConstructor' are constructable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better checking for construct signatures on unions? This error is correct ,at least.
node_modules/uglify-js/lib/parse.js(1506,35): error TS2531: Object is possibly 'null'. | ||
node_modules/uglify-js/lib/parse.js(1551,52): error TS2531: Object is possibly 'null'. | ||
node_modules/uglify-js/lib/propmangle.js(69,18): error TS2339: Property 'prototype' does not exist on type 'ObjectConstructor | FunctionConstructor | StringConstructor | BooleanConstructor | NumberConstructor | ... 4 more ... | ArrayConstructor'. | ||
node_modules/uglify-js/lib/parse.js(1120,17): error TS2454: Variable 'cur' is used before being assigned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this error comes from the same information as before, and is just as correct; I'm not sure what caused it to change, though.
node_modules/uglify-js/lib/sourcemap.js(82,11): error TS2339: Property 'index' does not exist on type 'any[]'. | ||
node_modules/uglify-js/lib/sourcemap.js(178,31): error TS2339: Property 'index' does not exist on type 'any[]'. | ||
node_modules/uglify-js/lib/sourcemap.js(186,34): error TS2339: Property 'index' does not exist on type 'any[]'. | ||
node_modules/uglify-js/lib/transform.js(47,21): error TS2345: Argument of type 'this' is not assignable to parameter of type 'TreeWalker'. | ||
Type 'TreeTransformer' is missing the following properties from type 'TreeWalker': currentNode, filter, root, whatToShow, and 10 more. | ||
node_modules/uglify-js/tools/exit.js(10,37): error TS2345: Argument of type 'any[]' is not assignable to parameter of type '[code?: number | undefined]'. | ||
Target allows only 1 element(s) but source may have more. | ||
node_modules/uglify-js/tools/exports.js(1,1): error TS2303: Circular definition of import alias '"Dictionary"'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this used to be ignored, now it's treated like a real export and gives an error because none of the references resolve.
Exit Code: 2 | ||
Standard output: | ||
node_modules/@types/enzyme/index.d.ts(368,15): error TS2304: Cannot find name 'Cheerio'. | ||
node_modules/@types/enzyme/index.d.ts(640,69): error TS2304: Cannot find name 'Cheerio'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@types/enzyme@2
specifies @types/cheerio@*
, so it gets the newest, incompatible version...
This is a Typescript-react-starter problem, not a user problem. I'll see if we care about upgrading to a newer version of enzyme.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript