-
Notifications
You must be signed in to change notification settings - Fork 12.8k
fix(40320): Better errors when using properties/methods from newer versions of ECMAScript #40650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think the PR is ready, do you see any major flaws in my solution @DanielRosenwasser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very close to being ready! Let's keep iterating here.
I added your suggested changes, this might be the one, or it might need one more iteration. @DanielRosenwasser |
Ready for review @DanielRosenwasser |
Looks like you'll need to update baselines. |
@DanielRosenwasser Thanks for all the extensive reviews! I added the early bail-outs and updated the baselines to reflect the changes to the main upstream branch. Is there some documentation for all the utility functions such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests 😍 |
Fixes #40320 and #40319
New Error Messages
Error message when properties/methods are missing due to lib configuration
"Property '{0}' does not exist on type '{1}'. Do you need to change your target library? Try changing the `lib` compiler option to '{2}' or later."
Error message when the name cannot be found due to lib configuration
"Cannot find name '{0}'. Do you need to change your target library? Try changing the `lib` compiler option to '{1}' or later."
Preview