Ensure factory symbol remains unused in react-jsx mode when not referenced in user code #41905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enced in user code
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
approved these changes
Dec 10, 2020
| @@ -0,0 +1,16 @@ | |||
| // @esModuleInterop: true | |||
| // @noUnusedLocals: true | |||
| // @jsx: react-jsx,react-jsxdev | |||
| @@ -26912,6 +26912,9 @@ namespace ts { | |||
| errorOutputContainer); | |||
|
|
|||
| function checkTagNameDoesNotExpectTooManyArguments(): boolean { | |||
| if (getJsxNamespaceContainerForImplicitImport(node)) { | |||
| return true; // factory is implicitly jsx/jsxdev - assume it fits the bill, since we don't strongly look for the jsx/jsxs/jsxDEV factory APIs anywhere else (at least not yet) | |||
There was a problem hiding this comment.
This makes sense, but it’s unintuitive as to why it fixes this particular bug. Something later in this function marked React as referenced, for some reason?
There was a problem hiding this comment.
Yeah - looking up it's type to see if it had call signatures.
|
Thanks for fixing this! |
|
So far, it’s slated for 4.2.0. When the rest of the team returns from vacation next week, we could discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our checks was assuming the old-style jsx emit unconditionally and looking up the jsx factory entity name, which in turn would flag it as referenced.
Fixes #41882