Allow nested reverse mapped type printback #42485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
@typescript-bot perf test this |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 84241ef. You can monitor the build here. |
|
Heya @weswigham, I've started to run the perf test suite on this PR at 84241ef. You can monitor the build here. Update: The results are in! |
|
Heya @weswigham, I've started to run the extended test suite on this PR at 84241ef. You can monitor the build here. |
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 84241ef. You can monitor the build here. |
|
@weswigham Here they are:Comparison Report - master..42485
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
sandersn
reviewed
Feb 1, 2021
3 tasks
ahejlsberg
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the reverse mapped type in question both isn't already being printed, and isn't the child type of a reverse mapping over a non-anonymous type (eg,
WindoworNumber). This means that reverse mappings over object literal expression types should be printed back in full, rather than getting truncated.To support this change, I've added caching into reverse mapped symbol type lookup (previously we'd redo the inference every time we asked for the type of the symbol), and introduced a simplification into the construction of reverse mapped symbols so we manufacture less type identities when doing deep reverse mappings (by recognizing that
{[K in keyof T[K_1]]: Whatever<T[K_1]>]}is equivalent to{[K in keyof T]: Whatever<T>]}as far as reverse mapped symbol type inference is concerned). Without that, we'd manufacture new sets of type identities for every type mapped over for every level "down" we had to recur within a deeply-reverse mapped type.Fixes #40003 in most cases.