-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Unnecessary elaboration about not being assignable to type parameters #42952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
tests/baselines/reference/doNotElaborateAssignabilityToTypeParameters.errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| tests/cases/compiler/doNotElaborateAssignabilityToTypeParameters.ts(3,3): error TS2322: Type 'T | Yadda' is not assignable to type 'T'. | ||
| 'T' could be instantiated with an arbitrary type which could be unrelated to 'T | Yadda'. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/doNotElaborateAssignabilityToTypeParameters.ts (1 errors) ==== | ||
| async function foo<T>(x: T): Promise<T> { | ||
| let yaddable = await getXOrYadda(x); | ||
| return yaddable; | ||
| ~~~~~~~~~~~~~~~~ | ||
| !!! error TS2322: Type 'T | Yadda' is not assignable to type 'T'. | ||
| !!! error TS2322: 'T' could be instantiated with an arbitrary type which could be unrelated to 'T | Yadda'. | ||
| } | ||
|
|
||
| interface Yadda { | ||
| stuff: string, | ||
| things: string, | ||
| } | ||
|
|
||
| declare function getXOrYadda<T>(x: T): T | Yadda; | ||
|
|
64 changes: 64 additions & 0 deletions
64
tests/baselines/reference/doNotElaborateAssignabilityToTypeParameters.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| //// [doNotElaborateAssignabilityToTypeParameters.ts] | ||
| async function foo<T>(x: T): Promise<T> { | ||
| let yaddable = await getXOrYadda(x); | ||
| return yaddable; | ||
| } | ||
|
|
||
| interface Yadda { | ||
| stuff: string, | ||
| things: string, | ||
| } | ||
|
|
||
| declare function getXOrYadda<T>(x: T): T | Yadda; | ||
|
|
||
|
|
||
| //// [doNotElaborateAssignabilityToTypeParameters.js] | ||
| var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) { | ||
| function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); } | ||
| return new (P || (P = Promise))(function (resolve, reject) { | ||
| function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } } | ||
| function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } } | ||
| function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); } | ||
| step((generator = generator.apply(thisArg, _arguments || [])).next()); | ||
| }); | ||
| }; | ||
| var __generator = (this && this.__generator) || function (thisArg, body) { | ||
| var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g; | ||
| return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g; | ||
| function verb(n) { return function (v) { return step([n, v]); }; } | ||
| function step(op) { | ||
| if (f) throw new TypeError("Generator is already executing."); | ||
| while (_) try { | ||
| if (f = 1, y && (t = op[0] & 2 ? y["return"] : op[0] ? y["throw"] || ((t = y["return"]) && t.call(y), 0) : y.next) && !(t = t.call(y, op[1])).done) return t; | ||
| if (y = 0, t) op = [op[0] & 2, t.value]; | ||
| switch (op[0]) { | ||
| case 0: case 1: t = op; break; | ||
| case 4: _.label++; return { value: op[1], done: false }; | ||
| case 5: _.label++; y = op[1]; op = [0]; continue; | ||
| case 7: op = _.ops.pop(); _.trys.pop(); continue; | ||
| default: | ||
| if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) { _ = 0; continue; } | ||
| if (op[0] === 3 && (!t || (op[1] > t[0] && op[1] < t[3]))) { _.label = op[1]; break; } | ||
| if (op[0] === 6 && _.label < t[1]) { _.label = t[1]; t = op; break; } | ||
| if (t && _.label < t[2]) { _.label = t[2]; _.ops.push(op); break; } | ||
| if (t[2]) _.ops.pop(); | ||
| _.trys.pop(); continue; | ||
| } | ||
| op = body.call(thisArg, _); | ||
| } catch (e) { op = [6, e]; y = 0; } finally { f = t = 0; } | ||
| if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true }; | ||
| } | ||
| }; | ||
| function foo(x) { | ||
| return __awaiter(this, void 0, void 0, function () { | ||
| var yaddable; | ||
| return __generator(this, function (_a) { | ||
| switch (_a.label) { | ||
| case 0: return [4 /*yield*/, getXOrYadda(x)]; | ||
| case 1: | ||
| yaddable = _a.sent(); | ||
| return [2 /*return*/, yaddable]; | ||
| } | ||
| }); | ||
| }); | ||
| } |
36 changes: 36 additions & 0 deletions
36
tests/baselines/reference/doNotElaborateAssignabilityToTypeParameters.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| === tests/cases/compiler/doNotElaborateAssignabilityToTypeParameters.ts === | ||
| async function foo<T>(x: T): Promise<T> { | ||
| >foo : Symbol(foo, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 0, 0)) | ||
| >T : Symbol(T, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 0, 19)) | ||
| >x : Symbol(x, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 0, 22)) | ||
| >T : Symbol(T, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 0, 19)) | ||
| >Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --)) | ||
| >T : Symbol(T, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 0, 19)) | ||
|
|
||
| let yaddable = await getXOrYadda(x); | ||
| >yaddable : Symbol(yaddable, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 1, 5)) | ||
| >getXOrYadda : Symbol(getXOrYadda, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 8, 1)) | ||
| >x : Symbol(x, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 0, 22)) | ||
|
|
||
| return yaddable; | ||
| >yaddable : Symbol(yaddable, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 1, 5)) | ||
| } | ||
|
|
||
| interface Yadda { | ||
| >Yadda : Symbol(Yadda, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 3, 1)) | ||
|
|
||
| stuff: string, | ||
| >stuff : Symbol(Yadda.stuff, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 5, 17)) | ||
|
|
||
| things: string, | ||
| >things : Symbol(Yadda.things, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 6, 16)) | ||
| } | ||
|
|
||
| declare function getXOrYadda<T>(x: T): T | Yadda; | ||
| >getXOrYadda : Symbol(getXOrYadda, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 8, 1)) | ||
| >T : Symbol(T, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 10, 29)) | ||
| >x : Symbol(x, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 10, 32)) | ||
| >T : Symbol(T, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 10, 29)) | ||
| >T : Symbol(T, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 10, 29)) | ||
| >Yadda : Symbol(Yadda, Decl(doNotElaborateAssignabilityToTypeParameters.ts, 3, 1)) | ||
|
|
28 changes: 28 additions & 0 deletions
28
tests/baselines/reference/doNotElaborateAssignabilityToTypeParameters.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| === tests/cases/compiler/doNotElaborateAssignabilityToTypeParameters.ts === | ||
| async function foo<T>(x: T): Promise<T> { | ||
| >foo : <T>(x: T) => Promise<T> | ||
| >x : T | ||
|
|
||
| let yaddable = await getXOrYadda(x); | ||
| >yaddable : T | Yadda | ||
| >await getXOrYadda(x) : T | Yadda | ||
| >getXOrYadda(x) : T | Yadda | ||
| >getXOrYadda : <T>(x: T) => T | Yadda | ||
| >x : T | ||
|
|
||
| return yaddable; | ||
| >yaddable : T | Yadda | ||
| } | ||
|
|
||
| interface Yadda { | ||
| stuff: string, | ||
| >stuff : string | ||
|
|
||
| things: string, | ||
| >things : string | ||
| } | ||
|
|
||
| declare function getXOrYadda<T>(x: T): T | Yadda; | ||
| >getXOrYadda : <T>(x: T) => T | Yadda | ||
| >x : T | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing which I'm not 100% certain about based on the original issue, is whether we want to continue elaborating if the target and source type are the same. Like in this case where both are
T. What do you think?Theoretically, we could also be even more conservative by only stopping elaboration when the target is some type parameter (e.g.
T) and the source is a union of that type parameter and something else (e.g.T | SomeOtherType).