Skip to content

Do a shallow clone for Docker tests. #42966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Conversation

DanielRosenwasser
Copy link
Member

Just saves a bit of time and work since we don't need the full history.

@typescript-bot

This comment has been minimized.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 25, 2021
@DanielRosenwasser
Copy link
Member Author

I just realized we always pull right after - but I don't know why we do that either. Do we need that step @weswigham?

@weswigham
Copy link
Member

Probably just force of habit on my part; I always pull after a clone to fetch remote refs, and that may have made its way into the scripts.

@DanielRosenwasser
Copy link
Member Author

Okay, cool! Newest change doesn't pull either.

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 26, 2021

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 6bc1140. You can monitor the build here.

@weswigham
Copy link
Member

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 26, 2021

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 6bc1140. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@DanielRosenwasser
Copy link
Member Author

Looks like it successfully sent a PR - all good?

@DanielRosenwasser DanielRosenwasser merged commit 1f6a8d7 into master Mar 4, 2021
@DanielRosenwasser DanielRosenwasser deleted the omitHistoryDockerTests branch March 4, 2021 06:35
@@ -1,8 +1,7 @@
FROM node:current
RUN npm install -g @microsoft/rush
RUN git clone https://github.com/Azure/azure-sdk-for-js.git /azure-sdk
RUN git clone --depth 1 https://github.com/Azure/azure-sdk-for-js.git /azure-sdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may combine these run into one line? Especially after big IO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants