-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Do a shallow clone for Docker tests. #42966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
I just realized we always pull right after - but I don't know why we do that either. Do we need that step @weswigham? |
Probably just force of habit on my part; I always pull after a clone to fetch remote refs, and that may have made its way into the scripts. |
Okay, cool! Newest change doesn't pull either. @typescript-bot test this |
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 6bc1140. You can monitor the build here. |
@typescript-bot user test this |
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 6bc1140. You can monitor the build here. |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Looks like it successfully sent a PR - all good? |
@@ -1,8 +1,7 @@ | |||
FROM node:current | |||
RUN npm install -g @microsoft/rush | |||
RUN git clone https://github.com/Azure/azure-sdk-for-js.git /azure-sdk | |||
RUN git clone --depth 1 https://github.com/Azure/azure-sdk-for-js.git /azure-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may combine these run into one line? Especially after big IO.
Just saves a bit of time and work since we don't need the full history.