Baseline completions and signature help #43049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Mar 2, 2021
|
One suggestion is that the baseline is appended so that you can add multiple commands baseline to same file .. I think it would be useful if you want to edit a file and see completions or quick info after the edit |
|
Or it might be good to add a baselineAll variant that takes a list of baselines to produce. Another problem I thought of is that the completions baselines are large, so asking for completions at every marker is unneeded. |
sheetalkamat
reviewed
Mar 2, 2021
| { | ||
| "marker": { | ||
| "fileName": "/tests/cases/fourslash/completionsCommentsClass.ts", | ||
| "position": 599 |
There was a problem hiding this comment.
It would be good to have marker name or line and coloumn info as well.
There was a problem hiding this comment.
Name is quite easy to add, so I did that. I don't know of an easy way to convert positions back to line/columns, though.
Also rename another duped test filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I need to update a lot of jsdoc tests since #41877 makes the jsdoc parse tree much more complete. This leads to a lot of painstaking, repetitive work updating fourslash tests.
In this PR, I add baselining to completions and signature help, to match the baselining for quick info. I also changed the filename, which should really be the containing filename.
Limitations