Skip to content

Filter transient flags to fix useDefineForClassFields #43055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

Filter transient flags to fix useDefineForClassFields #43055

merged 1 commit into from
Mar 3, 2021

Conversation

armanio123
Copy link
Contributor

Fixes #41798

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 3, 2021
@armanio123 armanio123 force-pushed the FixDefineForClassFields branch from 89eaf55 to 652199a Compare March 3, 2021 04:40
@armanio123
Copy link
Contributor Author

Seems like this PR #42975 already fixed the issue. So, I have only added the regression test.

@armanio123 armanio123 requested a review from sandersn March 3, 2021 04:42
@armanio123 armanio123 merged commit 8a81a67 into microsoft:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@armanio123 armanio123

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when using TS 4.1.2 with useDefineForClassFields and key union
3 participants
@armanio123 @RyanCavanaugh @typescript-bot