Fix37991

src/compiler/checker.ts

@@ -34665,8 +34665,8 @@ namespace ts {
                 }
             }
 
-            if (node.kind === SyntaxKind.BindingElement) {
-                if (node.parent.kind === SyntaxKind.ObjectBindingPattern && languageVersion < ScriptTarget.ESNext) {
+            if (isBindingElement(node)) {
+                if (isObjectBindingPattern(node.parent) && node.dotDotDotToken && languageVersion < ScriptTarget.ES2018) {
                     checkExternalEmitHelpers(node, ExternalEmitHelpers.Rest);
                 }
                 // check computed properties inside property names of binding elements

tests/baselines/reference/tslibInJs.errors.txt

@@ -0,0 +1,8 @@
+tests/cases/compiler/main.js(2,25): error TS2307: Cannot find module 'bar' or its corresponding type declarations.
+
+
+==== tests/cases/compiler/main.js (1 errors) ====
+    "use strict";
+    const { foo } = require("bar");
+                            ~~~~~
+!!! error TS2307: Cannot find module 'bar' or its corresponding type declarations.

tests/baselines/reference/tslibInJs.symbols

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/main.js ===
+"use strict";
+const { foo } = require("bar");
+>foo : Symbol(foo, Decl(main.js, 1, 7))
+>require : Symbol(require)
+

tests/baselines/reference/tslibInJs.types

@@ -0,0 +1,10 @@
+=== tests/cases/compiler/main.js ===
+"use strict";
+>"use strict" : "use strict"
+
+const { foo } = require("bar");
+>foo : any
+>require("bar") : any
+>require : any
+>"bar" : "bar"
+

tests/cases/compiler/tslibInJs.ts

@@ -0,0 +1,13 @@
+// @checkJs: true
+// @allowJs: true
+// @moduleResolution: node
+// @target: es2018
+// @module: commonjs
+// @importHelpers: true
+// @lib: es2018
+// @outDir: out
+// @noEmit: true
+
+// @fileName: main.js
+"use strict";
+const { foo } = require("bar");