-
Notifications
You must be signed in to change notification settings - Fork 12.8k
ignore static and declared member if checking override #43569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think I would expect that under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in the design meeting and decided that yes, static overrides need the override
keyword in --noImplicitOverride
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kingwl!
Fixes #43563
Fixes #43566
Declared property does not really override. So just ignore that.