Skip to content

Manually walk to make normalizeSlashes a no-op #44101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Manually walk to make normalizeSlashes a no-op #44101

wants to merge 2 commits into from

Conversation

DanielRosenwasser
Copy link
Member

Experimental alternative to #44100.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 15, 2021
@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 15, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at e0d407b. You can monitor the build here.

@DanielRosenwasser
Copy link
Member Author

I could probably rewrite this in terms of indexOf like described by @rbuckton, I didn't see that comment. It might be faster.

@rbuckton
Copy link
Contributor

The suggestion I made in #44100 avoids an array allocation.

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented May 15, 2021 •
edited
Loading

The suggestion I made in #44100 avoids an array allocation.

Isn't #44100 (comment) potentially creating several intermediate "result" strings on every iteration of the loop? Seems like it could go either way.

@DanielRosenwasser
Copy link
Member Author

I guess I could technically just use one array.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 15, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at e0d407b. You can monitor the build here.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 17, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at e0d407b. You can monitor the build here.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 17, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at e0d407b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44101

Metric master 44101 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 345,047k (± 0.01%) 345,154k (± 0.03%) +106k (+ 0.03%) 345,001k 345,412k
Parse Time 1.90s (± 0.72%) 2.12s (± 0.63%) +0.22s (+11.29%) 2.10s 2.16s
Bind Time 0.84s (± 0.80%) 0.84s (± 0.77%) +0.01s (+ 0.60%) 0.83s 0.86s
Check Time 5.25s (± 0.68%) 5.34s (± 0.56%) +0.09s (+ 1.66%) 5.28s 5.43s
Emit Time 5.57s (± 0.59%) 5.67s (± 0.56%) +0.10s (+ 1.72%) 5.61s 5.73s
Total Time 13.57s (± 0.41%) 13.97s (± 0.32%) +0.40s (+ 2.96%) 13.89s 14.06s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,388k (± 0.03%) 200,379k (± 0.03%) -9k (- 0.00%) 200,279k 200,548k
Parse Time 0.78s (± 0.46%) 0.79s (± 0.74%) +0.00s (+ 0.38%) 0.78s 0.80s
Bind Time 0.53s (± 1.29%) 0.53s (± 1.05%) +0.00s (+ 0.38%) 0.51s 0.54s
Check Time 7.53s (± 0.48%) 7.54s (± 0.68%) +0.01s (+ 0.13%) 7.44s 7.64s
Emit Time 2.45s (± 0.93%) 2.46s (± 1.12%) +0.00s (+ 0.04%) 2.40s 2.52s
Total Time 11.29s (± 0.38%) 11.31s (± 0.56%) +0.02s (+ 0.20%) 11.15s 11.44s
Monaco - node (v10.16.3, x64)
Memory used 341,667k (± 0.02%) 341,646k (± 0.01%) -21k (- 0.01%) 341,575k 341,746k
Parse Time 1.55s (± 0.60%) 1.71s (± 0.70%) +0.15s (+ 9.99%) 1.68s 1.73s
Bind Time 0.74s (± 0.75%) 0.74s (± 0.50%) +0.00s (+ 0.40%) 0.74s 0.75s
Check Time 5.39s (± 0.70%) 5.44s (± 0.43%) +0.05s (+ 0.95%) 5.41s 5.51s
Emit Time 2.97s (± 0.70%) 2.99s (± 0.86%) +0.02s (+ 0.74%) 2.93s 3.05s
Total Time 10.65s (± 0.53%) 10.88s (± 0.39%) +0.23s (+ 2.15%) 10.80s 11.00s
TFS - node (v10.16.3, x64)
Memory used 304,248k (± 0.02%) 304,221k (± 0.02%) -28k (- 0.01%) 304,096k 304,434k
Parse Time 1.21s (± 0.46%) 1.27s (± 0.70%) +0.06s (+ 4.80%) 1.25s 1.29s
Bind Time 0.71s (± 0.67%) 0.71s (± 0.66%) +0.00s (+ 0.42%) 0.70s 0.72s
Check Time 4.84s (± 0.47%) 4.91s (± 0.58%) +0.07s (+ 1.51%) 4.83s 4.97s
Emit Time 3.14s (± 1.19%) 3.14s (± 1.14%) -0.00s (- 0.10%) 3.09s 3.24s
Total Time 9.90s (± 0.45%) 10.03s (± 0.44%) +0.13s (+ 1.36%) 9.93s 10.14s
material-ui - node (v10.16.3, x64)
Memory used 474,028k (± 0.01%) 473,970k (± 0.01%) -59k (- 0.01%) 473,867k 474,071k
Parse Time 1.94s (± 0.89%) 2.36s (± 0.42%) +0.42s (+21.37%) 2.34s 2.38s
Bind Time 0.66s (± 0.76%) 0.66s (± 0.72%) +0.00s (+ 0.31%) 0.64s 0.66s
Check Time 14.24s (± 0.35%) 14.37s (± 0.64%) +0.13s (+ 0.90%) 14.11s 14.52s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.84s (± 0.32%) 17.38s (± 0.57%) +0.54s (+ 3.24%) 17.11s 17.56s
Angular - node (v12.1.0, x64)
Memory used 322,607k (± 0.02%) 322,703k (± 0.02%) +96k (+ 0.03%) 322,584k 322,796k
Parse Time 1.90s (± 0.63%) 1.95s (± 0.69%) +0.05s (+ 2.52%) 1.92s 1.98s
Bind Time 0.82s (± 0.71%) 0.82s (± 0.70%) +0.00s (+ 0.37%) 0.81s 0.83s
Check Time 5.15s (± 0.32%) 5.16s (± 0.24%) +0.01s (+ 0.16%) 5.14s 5.20s
Emit Time 5.78s (± 0.80%) 5.77s (± 0.63%) -0.02s (- 0.26%) 5.70s 5.85s
Total Time 13.66s (± 0.48%) 13.71s (± 0.38%) +0.05s (+ 0.34%) 13.62s 13.86s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,549k (± 0.16%) 187,701k (± 0.11%) +153k (+ 0.08%) 187,232k 188,033k
Parse Time 0.77s (± 0.78%) 0.78s (± 0.77%) +0.01s (+ 1.17%) 0.76s 0.79s
Bind Time 0.53s (± 1.32%) 0.53s (± 1.04%) +0.00s (+ 0.19%) 0.52s 0.54s
Check Time 7.04s (± 0.64%) 7.06s (± 0.58%) +0.02s (+ 0.33%) 6.95s 7.13s
Emit Time 2.43s (± 1.68%) 2.42s (± 1.09%) -0.01s (- 0.41%) 2.38s 2.49s
Total Time 10.77s (± 0.65%) 10.79s (± 0.56%) +0.02s (+ 0.22%) 10.63s 10.91s
Monaco - node (v12.1.0, x64)
Memory used 323,988k (± 0.05%) 324,155k (± 0.02%) +167k (+ 0.05%) 324,029k 324,344k
Parse Time 1.54s (± 0.66%) 1.57s (± 0.68%) +0.03s (+ 1.95%) 1.55s 1.59s
Bind Time 0.72s (± 0.83%) 0.72s (± 0.95%) 0.00s ( 0.00%) 0.71s 0.74s
Check Time 5.21s (± 0.36%) 5.24s (± 0.56%) +0.03s (+ 0.54%) 5.17s 5.31s
Emit Time 3.04s (± 1.05%) 3.02s (± 0.52%) -0.01s (- 0.40%) 2.99s 3.06s
Total Time 10.50s (± 0.38%) 10.55s (± 0.31%) +0.05s (+ 0.46%) 10.48s 10.63s
TFS - node (v12.1.0, x64)
Memory used 288,704k (± 0.02%) 288,717k (± 0.02%) +13k (+ 0.00%) 288,599k 288,858k
Parse Time 1.21s (± 0.62%) 1.23s (± 0.50%) +0.02s (+ 1.82%) 1.21s 1.24s
Bind Time 0.70s (± 0.99%) 0.69s (± 0.64%) -0.00s (- 0.43%) 0.68s 0.70s
Check Time 4.76s (± 0.29%) 4.77s (± 0.37%) +0.02s (+ 0.42%) 4.75s 4.83s
Emit Time 3.13s (± 0.77%) 3.12s (± 0.84%) -0.01s (- 0.19%) 3.06s 3.17s
Total Time 9.78s (± 0.32%) 9.82s (± 0.39%) +0.04s (+ 0.37%) 9.72s 9.90s
material-ui - node (v12.1.0, x64)
Memory used 451,959k (± 0.01%) 451,865k (± 0.06%) -94k (- 0.02%) 450,801k 452,141k
Parse Time 1.95s (± 0.56%) 2.03s (± 0.48%) +0.08s (+ 4.05%) 2.00s 2.05s
Bind Time 0.64s (± 0.87%) 0.64s (± 0.53%) +0.01s (+ 0.78%) 0.64s 0.65s
Check Time 12.81s (± 0.48%) 12.84s (± 0.75%) +0.04s (+ 0.28%) 12.67s 13.03s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.40s (± 0.40%) 15.52s (± 0.63%) +0.12s (+ 0.77%) 15.35s 15.71s
Angular - node (v14.15.1, x64)
Memory used 321,295k (± 0.00%) 321,399k (± 0.01%) +104k (+ 0.03%) 321,356k 321,433k
Parse Time 1.91s (± 0.70%) 1.94s (± 0.71%) +0.03s (+ 1.57%) 1.90s 1.96s
Bind Time 0.87s (± 0.34%) 0.87s (± 0.66%) +0.00s (+ 0.23%) 0.86s 0.88s
Check Time 5.17s (± 0.41%) 5.18s (± 0.39%) +0.01s (+ 0.25%) 5.14s 5.22s
Emit Time 5.81s (± 0.36%) 5.85s (± 0.75%) +0.04s (+ 0.62%) 5.75s 5.91s
Total Time 13.76s (± 0.32%) 13.85s (± 0.45%) +0.08s (+ 0.61%) 13.72s 13.95s
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,755k (± 0.58%) 187,814k (± 0.62%) -941k (- 0.50%) 186,486k 189,802k
Parse Time 0.80s (± 0.50%) 0.80s (± 0.61%) +0.01s (+ 0.63%) 0.80s 0.82s
Bind Time 0.55s (± 0.62%) 0.56s (± 0.90%) +0.00s (+ 0.36%) 0.55s 0.57s
Check Time 7.14s (± 0.47%) 7.12s (± 0.44%) -0.02s (- 0.28%) 7.07s 7.23s
Emit Time 2.44s (± 0.91%) 2.43s (± 0.92%) -0.01s (- 0.33%) 2.39s 2.48s
Total Time 10.93s (± 0.38%) 10.91s (± 0.28%) -0.02s (- 0.19%) 10.84s 10.98s
Monaco - node (v14.15.1, x64)
Memory used 323,157k (± 0.00%) 323,157k (± 0.01%) -1k (- 0.00%) 323,115k 323,263k
Parse Time 1.56s (± 0.69%) 1.59s (± 0.78%) +0.03s (+ 1.86%) 1.57s 1.63s
Bind Time 0.74s (± 0.66%) 0.74s (± 0.50%) +0.00s (+ 0.13%) 0.74s 0.75s
Check Time 5.20s (± 0.32%) 5.21s (± 0.59%) +0.00s (+ 0.06%) 5.16s 5.29s
Emit Time 3.07s (± 0.71%) 3.09s (± 0.80%) +0.02s (+ 0.72%) 3.04s 3.16s
Total Time 10.58s (± 0.35%) 10.63s (± 0.36%) +0.06s (+ 0.53%) 10.56s 10.71s
TFS - node (v14.15.1, x64)
Memory used 287,671k (± 0.01%) 287,688k (± 0.01%) +17k (+ 0.01%) 287,658k 287,742k
Parse Time 1.28s (± 2.18%) 1.28s (± 0.64%) -0.01s (- 0.62%) 1.26s 1.30s
Bind Time 0.72s (± 1.51%) 0.71s (± 0.84%) -0.01s (- 0.97%) 0.71s 0.73s
Check Time 4.84s (± 1.16%) 4.80s (± 0.39%) -0.04s (- 0.72%) 4.76s 4.85s
Emit Time 3.23s (± 0.96%) 3.21s (± 0.88%) -0.01s (- 0.34%) 3.16s 3.28s
Total Time 10.07s (± 1.12%) 10.02s (± 0.40%) -0.06s (- 0.57%) 9.93s 10.09s
material-ui - node (v14.15.1, x64)
Memory used 450,147k (± 0.01%) 450,128k (± 0.01%) -20k (- 0.00%) 450,072k 450,227k
Parse Time 1.99s (± 0.65%) 2.05s (± 0.54%) +0.06s (+ 3.17%) 2.03s 2.08s
Bind Time 0.70s (± 1.14%) 0.70s (± 0.93%) -0.00s (- 0.57%) 0.69s 0.71s
Check Time 12.95s (± 0.58%) 13.01s (± 0.79%) +0.06s (+ 0.42%) 12.86s 13.29s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.64s (± 0.53%) 15.75s (± 0.67%) +0.11s (+ 0.72%) 15.60s 16.03s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44101 10
Baseline master 10

Developer Information:

Download Benchmark

@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 17, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at f040500. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44101

Metric master 44101 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 345,047k (± 0.01%) 345,212k (± 0.01%) +164k (+ 0.05%) 345,127k 345,377k
Parse Time 1.90s (± 0.72%) 2.13s (± 0.58%) +0.23s (+11.92%) 2.10s 2.16s
Bind Time 0.84s (± 0.80%) 0.84s (± 0.74%) +0.00s (+ 0.24%) 0.83s 0.85s
Check Time 5.25s (± 0.68%) 5.36s (± 0.52%) +0.11s (+ 2.13%) 5.30s 5.43s
Emit Time 5.57s (± 0.59%) 5.70s (± 0.66%) +0.13s (+ 2.26%) 5.65s 5.81s
Total Time 13.57s (± 0.41%) 14.03s (± 0.45%) +0.46s (+ 3.42%) 13.91s 14.19s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,388k (± 0.03%) 200,322k (± 0.06%) -66k (- 0.03%) 199,928k 200,594k
Parse Time 0.78s (± 0.46%) 0.79s (± 0.63%) +0.00s (+ 0.26%) 0.78s 0.80s
Bind Time 0.53s (± 1.29%) 0.53s (± 0.84%) +0.01s (+ 1.14%) 0.52s 0.54s
Check Time 7.53s (± 0.48%) 7.57s (± 0.65%) +0.04s (+ 0.58%) 7.50s 7.72s
Emit Time 2.45s (± 0.93%) 2.43s (± 1.00%) -0.02s (- 0.90%) 2.40s 2.50s
Total Time 11.29s (± 0.38%) 11.32s (± 0.55%) +0.03s (+ 0.31%) 11.23s 11.46s
Monaco - node (v10.16.3, x64)
Memory used 341,667k (± 0.02%) 341,727k (± 0.02%) +61k (+ 0.02%) 341,582k 341,915k
Parse Time 1.55s (± 0.60%) 1.71s (± 0.64%) +0.16s (+10.37%) 1.68s 1.74s
Bind Time 0.74s (± 0.75%) 0.75s (± 0.92%) +0.00s (+ 0.40%) 0.73s 0.76s
Check Time 5.39s (± 0.70%) 5.44s (± 0.41%) +0.05s (+ 0.89%) 5.38s 5.49s
Emit Time 2.97s (± 0.70%) 2.98s (± 0.78%) +0.01s (+ 0.44%) 2.93s 3.04s
Total Time 10.65s (± 0.53%) 10.87s (± 0.33%) +0.22s (+ 2.08%) 10.79s 10.96s
TFS - node (v10.16.3, x64)
Memory used 304,248k (± 0.02%) 304,310k (± 0.03%) +62k (+ 0.02%) 304,202k 304,577k
Parse Time 1.21s (± 0.46%) 1.26s (± 0.44%) +0.05s (+ 4.47%) 1.25s 1.27s
Bind Time 0.71s (± 0.67%) 0.70s (± 0.95%) -0.00s (- 0.57%) 0.69s 0.72s
Check Time 4.84s (± 0.47%) 4.88s (± 0.17%) +0.03s (+ 0.70%) 4.86s 4.90s
Emit Time 3.14s (± 1.19%) 3.14s (± 1.20%) -0.00s (- 0.03%) 3.06s 3.21s
Total Time 9.90s (± 0.45%) 9.98s (± 0.37%) +0.08s (+ 0.86%) 9.90s 10.05s
material-ui - node (v10.16.3, x64)
Memory used 474,028k (± 0.01%) 473,971k (± 0.01%) -57k (- 0.01%) 473,846k 474,101k
Parse Time 1.94s (± 0.89%) 2.37s (± 0.47%) +0.43s (+22.19%) 2.35s 2.39s
Bind Time 0.66s (± 0.76%) 0.65s (± 0.62%) -0.01s (- 0.92%) 0.64s 0.66s
Check Time 14.24s (± 0.35%) 14.23s (± 0.30%) -0.01s (- 0.08%) 14.18s 14.35s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.84s (± 0.32%) 17.25s (± 0.25%) +0.42s (+ 2.47%) 17.19s 17.36s
Angular - node (v12.1.0, x64)
Memory used 322,607k (± 0.02%) 322,677k (± 0.03%) +70k (+ 0.02%) 322,490k 322,858k
Parse Time 1.90s (± 0.63%) 1.97s (± 0.52%) +0.07s (+ 3.57%) 1.95s 1.99s
Bind Time 0.82s (± 0.71%) 0.82s (± 0.63%) +0.00s (+ 0.24%) 0.81s 0.83s
Check Time 5.15s (± 0.32%) 5.17s (± 0.34%) +0.01s (+ 0.25%) 5.13s 5.21s
Emit Time 5.78s (± 0.80%) 5.80s (± 0.51%) +0.02s (+ 0.31%) 5.72s 5.85s
Total Time 13.66s (± 0.48%) 13.76s (± 0.28%) +0.10s (+ 0.75%) 13.65s 13.81s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,549k (± 0.16%) 187,411k (± 0.17%) -138k (- 0.07%) 186,734k 188,001k
Parse Time 0.77s (± 0.78%) 0.78s (± 0.77%) +0.01s (+ 1.31%) 0.76s 0.79s
Bind Time 0.53s (± 1.32%) 0.53s (± 1.54%) -0.00s (- 0.19%) 0.52s 0.56s
Check Time 7.04s (± 0.64%) 7.03s (± 0.70%) -0.01s (- 0.10%) 6.94s 7.15s
Emit Time 2.43s (± 1.68%) 2.43s (± 1.07%) -0.00s (- 0.12%) 2.37s 2.47s
Total Time 10.77s (± 0.65%) 10.77s (± 0.64%) -0.00s (- 0.02%) 10.62s 10.94s
Monaco - node (v12.1.0, x64)
Memory used 323,988k (± 0.05%) 323,977k (± 0.05%) -11k (- 0.00%) 323,347k 324,182k
Parse Time 1.54s (± 0.66%) 1.58s (± 0.60%) +0.04s (+ 2.67%) 1.56s 1.61s
Bind Time 0.72s (± 0.83%) 0.72s (± 1.22%) +0.00s (+ 0.56%) 0.71s 0.75s
Check Time 5.21s (± 0.36%) 5.21s (± 0.47%) -0.00s (- 0.02%) 5.15s 5.28s
Emit Time 3.04s (± 1.05%) 3.03s (± 0.73%) -0.00s (- 0.10%) 2.99s 3.10s
Total Time 10.50s (± 0.38%) 10.54s (± 0.35%) +0.04s (+ 0.39%) 10.46s 10.62s
TFS - node (v12.1.0, x64)
Memory used 288,704k (± 0.02%) 288,726k (± 0.01%) +22k (+ 0.01%) 288,640k 288,804k
Parse Time 1.21s (± 0.62%) 1.23s (± 0.54%) +0.02s (+ 1.91%) 1.22s 1.25s
Bind Time 0.70s (± 0.99%) 0.69s (± 0.96%) -0.01s (- 0.72%) 0.68s 0.71s
Check Time 4.76s (± 0.29%) 4.77s (± 0.49%) +0.02s (+ 0.34%) 4.72s 4.83s
Emit Time 3.13s (± 0.77%) 3.11s (± 0.87%) -0.02s (- 0.51%) 3.04s 3.17s
Total Time 9.78s (± 0.32%) 9.80s (± 0.48%) +0.02s (+ 0.18%) 9.67s 9.91s
material-ui - node (v12.1.0, x64)
Memory used 451,959k (± 0.01%) 451,644k (± 0.07%) -315k (- 0.07%) 450,733k 452,011k
Parse Time 1.95s (± 0.56%) 2.05s (± 0.28%) +0.10s (+ 5.13%) 2.04s 2.06s
Bind Time 0.64s (± 0.87%) 0.64s (± 0.93%) -0.00s (- 0.31%) 0.63s 0.65s
Check Time 12.81s (± 0.48%) 12.84s (± 0.57%) +0.03s (+ 0.25%) 12.72s 12.97s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.40s (± 0.40%) 15.52s (± 0.48%) +0.13s (+ 0.82%) 15.41s 15.66s
Angular - node (v14.15.1, x64)
Memory used 321,295k (± 0.00%) 321,411k (± 0.00%) +116k (+ 0.04%) 321,380k 321,451k
Parse Time 1.91s (± 0.70%) 1.96s (± 0.62%) +0.04s (+ 2.35%) 1.94s 1.98s
Bind Time 0.87s (± 0.34%) 0.87s (± 0.51%) 0.00s ( 0.00%) 0.86s 0.88s
Check Time 5.17s (± 0.41%) 5.18s (± 0.43%) +0.01s (+ 0.15%) 5.13s 5.22s
Emit Time 5.81s (± 0.36%) 5.83s (± 0.31%) +0.02s (+ 0.38%) 5.80s 5.87s
Total Time 13.76s (± 0.32%) 13.84s (± 0.20%) +0.07s (+ 0.55%) 13.79s 13.88s
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,755k (± 0.58%) 189,072k (± 0.51%) +317k (+ 0.17%) 186,498k 189,765k
Parse Time 0.80s (± 0.50%) 0.80s (± 0.42%) +0.00s (+ 0.13%) 0.79s 0.81s
Bind Time 0.55s (± 0.62%) 0.56s (± 0.65%) +0.00s (+ 0.54%) 0.55s 0.56s
Check Time 7.14s (± 0.47%) 7.14s (± 0.62%) -0.00s (- 0.04%) 7.06s 7.24s
Emit Time 2.44s (± 0.91%) 2.43s (± 0.57%) -0.01s (- 0.53%) 2.40s 2.45s
Total Time 10.93s (± 0.38%) 10.92s (± 0.45%) -0.01s (- 0.10%) 10.82s 11.03s
Monaco - node (v14.15.1, x64)
Memory used 323,157k (± 0.00%) 323,144k (± 0.01%) -14k (- 0.00%) 323,100k 323,177k
Parse Time 1.56s (± 0.69%) 1.60s (± 1.04%) +0.04s (+ 2.75%) 1.58s 1.66s
Bind Time 0.74s (± 0.66%) 0.75s (± 1.21%) +0.01s (+ 0.67%) 0.73s 0.78s
Check Time 5.20s (± 0.32%) 5.21s (± 0.48%) +0.00s (+ 0.08%) 5.15s 5.27s
Emit Time 3.07s (± 0.71%) 3.07s (± 0.62%) -0.00s (- 0.10%) 3.02s 3.12s
Total Time 10.58s (± 0.35%) 10.63s (± 0.44%) +0.05s (+ 0.46%) 10.54s 10.74s
TFS - node (v14.15.1, x64)
Memory used 287,671k (± 0.01%) 287,679k (± 0.01%) +8k (+ 0.00%) 287,630k 287,708k
Parse Time 1.28s (± 2.18%) 1.28s (± 1.17%) -0.00s (- 0.31%) 1.25s 1.31s
Bind Time 0.72s (± 1.51%) 0.72s (± 0.93%) -0.01s (- 0.69%) 0.71s 0.74s
Check Time 4.84s (± 1.16%) 4.80s (± 0.33%) -0.04s (- 0.74%) 4.77s 4.84s
Emit Time 3.23s (± 0.96%) 3.22s (± 0.83%) -0.01s (- 0.31%) 3.16s 3.25s
Total Time 10.07s (± 1.12%) 10.02s (± 0.45%) -0.06s (- 0.58%) 9.92s 10.09s
material-ui - node (v14.15.1, x64)
Memory used 450,147k (± 0.01%) 450,168k (± 0.01%) +21k (+ 0.00%) 450,066k 450,290k
Parse Time 1.99s (± 0.65%) 2.08s (± 0.55%) +0.09s (+ 4.78%) 2.06s 2.10s
Bind Time 0.70s (± 1.14%) 0.70s (± 0.53%) -0.01s (- 1.00%) 0.69s 0.70s
Check Time 12.95s (± 0.58%) 12.94s (± 0.68%) -0.01s (- 0.08%) 12.79s 13.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.64s (± 0.53%) 15.72s (± 0.55%) +0.08s (+ 0.50%) 15.57s 15.90s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44101 10
Baseline master 10

Developer Information:

Download Benchmark

@amcasey amcasey mentioned this pull request May 18, 2021
Merged
@amcasey
Copy link
Member

amcasey commented May 18, 2021

Single run of large project load in node12 on linux:

indexOf

Type: wall
Time: May 18, 2021 at 1:29pm (PDT)
Duration: 38.46s, Total samples = 35755ms (92.98%)
Active filters:
   show=norm
Showing nodes accounting for 31856ms, 89.10% of 35755ms total
Dropped 5 nodes (cum <= 178.78ms)
      flat  flat%   sum%        cum   cum%
   26995ms 75.50% 75.50%    31881ms 89.17%  Interface._normalWrite readline.js:434
    4372ms 12.23% 87.73%     4556ms 12.74%  normalizePath /home/acasey/repos/ts_gh/built/local/tsserver.js:6028
     489ms  1.37% 89.10%      489ms  1.37%  normalizeSlashes /home/acasey/repos/ts_gh/built/local/tsserver.js:5917

This PR

Type: wall
Time: May 18, 2021 at 2:03pm (PDT)
Duration: 48.08s, Total samples = 44.53s (92.60%)
Active filters:
   show=norm
Showing nodes accounting for 40.63s, 91.26% of 44.53s total
Dropped 3 nodes (cum <= 0.22s)
      flat  flat%   sum%        cum   cum%
    30.98s 69.58% 69.58%     40.66s 91.32%  Interface._normalWrite readline.js:434
     5.55s 12.47% 82.05%      7.35s 16.50%  normalizePath /home/acasey/repos/ts_gh/built/local/tsserver.js:6021
     4.10s  9.21% 91.26%      4.10s  9.21%  normalizeSlashes /home/acasey/repos/ts_gh/built/local/tsserver.js:5899

The baseline includes other local changes, but was the same for both.

@DanielRosenwasser DanielRosenwasser deleted the alternativeNormalize branch June 30, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

@amcasey amcasey Awaiting requested review from amcasey

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielRosenwasser @typescript-bot @rbuckton @amcasey