Skip to content

fix: add corresponding message for override error in js files #45656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

stkevintan
Copy link
Contributor

Fixes #45591

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 31, 2021
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just like the word 'leading' removed.

@sandersn
Copy link
Member

@stkevintan Looks like there are 3 lint errors still. Once you fix those I will merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

noImplicitOverride reports in JS files with checkJs enabled, can only ts-ignore the line
3 participants