Skip to content

Improve logic for choosing between co- and contra-variant inferences #46392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #45603.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 15, 2021
@weswigham
Copy link
Member

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 18, 2021

Heya @weswigham, I've started to run the extended test suite on this PR at 939b5b4. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 18, 2021

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 939b5b4. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 18, 2021

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 939b5b4. You can monitor the build here.

@ahejlsberg ahejlsberg merged commit 56b6279 into main Oct 19, 2021
@ahejlsberg ahejlsberg deleted the fix45603 branch October 19, 2021 16:58
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
…icrosoft#46392)

* Improve logic for choosing between co- and contra-variant inferences

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declaration order dependence when inferring to a union
4 participants