Skip to content

Still check for deep nesting when bypassing relation caching #46505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Still check for deep nesting when bypassing relation caching #46505

wants to merge 3 commits into from

Conversation

ahejlsberg
Copy link
Member

Fixes #46500.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 24, 2021
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 24, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 4f5361a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 24, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the inline community code test suite on this PR at 4f5361a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 24, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 4f5361a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 24, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 4f5361a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 24, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at 4f5361a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
Great news! no new errors were found between main..refs/pull/46505/merge

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46505

Metric main 46505 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 354,057k (± 0.02%) 354,066k (± 0.02%) +9k (+ 0.00%) 353,888k 354,294k
Parse Time 1.95s (± 0.60%) 1.95s (± 0.59%) -0.00s (- 0.21%) 1.92s 1.97s
Bind Time 0.85s (± 0.70%) 0.84s (± 0.66%) -0.00s (- 0.47%) 0.83s 0.85s
Check Time 5.49s (± 0.38%) 5.46s (± 0.33%) -0.03s (- 0.60%) 5.42s 5.50s
Emit Time 5.88s (± 0.66%) 5.84s (± 0.84%) -0.03s (- 0.51%) 5.75s 6.01s
Total Time 14.16s (± 0.34%) 14.09s (± 0.43%) -0.07s (- 0.50%) 13.95s 14.27s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,623k (± 0.27%) 203,859k (± 0.03%) +236k (+ 0.12%) 203,718k 203,973k
Parse Time 0.79s (± 0.82%) 0.79s (± 1.03%) +0.00s (+ 0.25%) 0.77s 0.81s
Bind Time 0.52s (± 0.94%) 0.52s (± 1.07%) -0.01s (- 1.15%) 0.51s 0.53s
Check Time 7.92s (± 0.98%) 7.96s (± 0.56%) +0.04s (+ 0.52%) 7.88s 8.07s
Emit Time 2.43s (± 0.74%) 2.44s (± 0.96%) +0.01s (+ 0.33%) 2.41s 2.50s
Total Time 11.66s (± 0.77%) 11.71s (± 0.43%) +0.04s (+ 0.39%) 11.61s 11.80s
Monaco - node (v10.16.3, x64)
Memory used 342,041k (± 0.02%) 342,091k (± 0.02%) +49k (+ 0.01%) 341,853k 342,255k
Parse Time 1.48s (± 0.71%) 1.48s (± 0.59%) -0.00s (- 0.34%) 1.46s 1.49s
Bind Time 0.74s (± 0.50%) 0.75s (± 1.18%) +0.00s (+ 0.27%) 0.74s 0.78s
Check Time 5.46s (± 0.71%) 5.46s (± 0.60%) 0.00s ( 0.00%) 5.38s 5.53s
Emit Time 3.18s (± 0.67%) 3.17s (± 0.79%) -0.01s (- 0.31%) 3.11s 3.22s
Total Time 10.86s (± 0.31%) 10.85s (± 0.25%) -0.01s (- 0.11%) 10.79s 10.91s
TFS - node (v10.16.3, x64)
Memory used 304,762k (± 0.02%) 304,745k (± 0.02%) -17k (- 0.01%) 304,658k 304,846k
Parse Time 1.20s (± 0.46%) 1.20s (± 0.58%) +0.00s (+ 0.08%) 1.18s 1.21s
Bind Time 0.71s (± 0.67%) 0.71s (± 0.95%) -0.01s (- 0.84%) 0.69s 0.72s
Check Time 5.01s (± 0.72%) 4.97s (± 0.56%) -0.04s (- 0.82%) 4.88s 5.02s
Emit Time 3.31s (± 1.21%) 3.31s (± 1.31%) -0.01s (- 0.24%) 3.22s 3.44s
Total Time 10.23s (± 0.37%) 10.18s (± 0.55%) -0.05s (- 0.51%) 10.05s 10.34s
material-ui - node (v10.16.3, x64)
Memory used 470,429k (± 0.01%) 470,290k (± 0.01%) -139k (- 0.03%) 470,209k 470,393k
Parse Time 1.78s (± 0.37%) 1.77s (± 0.27%) -0.01s (- 0.73%) 1.76s 1.78s
Bind Time 0.66s (± 0.79%) 0.65s (± 1.04%) -0.00s (- 0.76%) 0.64s 0.67s
Check Time 14.35s (± 0.41%) 15.28s (± 0.28%) +0.92s (+ 6.43%) 15.17s 15.37s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.79s (± 0.39%) 17.70s (± 0.24%) +0.91s (+ 5.41%) 17.60s 17.79s
xstate - node (v10.16.3, x64)
Memory used 573,638k (± 1.43%) 570,042k (± 0.02%) -3,596k (- 0.63%) 569,874k 570,269k
Parse Time 2.55s (± 0.32%) 2.55s (± 0.30%) -0.00s (- 0.04%) 2.53s 2.57s
Bind Time 1.01s (± 0.57%) 1.01s (± 0.29%) -0.00s (- 0.20%) 1.00s 1.01s
Check Time 1.56s (± 0.73%) 1.57s (± 0.48%) +0.01s (+ 0.51%) 1.54s 1.58s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.19s (± 0.27%) 5.18s (± 0.25%) -0.00s (- 0.08%) 5.16s 5.21s
Angular - node (v12.1.0, x64)
Memory used 331,914k (± 0.02%) 331,957k (± 0.03%) +43k (+ 0.01%) 331,801k 332,200k
Parse Time 1.94s (± 0.91%) 1.94s (± 0.68%) -0.01s (- 0.26%) 1.91s 1.96s
Bind Time 0.82s (± 0.86%) 0.81s (± 0.73%) -0.01s (- 0.61%) 0.80s 0.83s
Check Time 5.31s (± 0.71%) 5.31s (± 0.44%) 0.00s ( 0.00%) 5.26s 5.38s
Emit Time 6.09s (± 0.51%) 6.09s (± 0.97%) -0.00s (- 0.03%) 6.00s 6.30s
Total Time 14.17s (± 0.47%) 14.15s (± 0.53%) -0.02s (- 0.13%) 14.04s 14.41s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,387k (± 0.07%) 191,433k (± 0.02%) +46k (+ 0.02%) 191,330k 191,505k
Parse Time 0.79s (± 0.76%) 0.78s (± 0.67%) -0.01s (- 0.89%) 0.77s 0.79s
Bind Time 0.53s (± 1.09%) 0.52s (± 0.69%) -0.01s (- 1.13%) 0.52s 0.53s
Check Time 7.43s (± 0.17%) 7.38s (± 0.62%) -0.05s (- 0.70%) 7.28s 7.47s
Emit Time 2.45s (± 1.35%) 2.45s (± 0.71%) -0.01s (- 0.37%) 2.40s 2.48s
Total Time 11.20s (± 0.31%) 11.13s (± 0.45%) -0.07s (- 0.67%) 11.01s 11.25s
Monaco - node (v12.1.0, x64)
Memory used 325,162k (± 0.02%) 325,219k (± 0.01%) +56k (+ 0.02%) 325,118k 325,342k
Parse Time 1.46s (± 0.91%) 1.46s (± 0.73%) -0.00s (- 0.14%) 1.43s 1.48s
Bind Time 0.72s (± 0.80%) 0.72s (± 0.50%) +0.00s (+ 0.14%) 0.72s 0.73s
Check Time 5.35s (± 0.69%) 5.34s (± 0.51%) -0.01s (- 0.26%) 5.29s 5.40s
Emit Time 3.21s (± 0.92%) 3.21s (± 1.00%) +0.00s (+ 0.00%) 3.15s 3.27s
Total Time 10.75s (± 0.61%) 10.73s (± 0.49%) -0.02s (- 0.17%) 10.64s 10.87s
TFS - node (v12.1.0, x64)
Memory used 289,463k (± 0.02%) 289,487k (± 0.02%) +25k (+ 0.01%) 289,414k 289,638k
Parse Time 1.22s (± 0.43%) 1.21s (± 0.73%) -0.00s (- 0.41%) 1.20s 1.23s
Bind Time 0.69s (± 0.32%) 0.69s (± 0.96%) +0.00s (+ 0.58%) 0.68s 0.71s
Check Time 4.91s (± 0.63%) 4.88s (± 0.74%) -0.03s (- 0.67%) 4.83s 4.99s
Emit Time 3.39s (± 0.48%) 3.37s (± 1.11%) -0.02s (- 0.53%) 3.29s 3.46s
Total Time 10.21s (± 0.35%) 10.15s (± 0.62%) -0.05s (- 0.51%) 10.01s 10.26s
material-ui - node (v12.1.0, x64)
Memory used 448,936k (± 0.08%) 448,992k (± 0.06%) +56k (+ 0.01%) 447,999k 449,224k
Parse Time 1.78s (± 0.51%) 1.78s (± 0.87%) -0.00s (- 0.17%) 1.75s 1.81s
Bind Time 0.64s (± 0.76%) 0.64s (± 1.08%) -0.01s (- 1.40%) 0.62s 0.65s
Check Time 13.00s (± 1.10%) 13.91s (± 0.89%) +0.91s (+ 6.98%) 13.71s 14.15s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.43s (± 0.97%) 16.33s (± 0.80%) +0.90s (+ 5.82%) 16.11s 16.57s
xstate - node (v12.1.0, x64)
Memory used 539,557k (± 1.48%) 535,945k (± 0.01%) -3,612k (- 0.67%) 535,810k 536,064k
Parse Time 2.51s (± 0.40%) 2.49s (± 0.60%) -0.02s (- 0.64%) 2.47s 2.52s
Bind Time 1.05s (± 0.74%) 1.04s (± 0.85%) -0.01s (- 1.14%) 1.02s 1.05s
Check Time 1.51s (± 0.79%) 1.49s (± 0.61%) -0.02s (- 1.26%) 1.47s 1.51s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.12s (± 0.42%) 5.09s (± 0.37%) -0.04s (- 0.72%) 5.06s 5.14s
Angular - node (v14.15.1, x64)
Memory used 330,345k (± 0.01%) 330,330k (± 0.01%) -15k (- 0.00%) 330,277k 330,397k
Parse Time 1.96s (± 0.64%) 1.95s (± 0.52%) -0.01s (- 0.76%) 1.93s 1.98s
Bind Time 0.86s (± 0.60%) 0.86s (± 0.77%) -0.00s (- 0.12%) 0.85s 0.88s
Check Time 5.37s (± 0.42%) 5.36s (± 0.56%) -0.02s (- 0.34%) 5.30s 5.42s
Emit Time 6.24s (± 1.84%) 6.15s (± 0.74%) -0.09s (- 1.46%) 6.05s 6.26s
Total Time 14.44s (± 0.88%) 14.32s (± 0.48%) -0.12s (- 0.84%) 14.15s 14.47s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,199k (± 0.01%) 192,890k (± 0.37%) -309k (- 0.16%) 189,975k 193,271k
Parse Time 0.81s (± 0.49%) 0.81s (± 0.49%) 0.00s ( 0.00%) 0.80s 0.82s
Bind Time 0.56s (± 0.72%) 0.55s (± 0.66%) -0.01s (- 0.89%) 0.55s 0.56s
Check Time 7.59s (± 0.39%) 7.56s (± 0.49%) -0.03s (- 0.41%) 7.50s 7.66s
Emit Time 2.46s (± 0.64%) 2.43s (± 0.77%) -0.03s (- 1.10%) 2.39s 2.47s
Total Time 11.42s (± 0.31%) 11.35s (± 0.30%) -0.06s (- 0.56%) 11.30s 11.43s
Monaco - node (v14.15.1, x64)
Memory used 324,000k (± 0.00%) 323,996k (± 0.01%) -5k (- 0.00%) 323,950k 324,024k
Parse Time 1.51s (± 0.76%) 1.51s (± 0.48%) -0.00s (- 0.07%) 1.50s 1.53s
Bind Time 0.76s (± 0.63%) 0.75s (± 0.45%) -0.00s (- 0.53%) 0.75s 0.76s
Check Time 5.35s (± 0.42%) 5.30s (± 0.45%) -0.05s (- 0.92%) 5.24s 5.34s
Emit Time 3.23s (± 0.76%) 3.22s (± 0.67%) -0.01s (- 0.28%) 3.17s 3.26s
Total Time 10.86s (± 0.31%) 10.79s (± 0.35%) -0.07s (- 0.64%) 10.69s 10.84s
TFS - node (v14.15.1, x64)
Memory used 288,364k (± 0.01%) 288,365k (± 0.01%) +1k (+ 0.00%) 288,319k 288,395k
Parse Time 1.24s (± 0.97%) 1.23s (± 0.42%) -0.01s (- 1.13%) 1.22s 1.24s
Bind Time 0.74s (± 1.13%) 0.73s (± 0.50%) -0.00s (- 0.14%) 0.73s 0.74s
Check Time 4.93s (± 0.41%) 4.90s (± 0.36%) -0.02s (- 0.49%) 4.86s 4.94s
Emit Time 3.47s (± 0.76%) 3.46s (± 0.74%) -0.01s (- 0.37%) 3.42s 3.53s
Total Time 10.38s (± 0.36%) 10.32s (± 0.31%) -0.05s (- 0.52%) 10.24s 10.39s
material-ui - node (v14.15.1, x64)
Memory used 447,451k (± 0.03%) 447,432k (± 0.01%) -19k (- 0.00%) 447,322k 447,489k
Parse Time 1.85s (± 0.52%) 1.83s (± 0.50%) -0.02s (- 0.92%) 1.81s 1.85s
Bind Time 0.68s (± 0.49%) 0.68s (± 0.50%) -0.00s (- 0.44%) 0.67s 0.68s
Check Time 13.07s (± 0.48%) 14.01s (± 0.37%) +0.95s (+ 7.23%) 13.91s 14.12s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.60s (± 0.42%) 16.52s (± 0.31%) +0.92s (+ 5.90%) 16.40s 16.63s
xstate - node (v14.15.1, x64)
Memory used 533,837k (± 0.01%) 533,800k (± 0.00%) -37k (- 0.01%) 533,750k 533,860k
Parse Time 2.55s (± 0.43%) 2.55s (± 0.42%) -0.00s (- 0.08%) 2.53s 2.58s
Bind Time 1.15s (± 1.11%) 1.15s (± 0.76%) +0.00s (+ 0.09%) 1.14s 1.18s
Check Time 1.55s (± 0.57%) 1.55s (± 0.57%) +0.00s (+ 0.06%) 1.54s 1.58s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.34s (± 0.28%) 5.33s (± 0.29%) -0.00s (- 0.09%) 5.30s 5.37s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory4 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 46505 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46505

Metric main 46505 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 330,345k (± 0.01%) 330,359k (± 0.01%) +14k (+ 0.00%) 330,311k 330,417k
Parse Time 1.96s (± 0.64%) 1.98s (± 0.44%) +0.02s (+ 0.87%) 1.96s 2.00s
Bind Time 0.86s (± 0.60%) 0.86s (± 0.69%) +0.00s (+ 0.46%) 0.86s 0.88s
Check Time 5.37s (± 0.42%) 5.39s (± 0.61%) +0.02s (+ 0.41%) 5.31s 5.45s
Emit Time 6.24s (± 1.84%) 6.22s (± 0.40%) -0.03s (- 0.46%) 6.17s 6.28s
Total Time 14.44s (± 0.88%) 14.45s (± 0.32%) +0.01s (+ 0.08%) 14.32s 14.54s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,199k (± 0.01%) 192,560k (± 0.49%) -639k (- 0.33%) 189,967k 193,279k
Parse Time 0.81s (± 0.49%) 0.81s (± 0.49%) +0.00s (+ 0.25%) 0.80s 0.82s
Bind Time 0.56s (± 0.72%) 0.56s (± 0.53%) +0.00s (+ 0.54%) 0.56s 0.57s
Check Time 7.59s (± 0.39%) 7.65s (± 0.54%) +0.07s (+ 0.88%) 7.55s 7.72s
Emit Time 2.46s (± 0.64%) 2.45s (± 0.93%) -0.01s (- 0.57%) 2.40s 2.51s
Total Time 11.42s (± 0.31%) 11.47s (± 0.49%) +0.05s (+ 0.46%) 11.35s 11.59s
Monaco - node (v14.15.1, x64)
Memory used 324,000k (± 0.00%) 324,006k (± 0.01%) +6k (+ 0.00%) 323,950k 324,075k
Parse Time 1.51s (± 0.76%) 1.51s (± 0.61%) -0.00s (- 0.07%) 1.49s 1.53s
Bind Time 0.76s (± 0.63%) 0.76s (± 0.53%) +0.00s (+ 0.26%) 0.75s 0.77s
Check Time 5.35s (± 0.42%) 5.33s (± 0.45%) -0.02s (- 0.36%) 5.28s 5.38s
Emit Time 3.23s (± 0.76%) 3.25s (± 0.62%) +0.02s (+ 0.46%) 3.19s 3.29s
Total Time 10.86s (± 0.31%) 10.85s (± 0.43%) -0.01s (- 0.07%) 10.72s 10.93s
TFS - node (v14.15.1, x64)
Memory used 288,364k (± 0.01%) 288,361k (± 0.01%) -3k (- 0.00%) 288,335k 288,418k
Parse Time 1.24s (± 0.97%) 1.24s (± 0.73%) -0.00s (- 0.32%) 1.22s 1.26s
Bind Time 0.74s (± 1.13%) 0.74s (± 0.68%) 0.00s ( 0.00%) 0.73s 0.75s
Check Time 4.93s (± 0.41%) 4.94s (± 0.54%) +0.01s (+ 0.24%) 4.90s 5.01s
Emit Time 3.47s (± 0.76%) 3.50s (± 0.47%) +0.03s (+ 0.78%) 3.47s 3.53s
Total Time 10.38s (± 0.36%) 10.42s (± 0.20%) +0.04s (+ 0.36%) 10.37s 10.48s
material-ui - node (v14.15.1, x64)
Memory used 447,451k (± 0.03%) 447,345k (± 0.04%) -106k (- 0.02%) 446,702k 447,444k
Parse Time 1.85s (± 0.52%) 1.84s (± 0.38%) -0.01s (- 0.38%) 1.83s 1.86s
Bind Time 0.68s (± 0.49%) 0.68s (± 0.53%) +0.00s (+ 0.59%) 0.68s 0.69s
Check Time 13.07s (± 0.48%) 14.16s (± 0.52%) +1.09s (+ 8.36%) 13.99s 14.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.60s (± 0.42%) 16.68s (± 0.43%) +1.09s (+ 6.96%) 16.50s 16.82s
xstate - node (v14.15.1, x64)
Memory used 533,837k (± 0.01%) 533,793k (± 0.01%) -45k (- 0.01%) 533,735k 533,867k
Parse Time 2.55s (± 0.43%) 2.57s (± 0.49%) +0.02s (+ 0.82%) 2.56s 2.61s
Bind Time 1.15s (± 1.11%) 1.16s (± 0.88%) +0.01s (+ 0.78%) 1.14s 1.19s
Check Time 1.55s (± 0.57%) 1.56s (± 0.47%) +0.01s (+ 0.58%) 1.55s 1.58s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.34s (± 0.28%) 5.37s (± 0.33%) +0.04s (+ 0.66%) 5.34s 5.41s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory4 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 46505 10
Baseline main 10

Developer Information:

Download Benchmark

@ahejlsberg
Copy link
Member Author

@typescript-bot perf test faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 25, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at f528318. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46505

Metric main 46505 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 330,330k (± 0.01%) 330,354k (± 0.01%) +24k (+ 0.01%) 330,263k 330,388k
Parse Time 1.95s (± 0.63%) 1.95s (± 1.59%) +0.00s (+ 0.21%) 1.92s 2.07s
Bind Time 0.86s (± 0.67%) 0.86s (± 0.52%) -0.00s (- 0.23%) 0.85s 0.87s
Check Time 5.33s (± 0.36%) 5.35s (± 0.34%) +0.01s (+ 0.23%) 5.31s 5.38s
Emit Time 6.10s (± 0.34%) 6.11s (± 0.40%) +0.00s (+ 0.07%) 6.05s 6.15s
Total Time 14.24s (± 0.20%) 14.26s (± 0.36%) +0.02s (+ 0.12%) 14.19s 14.42s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,265k (± 0.57%) 193,105k (± 0.12%) +840k (+ 0.44%) 192,145k 193,271k
Parse Time 0.81s (± 0.59%) 0.81s (± 0.83%) 0.00s ( 0.00%) 0.80s 0.83s
Bind Time 0.55s (± 0.40%) 0.55s (± 0.40%) 0.00s ( 0.00%) 0.55s 0.56s
Check Time 7.51s (± 0.31%) 7.54s (± 0.33%) +0.03s (+ 0.39%) 7.47s 7.59s
Emit Time 2.44s (± 0.47%) 2.43s (± 0.83%) -0.01s (- 0.29%) 2.40s 2.49s
Total Time 11.31s (± 0.21%) 11.33s (± 0.18%) +0.02s (+ 0.21%) 11.28s 11.38s
Monaco - node (v14.15.1, x64)
Memory used 324,010k (± 0.01%) 324,005k (± 0.01%) -5k (- 0.00%) 323,950k 324,041k
Parse Time 1.50s (± 0.88%) 1.51s (± 1.80%) +0.01s (+ 0.40%) 1.47s 1.61s
Bind Time 0.76s (± 0.66%) 0.75s (± 0.40%) -0.00s (- 0.40%) 0.75s 0.76s
Check Time 5.31s (± 0.35%) 5.29s (± 0.52%) -0.01s (- 0.26%) 5.21s 5.35s
Emit Time 3.22s (± 0.58%) 3.21s (± 0.79%) -0.01s (- 0.25%) 3.18s 3.30s
Total Time 10.79s (± 0.32%) 10.77s (± 0.43%) -0.02s (- 0.17%) 10.66s 10.86s
TFS - node (v14.15.1, x64)
Memory used 288,367k (± 0.01%) 288,370k (± 0.01%) +4k (+ 0.00%) 288,335k 288,405k
Parse Time 1.23s (± 0.76%) 1.23s (± 0.97%) +0.00s (+ 0.16%) 1.21s 1.27s
Bind Time 0.73s (± 0.67%) 0.73s (± 0.64%) -0.00s (- 0.54%) 0.72s 0.74s
Check Time 4.89s (± 0.46%) 4.90s (± 0.45%) +0.00s (+ 0.08%) 4.85s 4.96s
Emit Time 3.48s (± 1.12%) 3.48s (± 0.80%) -0.01s (- 0.26%) 3.40s 3.54s
Total Time 10.34s (± 0.49%) 10.34s (± 0.43%) -0.01s (- 0.06%) 10.19s 10.39s
material-ui - node (v14.15.1, x64)
Memory used 447,527k (± 0.01%) 447,291k (± 0.06%) -236k (- 0.05%) 446,149k 447,451k
Parse Time 1.83s (± 0.49%) 1.84s (± 2.67%) +0.02s (+ 0.88%) 1.81s 2.04s
Bind Time 0.68s (± 0.59%) 0.68s (± 0.54%) -0.01s (- 0.73%) 0.67s 0.68s
Check Time 13.00s (± 0.46%) 13.98s (± 0.65%) +0.99s (+ 7.59%) 13.81s 14.19s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.50s (± 0.38%) 16.50s (± 0.51%) +1.00s (+ 6.45%) 16.30s 16.69s
xstate - node (v14.15.1, x64)
Memory used 533,816k (± 0.01%) 533,808k (± 0.00%) -8k (- 0.00%) 533,758k 533,854k
Parse Time 2.55s (± 0.38%) 2.57s (± 0.58%) +0.02s (+ 0.67%) 2.53s 2.60s
Bind Time 1.15s (± 0.83%) 1.15s (± 0.82%) +0.00s (+ 0.17%) 1.13s 1.17s
Check Time 1.55s (± 0.44%) 1.54s (± 0.39%) -0.00s (- 0.06%) 1.53s 1.56s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.32s (± 0.23%) 5.33s (± 0.23%) +0.01s (+ 0.26%) 5.31s 5.36s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 46505 10
Baseline main 10

Developer Information:

Download Benchmark

@andrewbranch
Copy link
Member

material-ui 😵‍💫

@ahejlsberg
Copy link
Member Author

Closing in favor of #46523.

@ahejlsberg ahejlsberg closed this Oct 25, 2021
@ahejlsberg ahejlsberg mentioned this pull request Oct 25, 2021
Merged
@jakebailey jakebailey deleted the fix46500 branch November 7, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham Awaiting requested review from weswigham

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS 4.5 type instantiation is excessively deep and possibly infinite, with seemingly legal type
3 participants
@ahejlsberg @typescript-bot @andrewbranch