Skip to content

Exclude identity relation from mapped type relation check #46632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2021
Merged

Exclude identity relation from mapped type relation check #46632

merged 2 commits into from
Nov 2, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #46631.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 1, 2021
@ahejlsberg
Copy link
Member Author

@DanielRosenwasser @andrewbranch We should cherry pick this for 4.5.

@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 1, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at b1ab2c3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually.

@DanielRosenwasser
Copy link
Member 

git remote add nonlocal git://github.com/microsoft/TypeScript.git

git fetch nonlocal main
Error: git fetch nonlocal main failed: stderr: fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

😕

@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 2, 2021
Merged
@DanielRosenwasser
Copy link
Member

Cherry-pick over at #46635. I'm considering bringing it into the RC.

@ahejlsberg ahejlsberg merged commit 7cbcfee into main Nov 2, 2021
@ahejlsberg ahejlsberg deleted the fix46631 branch November 2, 2021 13:54
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@ahejlsberg @mprobst
Exclude identity relation from mapped type relation check (microsoft#…
7d3aa9b 
…46632)

* Exclude identity relation from mapped type relation check

* Add regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive stack depth error in type identity check
4 participants
@ahejlsberg @andrewbranch @typescript-bot @DanielRosenwasser