Skip to content

Ignore bad typings properties in package.json files #46877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Nov 19, 2021

Otherwise, the non-existent typings file becomes part of the project and a spurious non-existent-root-file error is reported.

This was reported by a customer using source-map.

This is pretty rare, but we could go above and beyond by trying to add the file extension ourselves.

Otherwise, the non-existent typings file becomes part of the project and
a spurious non-existent-root-file error is reported.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 19, 2021
@amcasey amcasey requested a review from andrewbranch November 19, 2021 22:39
@amcasey
Copy link
Member Author

amcasey commented Nov 20, 2021

Note to self: if we keep module resolution, confirm I didn't just break all packages with a file extension.

Moot

@minestarks
Copy link
Member

@amcasey - is there more work to do on this?

@zkat
Copy link
Contributor

zkat commented Jan 7, 2022

Closing in favor of #47164

@zkat zkat closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants