Skip to content

[Experiment] feat(47558): Warning 6133 ignores @link tags #47822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2022
Merged

[Experiment] feat(47558): Warning 6133 ignores @link tags #47822

merged 1 commit into from
Jun 6, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #47558

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 9, 2022
@a-tarasyuk a-tarasyuk force-pushed the feat/47558 branch 2 times, most recently from 828cdbf to bc6a0dd Compare February 11, 2022 19:49
@a-tarasyuk a-tarasyuk marked this pull request as draft February 19, 2022 18:49
@a-tarasyuk a-tarasyuk marked this pull request as ready for review February 20, 2022 06:58
sandersn
sandersn requested changes Feb 24, 2022
View reviewed changes
@sandersn sandersn self-assigned this Feb 24, 2022
sandersn
sandersn requested changes May 10, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does the right thing, but I'd like some tests to show that we don't start issuing errors on unresolved links.

Edit: Sorry this slipped through the cracks.

@a-tarasyuk a-tarasyuk requested a review from sandersn May 11, 2022 07:33
@a-tarasyuk a-tarasyuk mentioned this pull request May 19, 2022
Closed
5 tasks
sandersn
sandersn approved these changes Jun 6, 2022
View reviewed changes
@sandersn sandersn merged commit 62668c6 into microsoft:main Jun 6, 2022
@WillsterJohnson WillsterJohnson mentioned this pull request Jun 7, 2022
Closed
@Danielku15 Danielku15 mentioned this pull request Feb 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning 6133 ignores @link tags
3 participants
@a-tarasyuk @sandersn @typescript-bot