Handle package.json watch in tsc and tsserver. #49328
Merged
+1,974
−550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…everything on package json change
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Ping @weswigham @andrewbranch can you please review this part. This has nothing to do with build mode and have pulled the build mode changes so we can reflect on design for later. |
andrewbranch
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this:
affectingLocationson each resolution just like we store failed lookups, this helps in resolving only partial changes as well as not having to do full config file reload which is expensive.This is subset of changes from #48889. This does not include changes to
tsc --buildthat portion can be iterated upon in that PR