Eliminate (ts as any).SyntaxKind (and similar) in favor of Debug.format functions #49485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Jun 10, 2022
| JSDocFunctionType, | ||
| JSDocVariadicType, | ||
| JSDocNamepathType, // https://jsdoc.app/about-namepaths.html | ||
| JSDoc, |
There was a problem hiding this comment.
I've moved this up here because our debug helpers choose the earliest name as the printed name. It was previously defined with the markers, which meant we printed out the deprecated form instead.
jakebailey
commented
Jun 10, 2022
Comment on lines
-179
to
-188
| if (k === (ts as any).SyntaxKind.FirstJSDocNode || | ||
| k === (ts as any).SyntaxKind.LastJSDocNode || | ||
| k === (ts as any).SyntaxKind.FirstJSDocTagNode || | ||
| k === (ts as any).SyntaxKind.LastJSDocTagNode) { | ||
| for (const kindName in (ts as any).SyntaxKind) { | ||
| if ((ts as any).SyntaxKind[kindName] === k) { | ||
| return kindName; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Using ts.Debug.formatSyntaxKind is slower because it does a lot more work than these 4 hardcoded things. To regain the perf, I have another PR that will make formatSyntaxKind faster.
I still think it's better to not write the same enum-member-to-string code more than once, but it's annoying that a perf fix is required to do it.
There was a problem hiding this comment.
#49487 recovers the performance; it's 25% of the test run :(
weswigham
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change pulled off of my module transform branch; these uses of
tsare often the only uses oftsin a file, so it's advantageous to remove them.But it also has the benefit of not duplicating logic to get the name of a
SyntaxKindor similar; you can see in the baselines that there are nodes that are incorrectly printed as "FirstNode". The harness code previously duplicated its own SyntaxKind printer and hardcoded a couple of markers, butformatSyntaxKindis smart enough to do that on its own.