-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Ensure common supertype retains nullability in inference #49981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c2e62b
Add test case with temporary name
jakebailey b288657
Rename and revamp test
jakebailey 30d0cdc
Ensure common supertype retains nullability
jakebailey 1b96117
Avoid producing brand new types in getCommonSupertype
jakebailey a817435
Only check for undefined or null directly or in unions
jakebailey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
tests/baselines/reference/inferenceDoesNotAddUndefinedOrNull.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| //// [inferenceDoesNotAddUndefinedOrNull.ts] | ||
| interface NodeArray<T extends Node> extends ReadonlyArray<T> {} | ||
|
|
||
| interface Node { | ||
| forEachChild<T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: (nodes: NodeArray<Node>) => T | undefined): T | undefined; | ||
| } | ||
|
|
||
| declare function toArray<T>(value: T | T[]): T[]; | ||
| declare function toArray<T>(value: T | readonly T[]): readonly T[]; | ||
|
|
||
| function flatMapChildren<T>(node: Node, cb: (child: Node) => readonly T[] | T | undefined): readonly T[] { | ||
| const result: T[] = []; | ||
| node.forEachChild(child => { | ||
| const value = cb(child); | ||
| if (value !== undefined) { | ||
| result.push(...toArray(value)); | ||
| } | ||
| }); | ||
| return result; | ||
| } | ||
|
|
||
| function flatMapChildren2<T>(node: Node, cb: (child: Node) => readonly T[] | T | null): readonly T[] { | ||
| const result: T[] = []; | ||
| node.forEachChild(child => { | ||
| const value = cb(child); | ||
| if (value !== null) { | ||
| result.push(...toArray(value)); | ||
| } | ||
| }); | ||
| return result; | ||
| } | ||
|
|
||
|
|
||
| //// [inferenceDoesNotAddUndefinedOrNull.js] | ||
| "use strict"; | ||
| function flatMapChildren(node, cb) { | ||
| var result = []; | ||
| node.forEachChild(function (child) { | ||
| var value = cb(child); | ||
| if (value !== undefined) { | ||
| result.push.apply(result, toArray(value)); | ||
| } | ||
| }); | ||
| return result; | ||
| } | ||
| function flatMapChildren2(node, cb) { | ||
| var result = []; | ||
| node.forEachChild(function (child) { | ||
| var value = cb(child); | ||
| if (value !== null) { | ||
| result.push.apply(result, toArray(value)); | ||
| } | ||
| }); | ||
| return result; | ||
| } |
127 changes: 127 additions & 0 deletions
127
tests/baselines/reference/inferenceDoesNotAddUndefinedOrNull.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| === tests/cases/compiler/inferenceDoesNotAddUndefinedOrNull.ts === | ||
| interface NodeArray<T extends Node> extends ReadonlyArray<T> {} | ||
| >NodeArray : Symbol(NodeArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 0)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 20)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >ReadonlyArray : Symbol(ReadonlyArray, Decl(lib.es5.d.ts, --, --)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 20)) | ||
|
|
||
| interface Node { | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
|
|
||
| forEachChild<T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: (nodes: NodeArray<Node>) => T | undefined): T | undefined; | ||
| >forEachChild : Symbol(Node.forEachChild, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 2, 16)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 17)) | ||
| >cbNode : Symbol(cbNode, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 20)) | ||
| >node : Symbol(node, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 29)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 17)) | ||
| >cbNodeArray : Symbol(cbNodeArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 58)) | ||
| >nodes : Symbol(nodes, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 74)) | ||
| >NodeArray : Symbol(NodeArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 0)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 17)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 3, 17)) | ||
| } | ||
|
|
||
| declare function toArray<T>(value: T | T[]): T[]; | ||
| >toArray : Symbol(toArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 4, 1), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 49)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 25)) | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 28)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 25)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 25)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 25)) | ||
|
|
||
| declare function toArray<T>(value: T | readonly T[]): readonly T[]; | ||
| >toArray : Symbol(toArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 4, 1), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 49)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 7, 25)) | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 7, 28)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 7, 25)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 7, 25)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 7, 25)) | ||
|
|
||
| function flatMapChildren<T>(node: Node, cb: (child: Node) => readonly T[] | T | undefined): readonly T[] { | ||
| >flatMapChildren : Symbol(flatMapChildren, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 7, 67)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 25)) | ||
| >node : Symbol(node, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 28)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >cb : Symbol(cb, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 39)) | ||
| >child : Symbol(child, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 45)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 25)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 25)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 25)) | ||
|
|
||
| const result: T[] = []; | ||
| >result : Symbol(result, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 10, 9)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 25)) | ||
|
|
||
| node.forEachChild(child => { | ||
| >node.forEachChild : Symbol(Node.forEachChild, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 2, 16)) | ||
| >node : Symbol(node, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 28)) | ||
| >forEachChild : Symbol(Node.forEachChild, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 2, 16)) | ||
| >child : Symbol(child, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 11, 22)) | ||
|
|
||
| const value = cb(child); | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 12, 13)) | ||
| >cb : Symbol(cb, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 9, 39)) | ||
| >child : Symbol(child, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 11, 22)) | ||
|
|
||
| if (value !== undefined) { | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 12, 13)) | ||
| >undefined : Symbol(undefined) | ||
|
|
||
| result.push(...toArray(value)); | ||
| >result.push : Symbol(Array.push, Decl(lib.es5.d.ts, --, --)) | ||
| >result : Symbol(result, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 10, 9)) | ||
| >push : Symbol(Array.push, Decl(lib.es5.d.ts, --, --)) | ||
| >toArray : Symbol(toArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 4, 1), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 49)) | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 12, 13)) | ||
| } | ||
| }); | ||
| return result; | ||
| >result : Symbol(result, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 10, 9)) | ||
| } | ||
|
|
||
| function flatMapChildren2<T>(node: Node, cb: (child: Node) => readonly T[] | T | null): readonly T[] { | ||
| >flatMapChildren2 : Symbol(flatMapChildren2, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 18, 1)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 26)) | ||
| >node : Symbol(node, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 29)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >cb : Symbol(cb, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 40)) | ||
| >child : Symbol(child, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 46)) | ||
| >Node : Symbol(Node, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 0, 63)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 26)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 26)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 26)) | ||
|
|
||
| const result: T[] = []; | ||
| >result : Symbol(result, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 21, 9)) | ||
| >T : Symbol(T, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 26)) | ||
|
|
||
| node.forEachChild(child => { | ||
| >node.forEachChild : Symbol(Node.forEachChild, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 2, 16)) | ||
| >node : Symbol(node, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 29)) | ||
| >forEachChild : Symbol(Node.forEachChild, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 2, 16)) | ||
| >child : Symbol(child, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 22, 22)) | ||
|
|
||
| const value = cb(child); | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 23, 13)) | ||
| >cb : Symbol(cb, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 20, 40)) | ||
| >child : Symbol(child, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 22, 22)) | ||
|
|
||
| if (value !== null) { | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 23, 13)) | ||
|
|
||
| result.push(...toArray(value)); | ||
| >result.push : Symbol(Array.push, Decl(lib.es5.d.ts, --, --)) | ||
| >result : Symbol(result, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 21, 9)) | ||
| >push : Symbol(Array.push, Decl(lib.es5.d.ts, --, --)) | ||
| >toArray : Symbol(toArray, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 4, 1), Decl(inferenceDoesNotAddUndefinedOrNull.ts, 6, 49)) | ||
| >value : Symbol(value, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 23, 13)) | ||
| } | ||
| }); | ||
| return result; | ||
| >result : Symbol(result, Decl(inferenceDoesNotAddUndefinedOrNull.ts, 21, 9)) | ||
| } | ||
|
|
109 changes: 109 additions & 0 deletions
109
tests/baselines/reference/inferenceDoesNotAddUndefinedOrNull.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| === tests/cases/compiler/inferenceDoesNotAddUndefinedOrNull.ts === | ||
| interface NodeArray<T extends Node> extends ReadonlyArray<T> {} | ||
|
|
||
| interface Node { | ||
| forEachChild<T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: (nodes: NodeArray<Node>) => T | undefined): T | undefined; | ||
| >forEachChild : <T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: ((nodes: NodeArray<Node>) => T | undefined) | undefined) => T | undefined | ||
| >cbNode : (node: Node) => T | undefined | ||
| >node : Node | ||
| >cbNodeArray : ((nodes: NodeArray<Node>) => T | undefined) | undefined | ||
| >nodes : NodeArray<Node> | ||
| } | ||
|
|
||
| declare function toArray<T>(value: T | T[]): T[]; | ||
| >toArray : { <T>(value: T | T[]): T[]; <T>(value: T | readonly T[]): readonly T[]; } | ||
| >value : T | T[] | ||
|
|
||
| declare function toArray<T>(value: T | readonly T[]): readonly T[]; | ||
| >toArray : { <T>(value: T | T[]): T[]; <T>(value: T | readonly T[]): readonly T[]; } | ||
| >value : T | readonly T[] | ||
|
|
||
| function flatMapChildren<T>(node: Node, cb: (child: Node) => readonly T[] | T | undefined): readonly T[] { | ||
| >flatMapChildren : <T>(node: Node, cb: (child: Node) => readonly T[] | T | undefined) => readonly T[] | ||
| >node : Node | ||
| >cb : (child: Node) => readonly T[] | T | undefined | ||
| >child : Node | ||
|
|
||
| const result: T[] = []; | ||
| >result : T[] | ||
| >[] : never[] | ||
|
|
||
| node.forEachChild(child => { | ||
| >node.forEachChild(child => { const value = cb(child); if (value !== undefined) { result.push(...toArray(value)); } }) : void | undefined | ||
| >node.forEachChild : <T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: ((nodes: NodeArray<Node>) => T | undefined) | undefined) => T | undefined | ||
| >node : Node | ||
| >forEachChild : <T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: ((nodes: NodeArray<Node>) => T | undefined) | undefined) => T | undefined | ||
| >child => { const value = cb(child); if (value !== undefined) { result.push(...toArray(value)); } } : (child: Node) => void | ||
| >child : Node | ||
|
|
||
| const value = cb(child); | ||
| >value : T | readonly T[] | undefined | ||
| >cb(child) : T | readonly T[] | undefined | ||
| >cb : (child: Node) => T | readonly T[] | undefined | ||
| >child : Node | ||
|
|
||
| if (value !== undefined) { | ||
| >value !== undefined : boolean | ||
| >value : T | readonly T[] | undefined | ||
| >undefined : undefined | ||
|
|
||
| result.push(...toArray(value)); | ||
| >result.push(...toArray(value)) : number | ||
| >result.push : (...items: T[]) => number | ||
| >result : T[] | ||
| >push : (...items: T[]) => number | ||
| >...toArray(value) : T | ||
| >toArray(value) : readonly T[] | ||
| >toArray : { <T>(value: T | T[]): T[]; <T>(value: T | readonly T[]): readonly T[]; } | ||
| >value : readonly T[] | (T & ({} | null)) | ||
| } | ||
| }); | ||
| return result; | ||
| >result : T[] | ||
| } | ||
|
|
||
| function flatMapChildren2<T>(node: Node, cb: (child: Node) => readonly T[] | T | null): readonly T[] { | ||
| >flatMapChildren2 : <T>(node: Node, cb: (child: Node) => readonly T[] | T | null) => readonly T[] | ||
| >node : Node | ||
| >cb : (child: Node) => readonly T[] | T | null | ||
| >child : Node | ||
| >null : null | ||
|
|
||
| const result: T[] = []; | ||
| >result : T[] | ||
| >[] : never[] | ||
|
|
||
| node.forEachChild(child => { | ||
| >node.forEachChild(child => { const value = cb(child); if (value !== null) { result.push(...toArray(value)); } }) : void | undefined | ||
| >node.forEachChild : <T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: ((nodes: NodeArray<Node>) => T | undefined) | undefined) => T | undefined | ||
| >node : Node | ||
| >forEachChild : <T>(cbNode: (node: Node) => T | undefined, cbNodeArray?: ((nodes: NodeArray<Node>) => T | undefined) | undefined) => T | undefined | ||
| >child => { const value = cb(child); if (value !== null) { result.push(...toArray(value)); } } : (child: Node) => void | ||
| >child : Node | ||
|
|
||
| const value = cb(child); | ||
| >value : T | readonly T[] | null | ||
| >cb(child) : T | readonly T[] | null | ||
| >cb : (child: Node) => T | readonly T[] | null | ||
| >child : Node | ||
|
|
||
| if (value !== null) { | ||
| >value !== null : boolean | ||
| >value : T | readonly T[] | null | ||
| >null : null | ||
|
|
||
| result.push(...toArray(value)); | ||
| >result.push(...toArray(value)) : number | ||
| >result.push : (...items: T[]) => number | ||
| >result : T[] | ||
| >push : (...items: T[]) => number | ||
| >...toArray(value) : T | ||
| >toArray(value) : readonly T[] | ||
| >toArray : { <T>(value: T | T[]): T[]; <T>(value: T | readonly T[]): readonly T[]; } | ||
| >value : readonly T[] | (T & ({} | undefined)) | ||
| } | ||
| }); | ||
| return result; | ||
| >result : T[] | ||
| } | ||
|
|
40 changes: 40 additions & 0 deletions
40
tests/baselines/reference/inferenceOfNullableObjectTypesWithCommonBase.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| //// [inferenceOfNullableObjectTypesWithCommonBase.ts] | ||
| function equal<T>(a: T, b: T) { } | ||
|
|
||
| let v = null!; | ||
|
|
||
| // Object types with common base types | ||
|
|
||
| type B = { foo: string } | ||
| type D = { foo: string; bar: number } | ||
|
|
||
| equal(v as B, v as undefined | D) | ||
| equal(v as undefined | D, v as B) | ||
|
|
||
| equal<undefined | B>(v as B, v as undefined | D) | ||
| equal<undefined | B>(v as undefined | D, v as B) | ||
|
|
||
| equal(v as B, v as undefined) | ||
| equal(v as undefined, v as B) | ||
|
|
||
| equal(v as B, v as D) | ||
| equal(v as D, v as B) | ||
|
|
||
| equal(v as B, v as B | undefined) | ||
| equal(v as B | undefined, v as B) | ||
|
|
||
|
|
||
| //// [inferenceOfNullableObjectTypesWithCommonBase.js] | ||
| "use strict"; | ||
| function equal(a, b) { } | ||
| var v = null; | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); | ||
| equal(v, v); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels common enough that I would rather us lift it up to
someTypeHasFlagsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that, yeah, though I think most places just entirely inline it, so I could just do that too.