Add an additional test for favoring the asserted type in type predicate narrowing #50065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Comment on lines
8
to
22
| declare const obj1: {}; | ||
| obj1; // {} | ||
| if (isObject(obj1)) { | ||
| obj1; // Record<string, unknown> | ||
| obj1['attr']; | ||
| } | ||
| obj1; // Record<string, unknown> | ||
|
|
||
| declare const obj2: {} | undefined; | ||
| obj2; // {} | undefined | ||
| if (isObject(obj2)) { | ||
| obj2; // Record<string, unknown> | ||
| obj2['attr']; | ||
| } | ||
| obj2; // Record<string, unknown> | undefined |
There was a problem hiding this comment.
I know it's unfair to ask this of you since there were no tests, but:
- I would remove the comments - the type baselines and errors will indicate these better and not need to be updated.
- I would also add test cases for a type predicate like
value is {}acting onRecord<string, unknown>andRecord<string, unknown> | undefined.
There was a problem hiding this comment.
No problem - I've added the requested test cases and removed those comments (I've originally kept them as they are pretty popular in your test suite)
There was a problem hiding this comment.
I've originally kept them as they are pretty popular in your test suite
Yeah, I am not a fan 😅
They fall out of date with the baselines so it never made sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the #50044 didn't introduce a new test related to the issue that it closed and I've figured out that it might be nice to add it