Avoid bogus circularity error on context sensitive expando assingment #50487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProKashif
reviewed
Aug 28, 2022
|
This is probably the right change, except I wish I knew why TS files previously called |
|
Do you want to keep working on this? Otherwise I'd like to close it to reduce the number of open PRs. Before I merge, I'd like to know the answers to the questions in my previous comment. |
|
Oh sure. After a brief look at the code, I can see why you care about this deletion. It does look innocent. Edit: Can't find a reason to delete it. |
Zzzen
force-pushed
the
iife-on-expando-assignment
branch
from
9fc4164 to
076a39a
Compare
sandersn
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49944