Suppress resolvedUsingTsExtension during loadModuleFromDirectory

[jakebailey]

Fixes #52182

This is the fix suggested by @weswigham; the state prop could also be undefined and implicit to avoid setting false everywhere, but I am guessing this makes it slower somehow.

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 7f4baf6. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 7f4baf6. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7f4baf6. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7f4baf6. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7f4baf6. You can monitor the build here.

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52189/merge:

Everything looks good!

[weswigham]

This is the only callsite where we construct a path and feed it into nodeLoadModuleByRelativeName where that path doesn't come from a user-supplied specifier, right? Right.

[typescript-bot]

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

[jakebailey]

I think so? Interestingly, it's also the only place where we pass considerPackageJson=false, so maybe that is the flag I should be using?

[andrewbranch]

I think the meaningful thing is whether the module name you’re currently trying to resolve actually came from an import module specifier in source code (this is the only time resolvedUsingTsExtension matters / should be set) or from a filename listed in a config file.

Actually, it’s a bit more nuanced than that. What matters is whether the file extension itself came from an import module specifier. The module name you’re resolving could be a combination of source text and path mapping config text constructed via a wildcard substitution, e.g.:

// ts
import "foo/bar.ts"
import "baz/main.ts"

// tsconfig
"paths": {
  "foo/*": ["./dist/*"],
  "baz/*.ts": ["./types/*.d.ts"]
}

Assuming both of these resolve, resolvedUsingTsExtension should be set on the former but not on the latter 😵. I should have thought to add tests like this.

[jakebailey]

I'm basically just a monkey at a typewriter on this one having never touched this code before... 😅

Are you saying that this fix isn't complete/right and I should be fixing things up? (I'll add that case in and see what happens.)

[jakebailey]

I added what I think is the test you suggested? (Though, maybe not, given this bug is only in the node10 resolver? Maybe?)

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52189

Metric	main	52189	Delta	Best	Worst
Angular - node (v18.10.0, x64)
Memory used	372,660k (± 0.01%)	372,397k (± 0.01%)	-263k (- 0.07%)	372,342k	372,438k
Parse Time	3.93s (± 0.82%)	3.96s (± 0.83%)	+0.02s (+ 0.59%)	3.90s	4.00s
Bind Time	1.20s (± 0.39%)	1.20s (± 0.73%)	-0.00s (- 0.41%)	1.19s	1.21s
Check Time	8.60s (± 0.43%)	8.60s (± 0.57%)	+0.00s (+ 0.04%)	8.55s	8.66s
Emit Time	7.50s (± 0.37%)	7.53s (± 0.82%)	+0.02s (+ 0.29%)	7.48s	7.64s
Total Time	21.24s (± 0.18%)	21.29s (± 0.56%)	+0.05s (+ 0.22%)	21.16s	21.51s
Compiler-Unions - node (v18.10.0, x64)
Memory used	202,113k (± 1.43%)	203,148k (± 1.14%)	+1,036k (+ 0.51%)	198,401k	204,235k
Parse Time	1.66s (± 1.58%)	1.67s (± 0.81%)	+0.00s (+ 0.17%)	1.65s	1.68s
Bind Time	0.79s (± 0.15%)	0.79s (± 0.61%)	+0.00s (+ 0.28%)	0.79s	0.80s
Check Time	9.47s (± 1.14%)	9.54s (± 0.72%)	+0.06s (+ 0.68%)	9.44s	9.60s
Emit Time	2.76s (± 0.65%)	2.76s (± 1.07%)	-0.00s (- 0.05%)	2.70s	2.79s
Total Time	14.68s (± 0.66%)	14.75s (± 0.54%)	+0.07s (+ 0.46%)	14.66s	14.85s
Monaco - node (v18.10.0, x64)
Memory used	354,119k (± 0.01%)	354,138k (± 0.01%)	+19k (+ 0.01%)	354,044k	354,188k
Parse Time	2.93s (± 0.59%)	2.93s (± 1.06%)	+0.00s (+ 0.02%)	2.89s	2.98s
Bind Time	1.04s (± 0.82%)	1.04s (± 1.42%)	+0.00s (+ 0.29%)	1.03s	1.06s
Check Time	7.24s (± 0.43%)	7.24s (± 0.47%)	+0.01s (+ 0.09%)	7.20s	7.29s
Emit Time	4.27s (± 0.98%)	4.29s (± 0.50%)	+0.02s (+ 0.52%)	4.25s	4.31s
Total Time	15.48s (± 0.41%)	15.51s (± 0.22%)	+0.03s (+ 0.19%)	15.46s	15.56s
TFS - node (v18.10.0, x64)
Memory used	310,022k (± 0.01%)	310,177k (± 0.01%)	+155k (+ 0.05%)	310,157k	310,206k
Parse Time	2.26s (± 0.50%)	2.29s (± 0.81%)	+0.03s (+ 1.29%)	2.27s	2.32s
Bind Time	1.16s (± 0.53%)	1.15s (± 0.81%)	-0.01s (- 0.89%)	1.13s	1.16s
Check Time	6.79s (± 0.62%)	6.84s (± 0.88%)	+0.05s (+ 0.72%)	6.76s	6.94s
Emit Time	3.93s (± 0.71%)	3.95s (± 0.43%)	+0.02s (+ 0.51%)	3.93s	3.97s
Total Time	14.14s (± 0.50%)	14.23s (± 0.46%)	+0.09s (+ 0.62%)	14.14s	14.33s
material-ui - node (v18.10.0, x64)
Memory used	485,241k (± 0.02%)	485,233k (± 0.01%)	-8k (- 0.00%)	485,134k	485,296k
Parse Time	3.54s (± 0.68%)	3.52s (± 0.42%)	-0.02s (- 0.49%)	3.50s	3.54s
Bind Time	0.97s (± 0.93%)	0.96s (± 0.80%)	-0.01s (- 0.92%)	0.95s	0.97s
Check Time	16.91s (± 0.16%)	16.95s (± 0.45%)	+0.04s (+ 0.22%)	16.82s	17.03s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	21.42s (± 0.19%)	21.44s (± 0.39%)	+0.01s (+ 0.07%)	21.31s	21.52s
xstate - node (v18.10.0, x64)
Memory used	570,346k (± 0.03%)	570,433k (± 0.02%)	+88k (+ 0.02%)	570,288k	570,642k
Parse Time	4.42s (± 0.41%)	4.45s (± 0.26%)	+0.04s (+ 0.84%)	4.44s	4.47s
Bind Time	1.69s (± 0.80%)	1.72s (± 0.61%)	+0.02s (+ 1.44%)	1.71s	1.74s
Check Time	2.61s (± 1.20%)	2.60s (± 1.05%)	-0.01s (- 0.28%)	2.57s	2.64s
Emit Time	0.08s (± 0.18%)	0.08s (± 0.20%)	+0.00s (+ 0.17%)	0.08s	0.08s
Total Time	8.81s (± 0.38%)	8.85s (± 0.42%)	+0.04s (+ 0.43%)	8.80s	8.90s
Angular - node (v16.17.1, x64)
Memory used	372,012k (± 0.01%)	371,783k (± 0.01%)	-229k (- 0.06%)	371,738k	371,823k
Parse Time	4.13s (± 0.35%)	4.11s (± 0.35%)	-0.02s (- 0.38%)	4.10s	4.14s
Bind Time	1.27s (± 0.77%)	1.27s (± 0.51%)	+0.00s (+ 0.23%)	1.26s	1.28s
Check Time	9.31s (± 0.27%)	9.34s (± 0.74%)	+0.02s (+ 0.26%)	9.27s	9.46s
Emit Time	7.98s (± 0.21%)	7.98s (± 0.49%)	+0.00s (+ 0.06%)	7.94s	8.04s
Total Time	22.68s (± 0.17%)	22.70s (± 0.23%)	+0.01s (+ 0.06%)	22.62s	22.78s
Compiler-Unions - node (v16.17.1, x64)
Memory used	200,472k (± 0.68%)	199,919k (± 0.06%)	-553k (- 0.28%)	199,677k	200,031k
Parse Time	1.80s (± 1.52%)	1.81s (± 0.35%)	+0.01s (+ 0.46%)	1.80s	1.82s
Bind Time	0.84s (± 0.80%)	0.84s (± 0.72%)	+0.00s (+ 0.40%)	0.83s	0.85s
Check Time	10.09s (± 1.04%)	10.04s (± 0.82%)	-0.05s (- 0.51%)	9.93s	10.15s
Emit Time	3.04s (± 4.21%)	3.02s (± 3.37%)	-0.02s (- 0.60%)	2.95s	3.22s
Total Time	15.77s (± 1.49%)	15.71s (± 0.83%)	-0.06s (- 0.37%)	15.53s	15.88s
Monaco - node (v16.17.1, x64)
Memory used	353,418k (± 0.01%)	353,427k (± 0.01%)	+10k (+ 0.00%)	353,402k	353,453k
Parse Time	3.16s (± 0.88%)	3.17s (± 0.82%)	+0.01s (+ 0.34%)	3.13s	3.20s
Bind Time	1.12s (± 0.85%)	1.12s (± 1.23%)	-0.00s (- 0.01%)	1.10s	1.14s
Check Time	7.86s (± 0.58%)	7.87s (± 0.45%)	+0.01s (+ 0.18%)	7.83s	7.92s
Emit Time	4.50s (± 0.48%)	4.51s (± 0.80%)	+0.01s (+ 0.13%)	4.45s	4.55s
Total Time	16.64s (± 0.41%)	16.68s (± 0.45%)	+0.04s (+ 0.21%)	16.59s	16.79s
TFS - node (v16.17.1, x64)
Memory used	309,375k (± 0.00%)	309,550k (± 0.00%)	+175k (+ 0.06%)	309,533k	309,565k
Parse Time	2.63s (± 1.20%)	2.63s (± 3.31%)	-0.00s (- 0.10%)	2.49s	2.74s
Bind Time	1.06s (± 1.93%)	1.06s (± 6.32%)	-0.00s (- 0.26%)	1.02s	1.20s
Check Time	7.42s (± 0.48%)	7.40s (± 0.42%)	-0.02s (- 0.23%)	7.37s	7.45s
Emit Time	4.23s (± 0.48%)	4.23s (± 0.46%)	-0.00s (- 0.02%)	4.20s	4.25s
Total Time	15.35s (± 0.33%)	15.32s (± 0.55%)	-0.02s (- 0.15%)	15.25s	15.48s
material-ui - node (v16.17.1, x64)
Memory used	484,513k (± 0.01%)	484,530k (± 0.00%)	+17k (+ 0.00%)	484,508k	484,551k
Parse Time	3.67s (± 0.29%)	3.67s (± 0.47%)	-0.00s (- 0.10%)	3.65s	3.69s
Bind Time	1.01s (± 0.72%)	1.01s (± 0.59%)	-0.00s (- 0.29%)	1.00s	1.02s
Check Time	17.89s (± 0.60%)	17.87s (± 0.23%)	-0.03s (- 0.14%)	17.82s	17.92s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	22.58s (± 0.47%)	22.55s (± 0.24%)	-0.03s (- 0.15%)	22.49s	22.63s
xstate - node (v16.17.1, x64)
Memory used	567,869k (± 0.02%)	567,884k (± 0.01%)	+14k (+ 0.00%)	567,851k	567,977k
Parse Time	4.74s (± 0.58%)	4.76s (± 0.31%)	+0.02s (+ 0.32%)	4.74s	4.77s
Bind Time	1.65s (± 0.43%)	1.65s (± 0.43%)	-0.00s (- 0.17%)	1.64s	1.66s
Check Time	2.84s (± 0.41%)	2.83s (± 0.29%)	-0.02s (- 0.53%)	2.81s	2.84s
Emit Time	0.09s (± 4.58%)	0.08s (± 6.25%)	🟩-0.01s (- 5.72%)	0.08s	0.09s
Total Time	9.33s (± 0.44%)	9.33s (± 0.11%)	-0.00s (- 0.03%)	9.31s	9.34s
Angular - node (v14.15.1, x64)
Memory used	365,695k (± 0.01%)	365,454k (± 0.01%)	-242k (- 0.07%)	365,422k	365,477k
Parse Time	4.16s (± 0.58%)	4.17s (± 0.10%)	+0.01s (+ 0.15%)	4.16s	4.17s
Bind Time	1.30s (± 0.78%)	1.30s (± 0.63%)	-0.00s (- 0.22%)	1.29s	1.31s
Check Time	9.67s (± 0.91%)	9.67s (± 0.40%)	-0.00s (- 0.02%)	9.62s	9.72s
Emit Time	8.20s (± 0.69%)	8.25s (± 0.88%)	+0.06s (+ 0.70%)	8.17s	8.37s
Total Time	23.33s (± 0.62%)	23.39s (± 0.45%)	+0.06s (+ 0.27%)	23.28s	23.56s
Compiler-Unions - node (v14.15.1, x64)
Memory used	195,185k (± 0.02%)	195,186k (± 0.02%)	+1k (+ 0.00%)	195,157k	195,243k
Parse Time	1.85s (± 0.45%)	1.86s (± 0.62%)	+0.01s (+ 0.81%)	1.84s	1.87s
Bind Time	0.87s (± 0.94%)	0.87s (± 0.60%)	+0.00s (+ 0.19%)	0.87s	0.88s
Check Time	10.12s (± 0.32%)	10.13s (± 0.69%)	+0.01s (+ 0.15%)	10.03s	10.24s
Emit Time	3.14s (± 0.68%)	3.12s (± 0.81%)	-0.02s (- 0.69%)	3.09s	3.15s
Total Time	15.98s (± 0.23%)	15.99s (± 0.50%)	+0.01s (+ 0.05%)	15.87s	16.10s
Monaco - node (v14.15.1, x64)
Memory used	348,263k (± 0.00%)	348,304k (± 0.02%)	+41k (+ 0.01%)	348,245k	348,411k
Parse Time	3.24s (± 1.07%)	3.28s (± 0.48%)	+0.03s (+ 1.03%)	3.26s	3.30s
Bind Time	1.12s (± 0.91%)	1.12s (± 0.73%)	+0.00s (+ 0.15%)	1.11s	1.14s
Check Time	8.15s (± 0.69%)	8.16s (± 0.32%)	+0.01s (+ 0.14%)	8.15s	8.21s
Emit Time	4.70s (± 0.77%)	4.72s (± 0.72%)	+0.02s (+ 0.36%)	4.68s	4.78s
Total Time	17.22s (± 0.58%)	17.29s (± 0.24%)	+0.07s (+ 0.40%)	17.25s	17.36s
TFS - node (v14.15.1, x64)
Memory used	304,280k (± 0.00%)	304,467k (± 0.00%)	+186k (+ 0.06%)	304,446k	304,485k
Parse Time	2.73s (± 1.20%)	2.75s (± 1.39%)	+0.02s (+ 0.64%)	2.70s	2.80s
Bind Time	1.09s (± 0.77%)	1.10s (± 0.82%)	+0.02s (+ 1.72%)	1.10s	1.12s
Check Time	7.73s (± 0.42%)	7.74s (± 0.42%)	+0.01s (+ 0.08%)	7.71s	7.79s
Emit Time	4.60s (± 0.99%)	4.59s (± 0.93%)	-0.01s (- 0.22%)	4.52s	4.63s
Total Time	16.15s (± 0.58%)	16.18s (± 0.62%)	+0.03s (+ 0.19%)	16.06s	16.33s
material-ui - node (v14.15.1, x64)
Memory used	479,985k (± 0.01%)	479,952k (± 0.01%)	-33k (- 0.01%)	479,892k	479,987k
Parse Time	3.89s (± 0.45%)	3.88s (± 0.21%)	-0.01s (- 0.13%)	3.87s	3.89s
Bind Time	1.05s (± 0.56%)	1.05s (± 0.71%)	-0.00s (- 0.15%)	1.04s	1.06s
Check Time	18.88s (± 0.80%)	19.08s (± 0.87%)	+0.20s (+ 1.08%)	18.91s	19.31s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	23.82s (± 0.71%)	24.01s (± 0.72%)	+0.19s (+ 0.81%)	23.83s	24.24s
xstate - node (v14.15.1, x64)
Memory used	556,233k (± 0.01%)	556,313k (± 0.00%)	+81k (+ 0.01%)	556,265k	556,343k
Parse Time	5.16s (± 1.09%)	5.17s (± 0.61%)	+0.01s (+ 0.10%)	5.13s	5.20s
Bind Time	1.58s (± 0.74%)	1.59s (± 1.10%)	+0.01s (+ 0.45%)	1.57s	1.61s
Check Time	3.00s (± 0.50%)	3.00s (± 0.93%)	-0.01s (- 0.20%)	2.96s	3.03s
Emit Time	0.10s (± 0.08%)	0.10s (± 0.15%)	+0.00s (+ 0.13%)	0.10s	0.10s
Total Time	9.84s (± 0.56%)	9.85s (± 0.50%)	+0.01s (+ 0.12%)	9.78s	9.93s

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52189	6
Baseline	main	6

TSServer

Comparison Report - main..52189

Metric	main	52189	Delta	Best	Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,587ms (± 1.64%)	2,563ms (± 1.30%)	-24ms (- 0.94%)	2,523ms	2,602ms
Req 2 - geterr	5,383ms (± 1.19%)	5,435ms (± 2.44%)	+52ms (+ 0.97%)	5,322ms	5,673ms
Req 3 - references	372ms (± 1.09%)	367ms (± 3.21%)	-4ms (- 1.20%)	351ms	383ms
Req 4 - navto	317ms (±27.30%)	325ms (±25.87%)	+7ms (+ 2.32%)	281ms	496ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	265ms (±35.44%)	191ms (±60.88%)	🟩-74ms (-28.06%)	74ms	306ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,758ms (± 1.08%)	2,791ms (± 1.25%)	+33ms (+ 1.20%)	2,755ms	2,850ms
Req 2 - geterr	3,955ms (± 0.32%)	3,965ms (± 0.44%)	+11ms (+ 0.27%)	3,944ms	3,988ms
Req 3 - references	362ms (± 1.51%)	362ms (± 0.92%)	-1ms (- 0.17%)	357ms	366ms
Req 4 - navto	290ms (± 0.82%)	295ms (± 1.20%)	+5ms (+ 1.59%)	292ms	302ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	67ms (± 4.08%)	67ms (± 1.96%)	+0ms (+ 0.21%)	65ms	69ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,387ms (± 0.41%)	3,405ms (± 0.93%)	+18ms (+ 0.53%)	3,355ms	3,448ms
Req 2 - geterr	1,549ms (± 1.16%)	1,539ms (± 1.10%)	-10ms (- 0.64%)	1,523ms	1,564ms
Req 3 - references	101ms (± 4.11%)	103ms (± 4.88%)	+2ms (+ 2.09%)	96ms	107ms
Req 4 - navto	355ms (± 0.92%)	362ms (± 0.56%)	+6ms (+ 1.78%)	360ms	365ms
Req 5 - completionInfo count	3,154 (± 0.00%)	3,154 (± 0.00%)	0 ( 0.00%)	3,154	3,154
Req 5 - completionInfo	428ms (± 1.18%)	436ms (± 1.50%)	+8ms (+ 1.85%)	428ms	444ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,786ms (± 0.52%)	2,789ms (± 0.61%)	+3ms (+ 0.11%)	2,767ms	2,809ms
Req 2 - geterr	5,862ms (± 2.34%)	5,953ms (± 1.54%)	+91ms (+ 1.55%)	5,776ms	6,045ms
Req 3 - references	363ms (± 0.66%)	363ms (± 0.44%)	+0ms (+ 0.03%)	361ms	365ms
Req 4 - navto	391ms (±29.52%)	318ms (±27.97%)	🟩-73ms (-18.69%)	278ms	500ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	89ms (± 7.56%)	89ms (± 5.04%)	+0ms (+ 0.08%)	83ms	94ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,934ms (± 0.44%)	2,933ms (± 0.76%)	-0ms (- 0.01%)	2,905ms	2,966ms
Req 2 - geterr	4,326ms (± 0.48%)	4,290ms (± 0.52%)	-36ms (- 0.83%)	4,256ms	4,319ms
Req 3 - references	378ms (± 0.58%)	376ms (± 0.32%)	-2ms (- 0.44%)	374ms	378ms
Req 4 - navto	302ms (± 0.25%)	304ms (± 0.50%)	+2ms (+ 0.68%)	302ms	306ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	317ms (± 0.59%)	314ms (± 0.91%)	-3ms (- 0.87%)	312ms	320ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,757ms (± 0.59%)	3,765ms (± 0.24%)	+8ms (+ 0.21%)	3,749ms	3,775ms
Req 2 - geterr	1,448ms (± 0.78%)	1,459ms (± 0.94%)	+11ms (+ 0.75%)	1,445ms	1,477ms
Req 3 - references	110ms (± 2.17%)	108ms (± 3.60%)	-2ms (- 2.19%)	103ms	113ms
Req 4 - navto	348ms (± 1.58%)	341ms (± 1.77%)	-7ms (- 2.04%)	333ms	348ms
Req 5 - completionInfo count	3,154 (± 0.00%)	3,154 (± 0.00%)	0 ( 0.00%)	3,154	3,154
Req 5 - completionInfo	472ms (± 1.84%)	466ms (± 2.12%)	-6ms (- 1.36%)	454ms	478ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,877ms (± 0.34%)	2,740ms (± 8.37%)	🟩-136ms (- 4.74%)	2,441ms	2,910ms
Req 2 - geterr	6,112ms (± 0.42%)	5,827ms (± 8.21%)	🟩-285ms (- 4.66%)	5,198ms	6,177ms
Req 3 - references	379ms (± 0.56%)	359ms (± 8.06%)	🟩-20ms (- 5.28%)	321ms	381ms
Req 4 - navto	289ms (± 0.65%)	278ms (± 8.72%)	🟩-11ms (- 3.90%)	244ms	297ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	93ms (± 5.92%)	159ms (±71.25%)	🔻+66ms (+70.81%)	78ms	328ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,017ms (± 1.07%)	3,010ms (± 0.71%)	-7ms (- 0.23%)	2,987ms	3,048ms
Req 2 - geterr	4,585ms (± 0.57%)	4,570ms (± 0.38%)	-14ms (- 0.31%)	4,553ms	4,595ms
Req 3 - references	402ms (± 0.68%)	406ms (± 0.95%)	+4ms (+ 1.04%)	402ms	412ms
Req 4 - navto	306ms (± 0.91%)	307ms (± 1.50%)	+1ms (+ 0.45%)	300ms	312ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	82ms (± 8.67%)	83ms (± 7.47%)	+1ms (+ 0.94%)	77ms	91ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,869ms (± 0.89%)	3,873ms (± 0.52%)	+4ms (+ 0.09%)	3,845ms	3,895ms
Req 2 - geterr	1,465ms (± 0.94%)	1,452ms (± 0.37%)	-13ms (- 0.91%)	1,444ms	1,458ms
Req 3 - references	127ms (± 2.56%)	128ms (± 3.30%)	+1ms (+ 0.72%)	121ms	134ms
Req 4 - navto	395ms (± 0.72%)	393ms (± 0.96%)	-3ms (- 0.71%)	386ms	397ms
Req 5 - completionInfo count	3,154 (± 0.00%)	3,154 (± 0.00%)	0 ( 0.00%)	3,154	3,154
Req 5 - completionInfo	496ms (± 1.82%)	498ms (± 0.89%)	+2ms (+ 0.42%)	492ms	502ms

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52189	6
Baseline	main	6

Startup

Comparison Report - main..52189

Metric	main	52189	Delta	Best	Worst
tsc-startup - node (v16.17.1, x64)
Execution time	138.97ms (± 0.21%)	139.79ms (± 0.24%)	+0.82ms (+ 0.59%)	138.38ms	142.81ms
tsserver-startup - node (v16.17.1, x64)
Execution time	230.50ms (± 0.25%)	233.43ms (± 0.40%)	+2.93ms (+ 1.27%)	230.97ms	240.55ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	233.18ms (± 0.24%)	236.72ms (± 0.39%)	+3.53ms (+ 1.52%)	233.34ms	242.75ms
typescript-startup - node (v16.17.1, x64)
Execution time	215.36ms (± 0.22%)	216.70ms (± 0.29%)	+1.34ms (+ 0.62%)	214.61ms	221.49ms

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52189	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52189/merge:

Everything looks good!