Update DOM and baselines #52328
Merged
Update DOM and baselines #52328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
@typescript-bot pack this |
|
Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at c622a10. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at c622a10. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at c622a10. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at c622a10. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at c622a10. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at c622a10. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at c622a10. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at c622a10. You can monitor the build here. |
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
1 similar comment
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
|
Only removals I really saw were:
I don't know who will run into these. I expect some breakages around the more-specific constant values though. |
|
@DanielRosenwasser Here they are:Comparison Report - main..52328
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsbackstage/backstage
|
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
DanielRosenwasser
requested changes
Jan 20, 2023
|
Here are the DT failures so far (still waiting on the fourth shard to finish): From literal types:
deleted types
Where are the cut/copy/paste regressions happening? |
|
codemirror's types special-cased DocumentAndElementEventHandlersMap, which is no longer needed. |
|
@DanielRosenwasser the latest commit fixes the type of cut/copy/paste events (but does not move them back into a separate type; I think moving them with the other events was a good thing). |
|
@typescript-bot pack this |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 86e0680. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 86e0680. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 86e0680. You can monitor the build here. Update: The results are in! |
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
1 similar comment
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
|
Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
webxr has breaks due to every property using numeric literal types, and |
|
@DanielRosenwasser Here they are:Comparison Report - main..52328
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
webxr is a shim for exactly the types that are now literal, so it's expected. We'll need to update the shim to match 5.0 types. I noticed overnight that fhir also OOMed on the nightly. Neither blessed nor fhir are AWS dependents, but fhir has about 4.5 MB of source and blessed 100K + depends on node. That might be enough; our memory usage has definitely increased in 5.0. Edit: Turns out blessed succeeded on retry. It's an unfortunate artifact of our parallel tests. |
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsbackstage/backstageThat is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder
|
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Everything looks good! |
DanielRosenwasser
approved these changes
Jan 21, 2023
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 21, 2023
Some event handlers got moved out of their custom type and into GlobalEventHandlersEventMap. This simplifies Editor.on/off overloads. The new code won't succeed until tomorrow, but the test should pass both before and after. See microsoft/TypeScript#52328
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 21, 2023
The types that webxr shims are now the precise literals instead of `number`. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
|
If DT/RWC results are indicative, it'll be a big change for a small proportion of people. |
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 21, 2023
The types that the DOM monkeypatch shims are now the precise literals instead of number. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 21, 2023
The type of `FontFace.display` is now a union of allowed literals instead of `string`. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 23, 2023
The types that the DOM monkeypatch shims are now the precise literals instead of number. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 23, 2023
The type of `FontFace.display` is now a union of allowed literals instead of `string`. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 23, 2023
* Fix codemirror types for TS 5.0 beta Some event handlers got moved out of their custom type and into GlobalEventHandlersEventMap. This simplifies Editor.on/off overloads. The new code won't succeed until tomorrow, but the test should pass both before and after. See microsoft/TypeScript#52328 * also update minimum required TS version * Update react-codemirror minimum TS version * Fix formatting lint
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 23, 2023
* Fix webxr types for TS 5.0 beta The types that webxr shims are now the precise literals instead of `number`. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328 * Update minimum TS version for three * Update minimum TS version of other dependents * Remove OVR_multiview2 instead of updating it then bump required TS version to 4.4 not 5.0
bicknellr
added a commit
to bicknellr/web-component-analyzer
that referenced
this pull request
Apr 5, 2023
bicknellr
added a commit
to bicknellr/web-component-analyzer
that referenced
this pull request
Apr 5, 2023
rictic
pushed a commit
to runem/web-component-analyzer
that referenced
this pull request
Apr 6, 2023
* Install `typescript@~5.0`. * Add `5.0` to the set of tested TypeScript versions. * Support for TypeScript 4.8+ decorator AST changes (cherry-pick of #249) * Fall back to `isTypeAssertion` for `isTypeAssertionExpression` (introduced in `4.0.2`). (cherry-pick c69e804) * Fix building with TypeScript before `isTypeAssertionExpression` existed. * Remove indentation from JSDoc descriptions in tests. (...) Somewhere between 3.8 and 5.0, indentation for JSDoc description lines starting with whitespace was fixed to not include the additional space immediately after the line's leading `*`. The indentiation in this test causes it to fail in at least TS 5.0, so I'm removing it rather than trying to track down exactly when this change was made and then propagating the version number to the test. * `DocumentAndElementEventHandlers` was removed in microsoft/TypeScript#52328 (0c2fa39). * Revert back to `lockfileVersion: 1` by installing new deps with npm v6 instead of v9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51361