Skip to content

Fixed an issue with top function type being callable with no arguments #52387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fixed an issue with top function type being callable with no arguments #52387

merged 2 commits into from
Mar 1, 2023

Conversation

Andarist
Copy link
Contributor

fixes #48840
reverts a part of https://github.com/microsoft/TypeScript/pull/35438/files (the tests added there still pass)

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 24, 2023
@Andarist
Copy link
Contributor Author

This has been labeled as "For Uncommitted Bug" but the associated issue is labeled with "Bug". This perhaps indicates a bug in the bot.

@fatcerberus
Copy link

I always thought “For Uncommitted Bug” was literal: the issue has a Bug label but not a Committed label (note: not the same thing as “commit” in git terminology)

@Andarist
Copy link
Contributor Author

Hm, i think it also gets For Uncommitted Bug if the issue has no label - and that’s what i assumed to be the main differentiator here. U might be right though - maybe it has to be assigned to a milestone (specific TS version or Backlog) for this label to not be added to the PR

@jakebailey
Copy link
Member

My understanding is that this particular label is mainly about whether or not it has been assigned to a milestone.

@sandersn
Copy link
Member

sandersn commented Feb 1, 2023

@DanielRosenwasser or @jakebailey can you figure out if #48840 should be moved into the backlog or a specific milestone? I know the bug came up in the recent design meeting, but I don't think we decided whether the bug was worth fixing.

@jakebailey
Copy link
Member

I think I'd like to see @ahejlsberg take a look at this in context of #52282 too, lest we end up with a surprising relation behavior.

@jakebailey jakebailey mentioned this pull request Feb 6, 2023
Merged
@sandersn sandersn requested a review from ahejlsberg February 6, 2023 23:59
@jakebailey
Copy link
Member

I would merge main since this predates the other function PRs but otherwise LGTM given we check the usual suspects.

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 1, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 1, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 0f8d091. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 1, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0f8d091. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 1, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 1, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52387/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52387
Metric main 52387 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,738k (± 0.02%) 359,802k (± 0.01%) ~ 359,761k 359,852k p=0.128 n=6
Parse Time 3.51s (± 0.93%) 3.50s (± 0.47%) ~ 3.47s 3.51s p=0.572 n=6
Bind Time 1.13s (± 0.46%) 1.13s (± 0.00%) ~ 1.13s 1.13s p=0.174 n=6
Check Time 8.69s (± 0.38%) 8.64s (± 0.64%) ~ 8.59s 8.71s p=0.170 n=6
Emit Time 7.45s (± 0.36%) 7.43s (± 0.78%) ~ 7.38s 7.54s p=0.170 n=6
Total Time 20.78s (± 0.36%) 20.70s (± 0.48%) ~ 20.58s 20.86s p=0.093 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,469k (± 1.57%) 192,404k (± 1.58%) ~ 189,529k 195,242k p=0.471 n=6
Parse Time 1.49s (± 0.69%) 1.47s (± 0.71%) ~ 1.46s 1.49s p=0.098 n=6
Bind Time 0.77s (± 0.53%) 0.76s (± 1.07%) -0.01s (- 1.08%) 0.76s 0.78s p=0.038 n=6
Check Time 9.35s (± 0.85%) 9.28s (± 0.69%) ~ 9.19s 9.36s p=0.124 n=6
Emit Time 2.72s (± 0.49%) 2.73s (± 0.76%) ~ 2.70s 2.76s p=0.934 n=6
Total Time 14.33s (± 0.60%) 14.24s (± 0.33%) ~ 14.19s 14.32s p=0.104 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,859k (± 0.01%) 343,861k (± 0.01%) ~ 343,826k 343,933k p=1.000 n=6
Parse Time 2.64s (± 1.54%) 2.63s (± 1.04%) ~ 2.60s 2.67s p=1.000 n=6
Bind Time 1.01s (± 0.40%) 1.01s (± 0.51%) ~ 1.00s 1.01s p=0.114 n=6
Check Time 7.04s (± 0.54%) 7.02s (± 0.57%) ~ 6.96s 7.07s p=0.748 n=6
Emit Time 4.24s (± 0.80%) 4.24s (± 0.85%) ~ 4.20s 4.30s p=0.687 n=6
Total Time 14.93s (± 0.51%) 14.90s (± 0.44%) ~ 14.81s 15.01s p=0.687 n=6
TFS - node (v18.10.0, x64)
Memory used 299,885k (± 0.01%) 299,886k (± 0.01%) ~ 299,854k 299,942k p=0.689 n=6
Parse Time 2.04s (± 1.37%) 2.04s (± 1.19%) ~ 2.00s 2.07s p=0.870 n=6
Bind Time 1.14s (± 0.36%) 1.13s (± 0.46%) ~ 1.13s 1.14s p=0.112 n=6
Check Time 6.53s (± 0.46%) 6.52s (± 0.58%) ~ 6.47s 6.57s p=0.628 n=6
Emit Time 3.86s (± 1.11%) 3.83s (± 0.88%) ~ 3.80s 3.89s p=0.225 n=6
Total Time 13.57s (± 0.47%) 13.53s (± 0.63%) ~ 13.45s 13.64s p=0.261 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,404k (± 0.00%) 476,424k (± 0.00%) ~ 476,391k 476,449k p=0.173 n=6
Parse Time 3.13s (± 0.48%) 3.12s (± 0.71%) ~ 3.09s 3.15s p=0.188 n=6
Bind Time 0.92s (± 1.15%) 0.91s (± 0.57%) ~ 0.90s 0.91s p=0.142 n=6
Check Time 17.07s (± 0.49%) 17.03s (± 0.46%) ~ 16.96s 17.15s p=0.520 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.12s (± 0.37%) 21.06s (± 0.37%) ~ 20.99s 21.18s p=0.376 n=6
xstate - node (v18.10.0, x64)
Memory used 548,111k (± 0.02%) 548,027k (± 0.02%) ~ 547,875k 548,187k p=0.298 n=6
Parse Time 4.08s (± 0.53%) 4.07s (± 0.65%) ~ 4.04s 4.11s p=0.687 n=6
Bind Time 1.67s (± 0.38%) 1.68s (± 0.87%) ~ 1.66s 1.70s p=0.156 n=6
Check Time 2.75s (± 1.07%) 2.76s (± 1.00%) ~ 2.72s 2.79s p=0.687 n=6
Emit Time 0.08s (± 4.99%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=0.405 n=6
Total Time 8.59s (± 0.51%) 8.60s (± 0.47%) ~ 8.52s 8.63s p=0.334 n=6
Angular - node (v16.17.1, x64)
Memory used 359,079k (± 0.00%) 359,085k (± 0.01%) ~ 359,051k 359,178k p=0.423 n=6
Parse Time 3.73s (± 0.31%) 3.73s (± 0.50%) ~ 3.71s 3.76s p=0.287 n=6
Bind Time 1.20s (± 0.34%) 1.19s (± 0.68%) ~ 1.18s 1.20s p=0.248 n=6
Check Time 9.46s (± 0.25%) 9.46s (± 0.22%) ~ 9.43s 9.49s p=0.935 n=6
Emit Time 7.90s (± 0.64%) 7.93s (± 0.67%) ~ 7.87s 8.03s p=0.295 n=6
Total Time 22.28s (± 0.17%) 22.31s (± 0.31%) ~ 22.24s 22.44s p=0.747 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,371k (± 0.92%) 191,319k (± 0.03%) ~ 191,246k 191,418k p=0.471 n=6
Parse Time 1.58s (± 0.84%) 1.57s (± 0.52%) ~ 1.56s 1.58s p=0.198 n=6
Bind Time 0.83s (± 0.62%) 0.82s (± 0.00%) -0.01s (- 0.81%) 0.82s 0.82s p=0.025 n=6
Check Time 10.07s (± 0.70%) 10.10s (± 0.89%) ~ 9.98s 10.21s p=0.470 n=6
Emit Time 2.99s (± 0.65%) 3.00s (± 0.83%) ~ 2.97s 3.03s p=0.517 n=6
Total Time 15.47s (± 0.53%) 15.50s (± 0.75%) ~ 15.34s 15.65s p=0.628 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,125k (± 0.01%) 343,140k (± 0.00%) ~ 343,116k 343,163k p=0.229 n=6
Parse Time 2.80s (± 0.57%) 2.79s (± 0.23%) ~ 2.78s 2.80s p=0.179 n=6
Bind Time 1.08s (± 0.48%) 1.08s (± 0.97%) ~ 1.06s 1.09s p=0.142 n=6
Check Time 7.70s (± 0.28%) 7.68s (± 0.49%) ~ 7.63s 7.72s p=0.573 n=6
Emit Time 4.43s (± 0.55%) 4.41s (± 0.97%) ~ 4.37s 4.49s p=0.196 n=6
Total Time 16.02s (± 0.20%) 15.96s (± 0.39%) ~ 15.90s 16.07s p=0.092 n=6
TFS - node (v16.17.1, x64)
Memory used 299,263k (± 0.00%) 299,246k (± 0.01%) ~ 299,215k 299,292k p=0.128 n=6
Parse Time 2.16s (± 0.68%) 2.17s (± 0.85%) ~ 2.15s 2.19s p=0.367 n=6
Bind Time 1.24s (± 0.67%) 1.24s (± 1.35%) ~ 1.21s 1.26s p=0.612 n=6
Check Time 7.20s (± 0.43%) 7.18s (± 0.35%) ~ 7.15s 7.21s p=0.333 n=6
Emit Time 4.33s (± 0.54%) 4.31s (± 0.46%) ~ 4.29s 4.34s p=0.413 n=6
Total Time 14.93s (± 0.21%) 14.90s (± 0.17%) ~ 14.86s 14.93s p=0.127 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,661k (± 0.00%) 475,648k (± 0.00%) ~ 475,622k 475,668k p=0.229 n=6
Parse Time 3.30s (± 0.38%) 3.29s (± 0.64%) ~ 3.27s 3.33s p=0.157 n=6
Bind Time 0.96s (± 0.78%) 0.96s (± 0.00%) ~ 0.96s 0.96s p=0.598 n=6
Check Time 18.19s (± 0.60%) 18.05s (± 0.39%) -0.14s (- 0.74%) 17.99s 18.15s p=0.044 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.45s (± 0.52%) 22.30s (± 0.38%) ~ 22.23s 22.42s p=0.054 n=6
xstate - node (v16.17.1, x64)
Memory used 545,758k (± 0.03%) 545,727k (± 0.01%) ~ 545,638k 545,823k p=0.873 n=6
Parse Time 4.29s (± 0.42%) 4.28s (± 0.58%) ~ 4.25s 4.31s p=0.421 n=6
Bind Time 1.77s (± 0.58%) 1.76s (± 0.36%) ~ 1.75s 1.77s p=0.293 n=6
Check Time 2.98s (± 0.69%) 2.99s (± 0.46%) ~ 2.97s 3.01s p=0.454 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.13s (± 0.38%) 9.11s (± 0.39%) ~ 9.08s 9.16s p=0.333 n=6
Angular - node (v14.15.1, x64)
Memory used 352,821k (± 0.00%) 352,815k (± 0.00%) ~ 352,786k 352,829k p=0.936 n=6
Parse Time 3.73s (± 0.81%) 3.69s (± 0.57%) ~ 3.66s 3.71s p=0.064 n=6
Bind Time 1.25s (± 0.44%) 1.24s (± 0.33%) ~ 1.24s 1.25s p=0.282 n=6
Check Time 9.76s (± 0.57%) 9.71s (± 0.59%) ~ 9.64s 9.78s p=0.195 n=6
Emit Time 8.39s (± 1.06%) 8.38s (± 0.66%) ~ 8.29s 8.46s p=0.936 n=6
Total Time 23.13s (± 0.24%) 23.01s (± 0.20%) -0.12s (- 0.50%) 22.93s 23.07s p=0.010 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,539k (± 0.02%) 186,555k (± 0.01%) ~ 186,532k 186,571k p=0.378 n=6
Parse Time 1.58s (± 0.33%) 1.56s (± 0.48%) -0.02s (- 0.95%) 1.55s 1.57s p=0.010 n=6
Bind Time 0.85s (± 0.96%) 0.84s (± 0.00%) ~ 0.84s 0.84s p=0.073 n=6
Check Time 10.20s (± 0.63%) 10.21s (± 0.58%) ~ 10.11s 10.27s p=1.000 n=6
Emit Time 3.13s (± 0.53%) 3.12s (± 0.71%) ~ 3.09s 3.15s p=0.682 n=6
Total Time 15.75s (± 0.50%) 15.72s (± 0.43%) ~ 15.63s 15.83s p=0.378 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,119k (± 0.00%) 338,145k (± 0.01%) ~ 338,103k 338,186k p=0.065 n=6
Parse Time 2.89s (± 0.56%) 2.88s (± 0.61%) ~ 2.86s 2.90s p=0.104 n=6
Bind Time 1.10s (± 0.74%) 1.10s (± 0.37%) ~ 1.09s 1.10s p=0.206 n=6
Check Time 8.13s (± 0.76%) 8.07s (± 0.30%) ~ 8.04s 8.10s p=0.092 n=6
Emit Time 4.70s (± 1.05%) 4.67s (± 0.57%) ~ 4.64s 4.72s p=0.421 n=6
Total Time 16.83s (± 0.67%) 16.71s (± 0.31%) ~ 16.67s 16.81s p=0.054 n=6
TFS - node (v14.15.1, x64)
Memory used 294,285k (± 0.00%) 294,270k (± 0.01%) ~ 294,244k 294,296k p=0.093 n=6
Parse Time 2.38s (± 0.51%) 2.37s (± 0.79%) ~ 2.35s 2.39s p=0.164 n=6
Bind Time 1.07s (± 0.70%) 1.06s (± 0.49%) ~ 1.06s 1.07s p=0.069 n=6
Check Time 7.49s (± 0.36%) 7.45s (± 0.61%) ~ 7.39s 7.51s p=0.106 n=6
Emit Time 4.31s (± 0.68%) 4.26s (± 0.69%) -0.05s (- 1.16%) 4.21s 4.30s p=0.019 n=6
Total Time 15.26s (± 0.18%) 15.14s (± 0.39%) -0.12s (- 0.80%) 15.06s 15.21s p=0.005 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,334k (± 0.00%) 471,337k (± 0.01%) ~ 471,279k 471,386k p=0.748 n=6
Parse Time 3.46s (± 0.38%) 3.44s (± 0.51%) ~ 3.43s 3.47s p=0.118 n=6
Bind Time 1.01s (± 0.51%) 1.00s (± 0.81%) ~ 0.99s 1.01s p=0.523 n=6
Check Time 19.00s (± 0.62%) 18.97s (± 1.01%) ~ 18.82s 19.31s p=0.521 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.47s (± 0.50%) 23.42s (± 0.85%) ~ 23.26s 23.78s p=0.332 n=6
xstate - node (v14.15.1, x64)
Memory used 534,383k (± 0.00%) 534,393k (± 0.00%) ~ 534,366k 534,422k p=0.809 n=6
Parse Time 4.50s (± 1.56%) 4.43s (± 1.06%) ~ 4.39s 4.52s p=0.076 n=6
Bind Time 1.73s (± 4.31%) 1.76s (± 2.88%) ~ 1.66s 1.79s p=0.744 n=6
Check Time 3.14s (± 0.44%) 3.13s (± 0.62%) ~ 3.10s 3.15s p=0.869 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) ~ 0.10s 0.10s p=1.000 n=6
Total Time 9.48s (± 0.50%) 9.43s (± 0.37%) ~ 9.37s 9.46s p=0.147 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52387 6
Baseline main 6

TSServer

Comparison Report - main..52387
Metric main 52387 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,364ms (± 0.45%) 2,366ms (± 1.07%) ~ 2,342ms 2,407ms p=0.809 n=6
Req 2 - geterr 5,312ms (± 0.49%) 5,293ms (± 0.79%) ~ 5,239ms 5,346ms p=0.378 n=6
Req 3 - references 338ms (± 0.76%) 336ms (± 0.94%) ~ 333ms 342ms p=0.220 n=6
Req 4 - navto 285ms (± 0.36%) 285ms (± 1.01%) ~ 279ms 287ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 75ms (± 4.81%) 79ms (± 5.38%) ~ 77ms 88ms p=0.188 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,531ms (± 0.81%) 2,516ms (± 1.33%) ~ 2,463ms 2,561ms p=0.378 n=6
Req 2 - geterr 3,996ms (± 0.47%) 3,994ms (± 0.67%) ~ 3,971ms 4,045ms p=0.575 n=6
Req 3 - references 353ms (± 0.71%) 353ms (± 0.64%) ~ 351ms 357ms p=0.935 n=6
Req 4 - navto 293ms (± 0.66%) 293ms (± 0.36%) ~ 291ms 294ms p=0.742 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 0.60%) 68ms (± 0.93%) ~ 67ms 69ms p=0.673 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,190ms (± 0.48%) 3,171ms (± 0.73%) ~ 3,139ms 3,199ms p=0.228 n=6
Req 2 - geterr 1,607ms (± 0.66%) 1,600ms (± 0.61%) ~ 1,592ms 1,618ms p=0.297 n=6
Req 3 - references 104ms (± 1.44%) 104ms (± 1.42%) ~ 102ms 106ms p=0.615 n=6
Req 4 - navto 360ms (± 0.62%) 358ms (± 0.49%) ~ 356ms 361ms p=0.128 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 432ms (± 0.59%) 426ms (± 1.41%) ~ 421ms 438ms p=0.065 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,491ms (± 1.58%) 2,491ms (± 1.63%) ~ 2,450ms 2,550ms p=1.000 n=6
Req 2 - geterr 5,747ms (± 1.04%) 5,716ms (± 0.48%) ~ 5,673ms 5,754ms p=0.298 n=6
Req 3 - references 349ms (± 0.54%) 348ms (± 0.39%) ~ 346ms 350ms p=0.510 n=6
Req 4 - navto 281ms (± 0.52%) 280ms (± 0.49%) ~ 278ms 282ms p=0.118 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 0.49%) 84ms (± 0.89%) ~ 83ms 85ms p=0.389 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,688ms (± 0.60%) 2,678ms (± 0.44%) ~ 2,665ms 2,693ms p=0.226 n=6
Req 2 - geterr 4,356ms (± 0.47%) 4,354ms (± 0.59%) ~ 4,306ms 4,375ms p=1.000 n=6
Req 3 - references 365ms (± 0.81%) 364ms (± 1.07%) ~ 359ms 369ms p=0.809 n=6
Req 4 - navto 289ms (± 0.48%) 286ms (± 1.12%) ~ 283ms 291ms p=0.250 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 74ms (± 1.14%) 73ms (± 0.70%) ~ 73ms 74ms p=0.533 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,339ms (± 0.50%) 3,326ms (± 0.29%) ~ 3,316ms 3,341ms p=0.109 n=6
Req 2 - geterr 1,777ms (± 1.35%) 1,761ms (± 1.37%) ~ 1,743ms 1,808ms p=0.229 n=6
Req 3 - references 112ms (± 2.28%) 111ms (± 1.76%) ~ 109ms 114ms p=0.625 n=6
Req 4 - navto 344ms (± 1.32%) 345ms (± 1.45%) ~ 338ms 352ms p=0.936 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 435ms (± 0.92%) 433ms (± 0.93%) ~ 426ms 437ms p=0.568 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,570ms (± 0.64%) 2,570ms (± 0.56%) ~ 2,550ms 2,584ms p=0.873 n=6
Req 2 - geterr 6,038ms (± 0.70%) 6,022ms (± 0.83%) ~ 5,980ms 6,108ms p=0.471 n=6
Req 3 - references 368ms (± 0.97%) 364ms (± 0.75%) ~ 360ms 367ms p=0.164 n=6
Req 4 - navto 277ms (± 1.26%) 274ms (± 0.43%) -3ms (- 1.08%) 273ms 276ms p=0.032 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 99ms (± 1.87%) 100ms (± 1.87%) ~ 96ms 101ms p=0.932 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,808ms (± 0.47%) 2,812ms (± 1.01%) ~ 2,779ms 2,850ms p=0.873 n=6
Req 2 - geterr 4,450ms (± 1.92%) 4,503ms (± 2.65%) ~ 4,382ms 4,620ms p=1.000 n=6
Req 3 - references 395ms (± 6.01%) 379ms (± 0.59%) ~ 375ms 381ms p=0.173 n=6
Req 4 - navto 293ms (± 1.71%) 293ms (± 1.10%) ~ 288ms 297ms p=1.000 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 91ms (± 9.19%) 92ms (±11.68%) ~ 82ms 102ms p=0.746 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,648ms (± 0.32%) 3,645ms (± 0.66%) ~ 3,609ms 3,671ms p=1.000 n=6
Req 2 - geterr 1,845ms (± 1.25%) 1,832ms (± 1.35%) ~ 1,803ms 1,871ms p=0.298 n=6
Req 3 - references 129ms (± 2.79%) 128ms (± 2.90%) ~ 124ms 134ms p=0.806 n=6
Req 4 - navto 373ms (± 1.02%) 377ms (± 2.22%) ~ 372ms 394ms p=0.683 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 449ms (± 2.91%) 456ms (± 1.86%) ~ 448ms 472ms p=0.297 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52387 6
Baseline main 6

Startup

Comparison Report - main..52387
Metric main 52387 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 143.18ms (± 0.23%) 142.38ms (± 0.20%) -0.80ms (- 0.56%) 141.67ms 147.94ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 227.79ms (± 0.17%) 226.82ms (± 0.18%) -0.97ms (- 0.43%) 225.84ms 233.97ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 229.50ms (± 0.17%) 228.52ms (± 0.15%) -0.99ms (- 0.43%) 227.66ms 233.43ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 210.24ms (± 0.20%) 209.38ms (± 0.21%) -0.86ms (- 0.41%) 208.55ms 220.47ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52387 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52387/merge:

Everything looks good!

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 1, 2023
@Andarist
Copy link
Contributor Author

Andarist commented Mar 1, 2023

I would merge main since this predates the other function PRs but otherwise LGTM given we check the usual suspects.

Synced this with main 👍

@jakebailey jakebailey merged commit 02885b1 into microsoft:main Mar 1, 2023
@Andarist Andarist deleted the fix/top-function-type-not-callable branch March 1, 2023 17:40
@Andarist Andarist mentioned this pull request Mar 3, 2023
Closed
@Andarist Andarist mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@jakebailey jakebailey

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression causes Function top-type to be callable with no arguments
6 participants
@Andarist @fatcerberus @jakebailey @sandersn @typescript-bot @DanielRosenwasser