fix(52444): "... is a type and must be imported using a type-only import ..." should have a quick fix #52565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
approved these changes
Feb 3, 2023
andrewbranch
approved these changes
Feb 8, 2023
a-tarasyuk
requested review from
DanielRosenwasser
and removed request for
rbuckton
|
Uh oh, was this supposed to get into 5.0 to pair with the new options? |
|
Yeah 😕 |
|
@DanielRosenwasser can we cherry-pick this to 5.0? 😄 (once the conflicts are fixed) |
|
Thanks for the prompt merge from main! |
|
@typescript-bot cherry-pick this to release-5.0 |
|
Heya @jakebailey, I've started to run the task to cherry-pick this into |
|
Making it for discussion, but mainly so I know if I have to do it manually. |
|
Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.0 manually. |
|
Dangit |
jakebailey
pushed a commit
to jakebailey/TypeScript
that referenced
this pull request
Mar 1, 2023
…ort ..." should have a quick fix (microsoft#52565)
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 2, 2023
Co-authored-by: Oleksandr T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52444