Improve handling of corner cases in narrowTypeByInstanceof
#52592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 1337f28. You can monitor the build here. Update: The results are in! |
|
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 1337f28. You can monitor the build here. |
|
Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 1337f28. You can monitor the build here. Update: The results are in! |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 1337f28. You can monitor the build here. |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 1337f28. You can monitor the build here. |
|
@ahejlsberg Here are the results of running the user test suite comparing Something interesting changed - please have a look. Details
|
|
@ahejlsberg Here are some more interesting changes from running the user test suite Details
|
|
Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
@ahejlsberg Here they are:Comparison Report - main..52592
System
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@ahejlsberg Here are the results of running the top-repos suite comparing Everything looks good! |
|
@typescript-bot user test this inline |
|
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 13bd783. You can monitor the build here. Update: The results are in! |
|
@ahejlsberg Here are the results of running the user test suite comparing Everything looks good! |
|
@typescript-bot run dt |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 2577f94. You can monitor the build here. |
|
Tests are clean and performance unaffected. This one is ready to merge. |
jakebailey
approved these changes
Feb 6, 2023
| } | ||
|
|
||
| function foo(x: A | B | C, A: AA, B: BB, AB: AA | BB) { | ||
| if (x instanceof A) { |
There was a problem hiding this comment.
I was really confused while reading this test because I was trying to understand how we weren't getting an error for trying to instanceof an interface, before I realized that A was being passed as a parameter and shadowed the outer declaration. If there's a different way to construct this that avoids that, that might be helpful for future reading / baseline reading.
There was a problem hiding this comment.
That is actually intended since this is precisely the "shadowing" that happens when you declare a class, i.e. for class Foo {} you end up with a value Foo (the constructor function) and a type Foo (the instance type). There isn't really any shadowing going on because the two namespaces are separate and determined by context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52571.