Skip to content

Avoid using temporary array for getExpandedParameters #52834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Avoid using temporary array for getExpandedParameters #52834

wants to merge 3 commits into from

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Feb 18, 2023 •
edited
Loading

It was noted during review of #49627 that this function seemingly always returns an array with one item.

It looks like that in the checker, we always pass skipUnionExpanding=true. Only in services for signature help do we want expanding (for just a couple tests).

It seems wasteful to allocate an array and then throw it away to serializing any signature. Let's see if it helps to avoid it.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 18, 2023
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 204d9b2. You can monitor the build here.

@jakebailey
Copy link
Member Author

The big let/const PR went in, so I cancelled the above and will restart it again later once that has settled, just in case the bot compares the wrong things.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 18, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 17e2471. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52834
Metric main 52834 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,387k (± 0.01%) 359,344k (± 0.01%) ~ 359,319k 359,377k p=0.065 n=6
Parse Time 3.50s (± 0.86%) 3.48s (± 0.50%) ~ 3.46s 3.51s p=0.416 n=6
Bind Time 1.17s (± 0.44%) 1.18s (± 0.83%) ~ 1.17s 1.19s p=0.417 n=6
Check Time 8.77s (± 0.62%) 8.72s (± 0.48%) ~ 8.65s 8.77s p=0.125 n=6
Emit Time 7.61s (± 0.92%) 7.59s (± 0.60%) ~ 7.56s 7.68s p=0.627 n=6
Total Time 21.05s (± 0.62%) 20.97s (± 0.40%) ~ 20.87s 21.12s p=0.229 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 190,827k (± 1.19%) 189,936k (± 0.02%) ~ 189,892k 189,973k p=0.748 n=6
Parse Time 1.48s (± 0.66%) 1.48s (± 0.70%) ~ 1.47s 1.50s p=0.933 n=6
Bind Time 0.79s (± 0.52%) 0.80s (± 0.65%) ~ 0.79s 0.80s p=0.112 n=6
Check Time 9.42s (± 0.88%) 9.41s (± 0.35%) ~ 9.37s 9.45s p=0.748 n=6
Emit Time 2.82s (± 1.62%) 2.81s (± 1.00%) ~ 2.78s 2.85s p=0.810 n=6
Total Time 14.51s (± 0.77%) 14.51s (± 0.21%) ~ 14.47s 14.56s p=0.747 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,979k (± 0.01%) 344,030k (± 0.02%) ~ 343,956k 344,101k p=0.128 n=6
Parse Time 2.62s (± 1.17%) 2.61s (± 0.99%) ~ 2.57s 2.64s p=0.571 n=6
Bind Time 1.03s (± 0.81%) 1.04s (± 0.86%) ~ 1.03s 1.05s p=0.437 n=6
Check Time 7.12s (± 0.44%) 7.09s (± 0.61%) ~ 7.05s 7.16s p=0.227 n=6
Emit Time 4.33s (± 0.35%) 4.31s (± 0.78%) ~ 4.27s 4.37s p=0.225 n=6
Total Time 15.10s (± 0.30%) 15.05s (± 0.46%) ~ 14.99s 15.15s p=0.148 n=6
TFS - node (v18.10.0, x64)
Memory used 300,028k (± 0.00%) 300,038k (± 0.00%) ~ 300,017k 300,061k p=0.261 n=6
Parse Time 2.07s (± 1.48%) 2.05s (± 1.52%) ~ 2.01s 2.09s p=0.224 n=6
Bind Time 1.17s (± 0.44%) 1.17s (± 0.47%) -0.01s (- 0.71%) 1.16s 1.17s p=0.038 n=6
Check Time 6.57s (± 0.30%) 6.54s (± 0.44%) -0.04s (- 0.56%) 6.50s 6.58s p=0.042 n=6
Emit Time 3.93s (± 0.66%) 3.91s (± 0.91%) ~ 3.86s 3.95s p=0.520 n=6
Total Time 13.75s (± 0.50%) 13.66s (± 0.38%) -0.08s (- 0.62%) 13.60s 13.73s p=0.037 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,411k (± 0.01%) 476,407k (± 0.01%) ~ 476,347k 476,456k p=0.936 n=6
Parse Time 3.15s (± 1.09%) 3.15s (± 0.40%) ~ 3.13s 3.16s p=0.935 n=6
Bind Time 0.97s (± 0.42%) 0.97s (± 0.53%) ~ 0.96s 0.97s p=0.595 n=6
Check Time 17.18s (± 0.32%) 17.18s (± 0.47%) ~ 17.10s 17.29s p=0.748 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.30s (± 0.21%) 21.30s (± 0.37%) ~ 21.23s 21.41s p=0.809 n=6
xstate - node (v18.10.0, x64)
Memory used 548,608k (± 0.03%) 548,629k (± 0.04%) ~ 548,487k 548,933k p=0.936 n=6
Parse Time 4.06s (± 0.37%) 4.09s (± 0.78%) +0.04s (+ 0.90%) 4.06s 4.15s p=0.020 n=6
Bind Time 1.72s (± 1.14%) 1.72s (± 0.95%) ~ 1.70s 1.74s p=1.000 n=6
Check Time 2.81s (± 0.70%) 2.82s (± 0.52%) ~ 2.80s 2.84s p=0.465 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 6.19%) ~ 0.08s 0.09s p=0.176 n=6
Total Time 8.67s (± 0.33%) 8.73s (± 0.46%) +0.06s (+ 0.63%) 8.69s 8.80s p=0.025 n=6
Angular - node (v16.17.1, x64)
Memory used 358,760k (± 0.01%) 358,772k (± 0.01%) ~ 358,729k 358,803k p=0.471 n=6
Parse Time 3.72s (± 0.63%) 3.71s (± 0.37%) ~ 3.70s 3.73s p=0.934 n=6
Bind Time 1.22s (± 0.42%) 1.22s (± 0.68%) ~ 1.22s 1.24s p=0.923 n=6
Check Time 9.54s (± 0.49%) 9.51s (± 0.46%) ~ 9.48s 9.59s p=0.373 n=6
Emit Time 8.12s (± 1.35%) 8.07s (± 0.49%) ~ 8.00s 8.11s p=0.810 n=6
Total Time 22.60s (± 0.48%) 22.52s (± 0.17%) ~ 22.47s 22.57s p=0.230 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,518k (± 0.02%) 191,510k (± 0.04%) ~ 191,451k 191,657k p=0.471 n=6
Parse Time 1.57s (± 0.67%) 1.57s (± 0.48%) ~ 1.56s 1.58s p=0.273 n=6
Bind Time 0.84s (± 0.00%) 0.84s (± 0.65%) ~ 0.84s 0.85s p=0.071 n=6
Check Time 10.13s (± 0.44%) 10.16s (± 0.36%) ~ 10.12s 10.20s p=0.198 n=6
Emit Time 3.08s (± 0.96%) 3.06s (± 0.82%) ~ 3.03s 3.09s p=0.685 n=6
Total Time 15.60s (± 0.34%) 15.64s (± 0.27%) ~ 15.57s 15.69s p=0.261 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,256k (± 0.00%) 343,251k (± 0.00%) ~ 343,236k 343,270k p=0.630 n=6
Parse Time 2.80s (± 0.52%) 2.81s (± 0.55%) ~ 2.79s 2.83s p=0.415 n=6
Bind Time 1.11s (± 0.68%) 1.11s (± 0.93%) ~ 1.10s 1.13s p=0.931 n=6
Check Time 7.77s (± 0.22%) 7.77s (± 0.43%) ~ 7.72s 7.81s p=0.744 n=6
Emit Time 4.50s (± 0.57%) 4.50s (± 0.37%) ~ 4.48s 4.52s p=1.000 n=6
Total Time 16.18s (± 0.17%) 16.19s (± 0.28%) ~ 16.14s 16.27s p=1.000 n=6
TFS - node (v16.17.1, x64)
Memory used 299,386k (± 0.01%) 299,395k (± 0.01%) ~ 299,369k 299,412k p=0.377 n=6
Parse Time 2.19s (± 0.53%) 2.19s (± 0.67%) ~ 2.18s 2.22s p=0.666 n=6
Bind Time 1.26s (± 0.65%) 1.26s (± 0.60%) ~ 1.25s 1.27s p=0.729 n=6
Check Time 7.21s (± 0.35%) 7.23s (± 0.71%) ~ 7.14s 7.29s p=0.418 n=6
Emit Time 4.22s (± 0.56%) 4.25s (± 0.78%) ~ 4.21s 4.31s p=0.089 n=6
Total Time 14.87s (± 0.37%) 14.92s (± 0.57%) ~ 14.81s 15.04s p=0.261 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,716k (± 0.01%) 475,702k (± 0.00%) ~ 475,685k 475,727k p=0.873 n=6
Parse Time 3.33s (± 0.31%) 3.33s (± 0.23%) ~ 3.32s 3.34s p=0.931 n=6
Bind Time 1.02s (± 0.50%) 1.02s (± 0.62%) ~ 1.01s 1.03s p=0.386 n=6
Check Time 18.15s (± 0.45%) 18.24s (± 0.39%) ~ 18.13s 18.32s p=0.066 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.50s (± 0.37%) 22.59s (± 0.28%) ~ 22.48s 22.66s p=0.053 n=6
xstate - node (v16.17.1, x64)
Memory used 546,058k (± 0.02%) 546,129k (± 0.02%) ~ 546,023k 546,289k p=0.173 n=6
Parse Time 4.24s (± 0.19%) 4.26s (± 0.41%) +0.02s (+ 0.47%) 4.24s 4.29s p=0.048 n=6
Bind Time 1.81s (± 0.29%) 1.82s (± 0.57%) ~ 1.80s 1.83s p=0.077 n=6
Check Time 3.07s (± 0.63%) 3.06s (± 0.70%) ~ 3.03s 3.08s p=0.567 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=0.174 n=6
Total Time 9.21s (± 0.20%) 9.23s (± 0.32%) ~ 9.20s 9.28s p=0.198 n=6
Angular - node (v14.15.1, x64)
Memory used 352,281k (± 0.00%) 352,274k (± 0.00%) ~ 352,260k 352,290k p=0.261 n=6
Parse Time 3.71s (± 0.41%) 3.73s (± 0.73%) ~ 3.69s 3.77s p=0.463 n=6
Bind Time 1.28s (± 0.32%) 1.28s (± 0.40%) ~ 1.28s 1.29s p=0.595 n=6
Check Time 9.82s (± 0.39%) 9.85s (± 0.46%) ~ 9.79s 9.93s p=0.570 n=6
Emit Time 8.40s (± 0.73%) 8.39s (± 0.80%) ~ 8.33s 8.48s p=0.628 n=6
Total Time 23.22s (± 0.28%) 23.25s (± 0.53%) ~ 23.14s 23.45s p=0.936 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,203k (± 0.71%) 187,188k (± 0.71%) ~ 186,599k 189,920k p=0.689 n=6
Parse Time 1.57s (± 0.52%) 1.58s (± 0.33%) +0.01s (+ 0.64%) 1.58s 1.59s p=0.033 n=6
Bind Time 0.85s (± 0.64%) 0.86s (± 0.88%) ~ 0.85s 0.87s p=0.476 n=6
Check Time 10.17s (± 0.32%) 10.29s (± 0.37%) +0.12s (+ 1.18%) 10.24s 10.34s p=0.005 n=6
Emit Time 3.18s (± 0.92%) 3.17s (± 1.05%) ~ 3.12s 3.22s p=0.571 n=6
Total Time 15.78s (± 0.26%) 15.89s (± 0.36%) +0.12s (+ 0.75%) 15.84s 15.99s p=0.005 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,099k (± 0.00%) 338,105k (± 0.00%) ~ 338,092k 338,117k p=0.297 n=6
Parse Time 2.90s (± 0.28%) 2.90s (± 0.71%) ~ 2.87s 2.92s p=1.000 n=6
Bind Time 1.12s (± 0.49%) 1.12s (± 0.46%) +0.01s (+ 0.75%) 1.12s 1.13s p=0.038 n=6
Check Time 8.14s (± 0.59%) 8.09s (± 0.32%) -0.06s (- 0.70%) 8.06s 8.12s p=0.040 n=6
Emit Time 4.78s (± 0.50%) 4.76s (± 0.49%) ~ 4.74s 4.79s p=0.256 n=6
Total Time 16.94s (± 0.37%) 16.87s (± 0.34%) ~ 16.79s 16.93s p=0.065 n=6
TFS - node (v14.15.1, x64)
Memory used 294,322k (± 0.00%) 294,316k (± 0.00%) ~ 294,300k 294,327k p=0.688 n=6
Parse Time 2.38s (± 1.04%) 2.39s (± 0.43%) ~ 2.37s 2.40s p=0.935 n=6
Bind Time 1.11s (± 0.95%) 1.10s (± 0.81%) ~ 1.09s 1.11s p=0.452 n=6
Check Time 7.54s (± 0.38%) 7.56s (± 0.31%) ~ 7.53s 7.60s p=0.165 n=6
Emit Time 4.62s (± 0.54%) 4.62s (± 0.58%) ~ 4.59s 4.65s p=1.000 n=6
Total Time 15.65s (± 0.26%) 15.67s (± 0.31%) ~ 15.59s 15.71s p=0.519 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,221k (± 0.00%) 471,238k (± 0.00%) ~ 471,215k 471,266k p=0.127 n=6
Parse Time 3.49s (± 0.35%) 3.49s (± 0.50%) ~ 3.47s 3.52s p=0.461 n=6
Bind Time 1.04s (± 0.50%) 1.04s (± 0.39%) ~ 1.03s 1.04s p=0.595 n=6
Check Time 19.13s (± 0.46%) 19.12s (± 0.26%) ~ 19.08s 19.20s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.66s (± 0.40%) 23.66s (± 0.24%) ~ 23.59s 23.75s p=0.688 n=6
xstate - node (v14.15.1, x64)
Memory used 534,492k (± 0.01%) 534,466k (± 0.00%) ~ 534,440k 534,498k p=0.230 n=6
Parse Time 4.58s (± 0.18%) 4.58s (± 0.49%) ~ 4.56s 4.61s p=1.000 n=6
Bind Time 1.72s (± 0.57%) 1.73s (± 0.70%) ~ 1.71s 1.74s p=0.508 n=6
Check Time 3.16s (± 0.53%) 3.16s (± 0.43%) ~ 3.14s 3.18s p=1.000 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 4.01%) ~ 0.10s 0.11s p=0.405 n=6
Total Time 9.57s (± 0.21%) 9.58s (± 0.23%) ~ 9.54s 9.60s p=0.683 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52834 6
Baseline main 6

TSServer

Comparison Report - main..52834
Metric main 52834 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,379ms (± 1.15%) 2,392ms (± 0.90%) ~ 2,370ms 2,427ms p=0.688 n=6
Req 2 - geterr 5,371ms (± 0.57%) 5,368ms (± 0.72%) ~ 5,311ms 5,421ms p=0.809 n=6
Req 3 - references 341ms (± 0.99%) 343ms (± 1.31%) ~ 335ms 348ms p=0.226 n=6
Req 4 - navto 281ms (± 0.65%) 282ms (± 1.09%) ~ 279ms 287ms p=0.805 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 72ms (± 1.52%) 74ms (± 9.23%) ~ 70ms 88ms p=0.868 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,503ms (± 0.78%) 2,534ms (± 0.84%) +32ms (+ 1.27%) 2,506ms 2,557ms p=0.045 n=6
Req 2 - geterr 4,037ms (± 0.75%) 4,032ms (± 0.46%) ~ 3,998ms 4,049ms p=0.810 n=6
Req 3 - references 353ms (± 0.51%) 354ms (± 0.61%) ~ 350ms 356ms p=0.625 n=6
Req 4 - navto 288ms (± 0.56%) 288ms (± 0.74%) ~ 284ms 290ms p=0.934 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 0.81%) 67ms (± 0.77%) ~ 67ms 68ms p=0.640 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,190ms (± 0.65%) 3,190ms (± 1.09%) ~ 3,153ms 3,238ms p=0.689 n=6
Req 2 - geterr 1,640ms (± 0.71%) 1,648ms (± 0.70%) ~ 1,630ms 1,659ms p=0.297 n=6
Req 3 - references 104ms (± 1.22%) 104ms (± 1.99%) ~ 101ms 106ms p=0.805 n=6
Req 4 - navto 357ms (± 0.91%) 360ms (± 1.70%) ~ 355ms 372ms p=0.167 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 426ms (± 1.09%) 428ms (± 1.85%) ~ 417ms 437ms p=0.377 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,535ms (± 0.66%) 2,540ms (± 0.78%) ~ 2,520ms 2,568ms p=0.810 n=6
Req 2 - geterr 5,757ms (± 0.62%) 5,757ms (± 0.45%) ~ 5,730ms 5,805ms p=0.936 n=6
Req 3 - references 350ms (± 0.58%) 353ms (± 1.33%) ~ 348ms 361ms p=0.332 n=6
Req 4 - navto 280ms (± 0.84%) 278ms (± 0.95%) ~ 275ms 282ms p=0.462 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 3.80%) 81ms (± 6.79%) ~ 75ms 88ms p=0.377 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,683ms (± 1.20%) 2,699ms (± 0.48%) ~ 2,687ms 2,720ms p=0.688 n=6
Req 2 - geterr 4,377ms (± 0.50%) 4,405ms (± 0.54%) ~ 4,366ms 4,429ms p=0.092 n=6
Req 3 - references 366ms (± 1.04%) 363ms (± 0.92%) ~ 358ms 367ms p=0.145 n=6
Req 4 - navto 282ms (± 1.16%) 284ms (± 1.39%) ~ 277ms 288ms p=0.465 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 73ms (± 0.87%) 73ms (± 0.70%) ~ 73ms 74ms p=0.386 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,370ms (± 0.28%) 3,365ms (± 0.55%) ~ 3,346ms 3,399ms p=0.297 n=6
Req 2 - geterr 1,839ms (± 3.77%) 1,875ms (± 4.96%) ~ 1,809ms 2,012ms p=0.336 n=6
Req 3 - references 111ms (± 2.13%) 113ms (± 2.23%) ~ 109ms 115ms p=0.219 n=6
Req 4 - navto 345ms (± 1.27%) 345ms (± 0.76%) ~ 342ms 349ms p=0.569 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 431ms (± 0.82%) 432ms (± 0.78%) ~ 429ms 437ms p=0.936 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,624ms (± 0.48%) 2,607ms (± 0.30%) -17ms (- 0.64%) 2,600ms 2,618ms p=0.024 n=6
Req 2 - geterr 6,095ms (± 0.55%) 6,102ms (± 0.30%) ~ 6,071ms 6,125ms p=0.810 n=6
Req 3 - references 366ms (± 0.33%) 368ms (± 0.71%) ~ 364ms 371ms p=0.126 n=6
Req 4 - navto 281ms (± 1.80%) 280ms (± 1.38%) ~ 276ms 286ms p=0.935 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 101ms (± 0.63%) 100ms (± 1.04%) -1ms (- 1.32%) 98ms 101ms p=0.028 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,838ms (± 0.90%) 2,846ms (± 0.49%) ~ 2,829ms 2,865ms p=0.748 n=6
Req 2 - geterr 4,619ms (± 2.63%) 4,590ms (± 2.82%) ~ 4,463ms 4,717ms p=0.936 n=6
Req 3 - references 380ms (± 0.86%) 387ms (± 5.46%) ~ 375ms 430ms p=0.739 n=6
Req 4 - navto 293ms (± 1.31%) 294ms (± 1.65%) ~ 287ms 299ms p=0.936 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 86ms (± 9.49%) 85ms (± 6.53%) ~ 81ms 96ms p=0.870 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,684ms (± 0.86%) 3,708ms (± 0.63%) ~ 3,689ms 3,753ms p=0.230 n=6
Req 2 - geterr 1,856ms (± 2.24%) 1,860ms (± 2.15%) ~ 1,812ms 1,901ms p=1.000 n=6
Req 3 - references 127ms (± 3.89%) 126ms (± 2.45%) ~ 123ms 130ms p=0.625 n=6
Req 4 - navto 376ms (± 1.62%) 376ms (± 1.89%) ~ 363ms 383ms p=1.000 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 457ms (± 2.63%) 453ms (± 1.92%) ~ 442ms 462ms p=0.810 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52834 6
Baseline main 6

Startup

Comparison Report - main..52834
Metric main 52834 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.31ms (± 0.19%) 142.30ms (± 0.21%) ~ 141.62ms 147.51ms p=0.124 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.77ms (± 0.18%) 226.65ms (± 0.17%) -0.12ms (- 0.05%) 225.76ms 233.52ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.58ms (± 0.21%) 228.42ms (± 0.14%) -0.16ms (- 0.07%) 227.47ms 232.55ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.39ms (± 0.18%) 209.31ms (± 0.18%) -0.08ms (- 0.04%) 208.40ms 215.24ms p=0.005 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52834 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

Guess that's a no.

@jakebailey jakebailey closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @typescript-bot