-
Notifications
You must be signed in to change notification settings - Fork 12.8k
[experiment] Hack build to produce top level let bindings #52928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot perf test faster |
Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 122359e. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:Comparison Report - main..52928
System
Hosts
Scenarios
Developer Information: |
Conspiracy theory mostly disproven. This regresses performance a little, but not enough to completely negate the modules PR. This implies that most of the performance was gained by scope hosting providing direct access / local bindings, kind of like #52920 but applied to the entire codebase. |
Conspiracy theory: the perf boost from modules/esbuild didn't come from scope hoisting, it came from all of our top-level variables turning into
var
.