Skip to content

Investigate: No floating promises #53146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RyanCavanaugh
Copy link
Member

Implements #13376 to see what the breakage would be (obviously unshippable as a default)

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 7, 2023
@jakebailey
Copy link
Member

Test failure is because I just merged #53025, which drops >null : null from our baselines (just like we drop >undefined : undefined. I'm really on a roll with breaking your PRs today.

@RyanCavanaugh RyanCavanaugh reopened this Mar 7, 2023
@RyanCavanaugh
Copy link
Member Author

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 9751a5b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 9751a5b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 9751a5b. You can monitor the build here.

Update: The results are in! Part 1, Part 2

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at 9751a5b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 9751a5b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 9751a5b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 9751a5b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/53146/merge:

Something interesting changed - please have a look.

Details

adonis-framework

/mnt/ts_downloads/adonis-framework/tsconfig.json

  • [NEW] error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator
    • /mnt/ts_downloads/adonis-framework/node_modules/adonis-framework/src/Server/index.js(224,5)

axios-src

test/module/typings/cjs/tsconfig.json

test/module/typings/esm/tsconfig.json

tsconfig.json

formik

/mnt/ts_downloads/formik/tsconfig.json

  • [NEW] error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator
    • /mnt/ts_downloads/formik/index.tsx(46,9)

fp-ts

dtslint/ts3.5/tsconfig.json

  • [NEW] error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

examples/tsconfig.json

tsconfig.build-es6.json

  • [NEW] error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

tsconfig.json

puppeteer

packages/browsers/test/src/tsconfig.json

packages/puppeteer-core/tsconfig.json

test/tsconfig.json

TypeScript-Node-Starter

tsconfig.json

  • [NEW] error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the user test suite

Details

webpack

tsconfig.json

tsconfig.module.test.json

tsconfig.types.json

tsconfig.types.test.json

xterm.js

demo/tsconfig.json

  • [NEW] error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

src/tsconfig-library-base.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/53146/merge:

Unfortunately, something went wrong, but it probably wasn't caused by your change.

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53146
Metric main 53146 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,795k (± 0.02%) 359,869k (± 0.02%) ~ 359,805k 359,949k p=0.066 n=6
Parse Time 3.50s (± 0.55%) 3.49s (± 0.53%) ~ 3.47s 3.52s p=0.870 n=6
Bind Time 1.12s (± 0.88%) 1.12s (± 0.67%) ~ 1.11s 1.13s p=1.000 n=6
Check Time 8.63s (± 0.65%) 8.62s (± 0.31%) ~ 8.59s 8.66s p=1.000 n=6
Emit Time 7.42s (± 0.69%) 7.44s (± 0.42%) ~ 7.41s 7.48s p=0.226 n=6
Total Time 20.67s (± 0.47%) 20.68s (± 0.25%) ~ 20.61s 20.75s p=0.748 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,671k (± 1.18%) 191,687k (± 1.21%) ~ 190,616k 196,411k p=0.810 n=6
Parse Time 1.48s (± 0.60%) 1.48s (± 0.43%) ~ 1.47s 1.49s p=1.000 n=6
Bind Time 0.77s (± 0.82%) 0.77s (± 0.82%) ~ 0.76s 0.78s p=1.000 n=6
Check Time 9.38s (± 0.73%) 9.34s (± 0.68%) ~ 9.26s 9.43s p=0.378 n=6
Emit Time 2.74s (± 0.54%) 2.73s (± 1.03%) ~ 2.70s 2.77s p=0.223 n=6
Total Time 14.37s (± 0.46%) 14.31s (± 0.61%) ~ 14.22s 14.42s p=0.336 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,847k (± 0.01%) 343,871k (± 0.01%) ~ 343,811k 343,922k p=0.471 n=6
Parse Time 2.62s (± 1.27%) 2.61s (± 1.07%) ~ 2.58s 2.66s p=0.808 n=6
Bind Time 1.01s (± 0.81%) 1.01s (± 1.53%) ~ 1.00s 1.04s p=1.000 n=6
Check Time 7.02s (± 0.13%) 7.01s (± 0.34%) ~ 6.99s 7.05s p=0.370 n=6
Emit Time 4.20s (± 0.29%) 4.21s (± 0.77%) ~ 4.17s 4.25s p=0.871 n=6
Total Time 14.85s (± 0.31%) 14.85s (± 0.42%) ~ 14.76s 14.93s p=1.000 n=6
TFS - node (v18.10.0, x64)
Memory used 299,876k (± 0.01%) 299,894k (± 0.01%) ~ 299,848k 299,939k p=0.378 n=6
Parse Time 2.04s (± 1.37%) 2.04s (± 1.10%) ~ 2.03s 2.09s p=0.808 n=6
Bind Time 1.13s (± 0.48%) 1.14s (± 0.36%) ~ 1.13s 1.14s p=0.282 n=6
Check Time 6.49s (± 0.55%) 6.51s (± 0.39%) ~ 6.47s 6.54s p=0.375 n=6
Emit Time 3.85s (± 0.78%) 3.87s (± 1.11%) ~ 3.82s 3.94s p=0.514 n=6
Total Time 13.52s (± 0.59%) 13.57s (± 0.52%) ~ 13.50s 13.69s p=0.335 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,447k (± 0.00%) 476,463k (± 0.01%) ~ 476,425k 476,513k p=0.630 n=6
Parse Time 3.11s (± 0.83%) 3.13s (± 0.83%) ~ 3.09s 3.16s p=0.374 n=6
Bind Time 0.91s (± 0.69%) 0.91s (± 1.20%) ~ 0.90s 0.93s p=0.787 n=6
Check Time 17.11s (± 0.69%) 17.10s (± 0.34%) ~ 17.00s 17.16s p=0.872 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.13s (± 0.64%) 21.14s (± 0.37%) ~ 20.99s 21.21s p=0.378 n=6
xstate - node (v18.10.0, x64)
Memory used 548,889k (± 0.02%) 549,145k (± 0.03%) +256k (+ 0.05%) 548,970k 549,371k p=0.030 n=6
Parse Time 4.08s (± 0.20%) 4.07s (± 0.57%) ~ 4.04s 4.11s p=0.452 n=6
Bind Time 1.67s (± 0.33%) 1.67s (± 0.82%) ~ 1.65s 1.68s p=0.341 n=6
Check Time 2.77s (± 0.85%) 2.77s (± 0.50%) ~ 2.75s 2.79s p=0.935 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.60s (± 0.33%) 8.59s (± 0.44%) ~ 8.54s 8.65s p=0.572 n=6
Angular - node (v16.17.1, x64)
Memory used 359,096k (± 0.01%) 359,196k (± 0.01%) +99k (+ 0.03%) 359,169k 359,224k p=0.005 n=6
Parse Time 3.71s (± 0.24%) 3.70s (± 0.20%) ~ 3.69s 3.71s p=0.053 n=6
Bind Time 1.19s (± 0.34%) 1.19s (± 0.75%) ~ 1.18s 1.20s p=0.787 n=6
Check Time 9.41s (± 0.31%) 9.43s (± 0.36%) ~ 9.38s 9.47s p=0.628 n=6
Emit Time 7.89s (± 0.63%) 7.89s (± 0.75%) ~ 7.82s 7.99s p=0.872 n=6
Total Time 22.20s (± 0.29%) 22.20s (± 0.22%) ~ 22.12s 22.27s p=0.935 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,360k (± 0.02%) 193,363k (± 0.79%) ~ 192,336k 195,718k p=0.066 n=6
Parse Time 1.56s (± 0.48%) 1.56s (± 0.33%) ~ 1.56s 1.57s p=0.241 n=6
Bind Time 0.82s (± 0.67%) 0.82s (± 0.00%) ~ 0.82s 0.82s p=0.071 n=6
Check Time 10.10s (± 0.98%) 10.10s (± 0.51%) ~ 10.01s 10.15s p=1.000 n=6
Emit Time 2.99s (± 0.69%) 2.99s (± 0.70%) ~ 2.96s 3.01s p=0.806 n=6
Total Time 15.47s (± 0.69%) 15.47s (± 0.32%) ~ 15.41s 15.52s p=0.747 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,107k (± 0.00%) 343,121k (± 0.00%) ~ 343,106k 343,133k p=0.149 n=6
Parse Time 2.79s (± 0.42%) 2.80s (± 1.08%) ~ 2.76s 2.84s p=0.418 n=6
Bind Time 1.08s (± 0.00%) 1.08s (± 0.75%) ~ 1.07s 1.09s p=0.290 n=6
Check Time 7.69s (± 0.34%) 7.69s (± 0.44%) ~ 7.63s 7.72s p=0.468 n=6
Emit Time 4.43s (± 0.91%) 4.43s (± 0.54%) ~ 4.39s 4.46s p=0.744 n=6
Total Time 15.98s (± 0.30%) 16.01s (± 0.39%) ~ 15.94s 16.07s p=0.518 n=6
TFS - node (v16.17.1, x64)
Memory used 299,239k (± 0.01%) 299,268k (± 0.01%) ~ 299,232k 299,317k p=0.054 n=6
Parse Time 2.15s (± 0.70%) 2.15s (± 0.59%) ~ 2.13s 2.17s p=0.564 n=6
Bind Time 1.24s (± 0.97%) 1.24s (± 1.10%) ~ 1.22s 1.26s p=1.000 n=6
Check Time 7.20s (± 0.42%) 7.17s (± 0.47%) ~ 7.13s 7.23s p=0.120 n=6
Emit Time 4.35s (± 0.77%) 4.34s (± 0.47%) ~ 4.32s 4.37s p=0.374 n=6
Total Time 14.95s (± 0.52%) 14.91s (± 0.26%) ~ 14.85s 14.96s p=0.128 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,667k (± 0.00%) 475,690k (± 0.00%) ~ 475,664k 475,719k p=0.128 n=6
Parse Time 3.29s (± 0.32%) 3.29s (± 0.35%) ~ 3.27s 3.30s p=0.279 n=6
Bind Time 0.95s (± 0.54%) 0.95s (± 0.57%) ~ 0.95s 0.96s p=0.640 n=6
Check Time 18.04s (± 0.26%) 18.06s (± 0.43%) ~ 17.97s 18.20s p=0.808 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.28s (± 0.24%) 22.31s (± 0.34%) ~ 22.23s 22.45s p=0.748 n=6
xstate - node (v16.17.1, x64)
Memory used 546,492k (± 0.02%) 546,731k (± 0.02%) +239k (+ 0.04%) 546,583k 546,929k p=0.013 n=6
Parse Time 4.25s (± 0.25%) 4.27s (± 0.28%) ~ 4.25s 4.28s p=0.139 n=6
Bind Time 1.76s (± 0.46%) 1.75s (± 0.69%) ~ 1.74s 1.77s p=0.677 n=6
Check Time 2.97s (± 0.58%) 2.97s (± 0.63%) ~ 2.95s 3.00s p=0.680 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 9.07s (± 0.26%) 9.09s (± 0.28%) ~ 9.06s 9.12s p=0.168 n=6
Angular - node (v14.15.1, x64)
Memory used 352,879k (± 0.00%) 352,959k (± 0.00%) +80k (+ 0.02%) 352,935k 352,968k p=0.005 n=6
Parse Time 3.70s (± 0.56%) 3.71s (± 0.85%) ~ 3.67s 3.75s p=1.000 n=6
Bind Time 1.24s (± 0.44%) 1.25s (± 0.65%) ~ 1.24s 1.26s p=0.859 n=6
Check Time 9.76s (± 0.33%) 9.72s (± 0.51%) ~ 9.65s 9.80s p=0.198 n=6
Emit Time 8.35s (± 0.93%) 8.34s (± 0.44%) ~ 8.30s 8.39s p=0.629 n=6
Total Time 23.06s (± 0.40%) 23.01s (± 0.34%) ~ 22.92s 23.15s p=0.171 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,653k (± 0.01%) 187,643k (± 0.01%) ~ 187,627k 187,663k p=0.377 n=6
Parse Time 1.57s (± 0.33%) 1.56s (± 0.87%) ~ 1.55s 1.59s p=0.056 n=6
Bind Time 0.84s (± 1.17%) 0.84s (± 0.49%) ~ 0.83s 0.84s p=0.673 n=6
Check Time 10.19s (± 0.31%) 10.16s (± 0.34%) ~ 10.10s 10.19s p=0.168 n=6
Emit Time 3.10s (± 0.27%) 3.12s (± 0.74%) ~ 3.10s 3.16s p=0.170 n=6
Total Time 15.71s (± 0.20%) 15.68s (± 0.20%) ~ 15.63s 15.72s p=0.413 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,125k (± 0.01%) 338,145k (± 0.01%) ~ 338,119k 338,171k p=0.109 n=6
Parse Time 2.88s (± 0.82%) 2.87s (± 0.43%) ~ 2.86s 2.89s p=0.935 n=6
Bind Time 1.10s (± 0.37%) 1.10s (± 0.57%) ~ 1.09s 1.11s p=0.673 n=6
Check Time 8.09s (± 0.81%) 8.10s (± 0.76%) ~ 8.04s 8.21s p=0.688 n=6
Emit Time 4.67s (± 0.77%) 4.68s (± 0.59%) ~ 4.64s 4.72s p=0.935 n=6
Total Time 16.74s (± 0.57%) 16.76s (± 0.49%) ~ 16.66s 16.88s p=0.748 n=6
TFS - node (v14.15.1, x64)
Memory used 294,308k (± 0.00%) 294,307k (± 0.00%) ~ 294,286k 294,320k p=0.575 n=6
Parse Time 2.38s (± 0.77%) 2.39s (± 0.73%) ~ 2.37s 2.42s p=0.935 n=6
Bind Time 1.06s (± 0.49%) 1.07s (± 1.40%) ~ 1.06s 1.10s p=0.191 n=6
Check Time 7.44s (± 0.51%) 7.45s (± 0.42%) ~ 7.41s 7.49s p=0.808 n=6
Emit Time 4.30s (± 0.60%) 4.28s (± 0.70%) ~ 4.24s 4.32s p=0.420 n=6
Total Time 15.18s (± 0.27%) 15.19s (± 0.21%) ~ 15.16s 15.24s p=0.629 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,390k (± 0.00%) 471,394k (± 0.00%) ~ 471,356k 471,415k p=0.810 n=6
Parse Time 3.44s (± 0.43%) 3.46s (± 0.42%) +0.02s (+ 0.58%) 3.45s 3.49s p=0.042 n=6
Bind Time 1.00s (± 0.63%) 1.00s (± 0.75%) ~ 0.99s 1.01s p=0.718 n=6
Check Time 18.96s (± 0.46%) 18.94s (± 0.56%) ~ 18.84s 19.11s p=0.872 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.40s (± 0.36%) 23.40s (± 0.43%) ~ 23.30s 23.57s p=0.873 n=6
xstate - node (v14.15.1, x64)
Memory used 535,181k (± 0.01%) 535,398k (± 0.00%) +217k (+ 0.04%) 535,377k 535,427k p=0.005 n=6
Parse Time 4.45s (± 0.58%) 4.47s (± 1.11%) ~ 4.44s 4.57s p=0.684 n=6
Bind Time 1.80s (± 0.65%) 1.77s (± 2.88%) ~ 1.67s 1.81s p=0.250 n=6
Check Time 3.17s (± 0.46%) 3.16s (± 0.64%) ~ 3.13s 3.19s p=0.466 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 4.45%) ~ 0.09s 0.10s p=0.405 n=6
Total Time 9.50s (± 0.39%) 9.50s (± 0.31%) ~ 9.46s 9.55s p=0.746 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53146 6
Baseline main 6

TSServer

Comparison Report - main..53146
Metric main 53146 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,362ms (± 0.46%) 2,365ms (± 0.27%) ~ 2,357ms 2,373ms p=0.260 n=6
Req 2 - geterr 5,352ms (± 0.58%) 5,336ms (± 0.75%) ~ 5,300ms 5,414ms p=0.336 n=6
Req 3 - references 328ms (± 1.45%) 327ms (± 0.99%) ~ 323ms 331ms p=0.806 n=6
Req 4 - navto 282ms (± 1.33%) 284ms (± 1.23%) ~ 281ms 288ms p=0.374 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 85ms (± 5.61%) 84ms (± 6.52%) ~ 79ms 90ms p=0.803 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,512ms (± 1.55%) 2,508ms (± 0.61%) ~ 2,482ms 2,525ms p=0.936 n=6
Req 2 - geterr 4,010ms (± 0.63%) 4,010ms (± 0.22%) ~ 4,002ms 4,026ms p=0.471 n=6
Req 3 - references 347ms (± 1.42%) 347ms (± 0.38%) ~ 345ms 349ms p=0.567 n=6
Req 4 - navto 292ms (± 0.76%) 292ms (± 0.66%) ~ 291ms 296ms p=1.000 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 73ms (± 7.84%) 71ms (± 4.50%) ~ 67ms 74ms p=0.685 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,162ms (± 0.50%) 3,158ms (± 0.85%) ~ 3,135ms 3,210ms p=0.298 n=6
Req 2 - geterr 1,610ms (± 0.78%) 1,599ms (± 0.99%) ~ 1,578ms 1,622ms p=0.172 n=6
Req 3 - references 104ms (± 2.43%) 104ms (± 1.99%) ~ 101ms 106ms p=1.000 n=6
Req 4 - navto 360ms (± 0.65%) 362ms (± 2.27%) ~ 356ms 378ms p=0.808 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 427ms (± 0.49%) 427ms (± 1.35%) ~ 418ms 434ms p=0.872 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,459ms (± 1.08%) 2,485ms (± 1.37%) ~ 2,454ms 2,523ms p=0.065 n=6
Req 2 - geterr 5,745ms (± 0.31%) 5,740ms (± 0.37%) ~ 5,717ms 5,779ms p=0.688 n=6
Req 3 - references 343ms (± 0.35%) 343ms (± 0.50%) ~ 340ms 345ms p=0.806 n=6
Req 4 - navto 277ms (± 0.63%) 282ms (± 1.30%) +4ms (+ 1.50%) 278ms 288ms p=0.038 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 94ms (± 2.47%) 94ms (± 2.27%) ~ 91ms 96ms p=0.737 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,670ms (± 0.62%) 2,673ms (± 0.69%) ~ 2,642ms 2,697ms p=0.689 n=6
Req 2 - geterr 4,350ms (± 0.53%) 4,367ms (± 0.40%) ~ 4,339ms 4,390ms p=0.199 n=6
Req 3 - references 361ms (± 0.30%) 359ms (± 0.52%) -2ms (- 0.65%) 356ms 361ms p=0.032 n=6
Req 4 - navto 288ms (± 0.80%) 289ms (± 0.58%) ~ 287ms 291ms p=0.804 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 3.47%) 76ms (± 2.85%) ~ 73ms 78ms p=0.415 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,343ms (± 0.42%) 3,342ms (± 0.46%) ~ 3,322ms 3,361ms p=1.000 n=6
Req 2 - geterr 1,800ms (± 4.87%) 1,743ms (± 0.32%) ~ 1,735ms 1,752ms p=0.575 n=6
Req 3 - references 113ms (± 2.74%) 112ms (± 1.54%) ~ 109ms 114ms p=0.419 n=6
Req 4 - navto 345ms (± 0.91%) 344ms (± 0.76%) ~ 341ms 348ms p=0.809 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 431ms (± 1.57%) 432ms (± 0.71%) ~ 428ms 436ms p=0.422 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,572ms (± 0.57%) 2,562ms (± 0.28%) ~ 2,552ms 2,569ms p=0.297 n=6
Req 2 - geterr 6,071ms (± 0.63%) 6,087ms (± 0.82%) ~ 6,031ms 6,163ms p=0.471 n=6
Req 3 - references 358ms (± 1.47%) 357ms (± 0.49%) ~ 354ms 359ms p=0.742 n=6
Req 4 - navto 277ms (± 1.28%) 278ms (± 0.35%) ~ 277ms 279ms p=0.288 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 99ms (± 4.11%) 102ms (± 0.74%) ~ 101ms 103ms p=0.301 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,797ms (± 0.72%) 2,796ms (± 0.42%) ~ 2,776ms 2,810ms p=0.689 n=6
Req 2 - geterr 4,490ms (± 2.10%) 4,556ms (± 2.70%) ~ 4,427ms 4,672ms p=0.689 n=6
Req 3 - references 368ms (± 0.59%) 368ms (± 0.22%) ~ 367ms 369ms p=0.869 n=6
Req 4 - navto 294ms (± 0.59%) 292ms (± 1.25%) ~ 288ms 297ms p=0.288 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 93ms (±10.82%) 86ms (± 9.80%) ~ 82ms 103ms p=0.060 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,652ms (± 0.87%) 3,641ms (± 0.28%) ~ 3,629ms 3,656ms p=0.230 n=6
Req 2 - geterr 1,842ms (± 0.48%) 1,843ms (± 1.03%) ~ 1,820ms 1,864ms p=0.873 n=6
Req 3 - references 129ms (± 3.14%) 128ms (± 2.34%) ~ 124ms 131ms p=0.684 n=6
Req 4 - navto 376ms (± 0.57%) 374ms (± 0.73%) ~ 369ms 376ms p=0.293 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 458ms (± 2.80%) 454ms (± 2.64%) ~ 441ms 471ms p=0.520 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53146 6
Baseline main 6

Startup

Comparison Report - main..53146
Metric main 53146 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.42ms (± 0.20%) 141.47ms (± 0.17%) ~ 140.86ms 144.14ms p=0.057 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 225.55ms (± 0.14%) 226.16ms (± 0.16%) +0.62ms (+ 0.27%) 225.29ms 230.95ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.82ms (± 0.20%) 228.20ms (± 0.17%) +0.38ms (+ 0.17%) 227.21ms 236.17ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.24ms (± 0.24%) 208.94ms (± 0.16%) -0.30ms (- 0.14%) 207.86ms 213.96ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53146 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

Hey @RyanCavanaugh, the results of running the DT tests are ready.
There were interesting changes:
Changes are too big to display here, please check the log.
You can check the log here.

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/53146/merge:

Something interesting changed - please have a look.

Details

akveo/ngx-admin

src/tsconfig.app.json

tsconfig.json

angular/angular-cli

11 of 19 projects failed to build with the old tsc and were ignored

packages/angular_devkit/build_webpack/test/angular-app/src/tsconfig.app.json

tests/legacy-cli/e2e/assets/13.0-project/tsconfig.app.json

tests/legacy-cli/e2e/assets/13.0-project/tsconfig.json

tests/legacy-cli/e2e/assets/webpack/test-app/tsconfig.json

tests/legacy-cli/tsconfig.json

AykutSarac/jsoncrack.com

tsconfig.json

conwnet/github1s

extensions/github1s/tsconfig.json

tests/tsconfig.json

  • error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

tsconfig.json

  • error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

vscode-web/tsconfig.json

  • error TS7062: A Promise must be awaited, returned, or explicitly ignored with the 'void' operator

directus/directus

10 of 13 projects failed to build with the old tsc and were ignored

packages/shared/tsconfig.json

tests-blackbox/tsconfig.json

electron-react-boilerplate/electron-react-boilerplate

tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top-repos suite

Details

Eugeny/tabby

19 of 29 projects failed to build with the old tsc and were ignored

app/tsconfig.json

app/tsconfig.main.json

tabby-core/tsconfig.json

tabby-core/tsconfig.typings.json

tabby-plugin-manager/tsconfig.json

tabby-settings/tsconfig.json

tabby-settings/tsconfig.typings.json

tabby-web/tsconfig.json

tabby-web/tsconfig.typings.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top-repos suite

Details

excalidraw/excalidraw

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig-types.json

tsconfig.json

freeCodeCamp/freeCodeCamp

5 of 10 projects failed to build with the old tsc and were ignored

tools/challenge-editor/client/tsconfig.json

homebridge/homebridge

tsconfig.json

immutable-js/immutable-js

1 of 4 projects failed to build with the old tsc and were ignored

website/tsconfig.json

ionic-team/ionic-framework

16 of 20 projects failed to build with the old tsc and were ignored

angular/test/apps/ng12/tsconfig.json

angular/test/apps/ng13/tsconfig.json

angular/tsconfig.json

jquense/yup

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

lerna/lerna

tools/scripts/tsconfig.e2e.json

tools/scripts/tsconfig.scripts.json

lyswhut/lx-music-desktop

1 of 6 projects failed to build with the old tsc and were ignored

src/common/tsconfig.json

src/main/tsconfig.json

src/renderer/tsconfig.json

microsoft/playwright

4 of 14 projects failed to build with the old tsc and were ignored

tests/components/ct-react/tsconfig.json

utils/generate_types/test/tsconfig.json

packages/html-reporter/tsconfig.json

packages/recorder/tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/53146/merge:

Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants