-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Investigate: No floating promises #53146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test failure is because I just merged #53025, which drops |
@typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 9751a5b. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 9751a5b. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 9751a5b. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at 9751a5b. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 9751a5b. You can monitor the build here. |
Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 9751a5b. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 9751a5b. You can monitor the build here. Update: The results are in! |
Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
@RyanCavanaugh Here are the results of running the user test suite comparing Unfortunately, something went wrong, but it probably wasn't caused by your change. |
@RyanCavanaugh Here they are:
CompilerComparison Report - main..53146
System
Hosts
Scenarios
TSServerComparison Report - main..53146
System
Hosts
Scenarios
StartupComparison Report - main..53146
System
Hosts
Scenarios
Developer Information: |
Hey @RyanCavanaugh, the results of running the DT tests are ready. |
@RyanCavanaugh Here are the results of running the top-repos suite comparing Everything looks good! |
Implements #13376 to see what the breakage would be (obviously unshippable as a default)